Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after we call them
This commit is contained in:
@@ -32,13 +32,13 @@ header("Pragma: ");
|
||||
|
||||
// is the user supposed to be viewing this image ?
|
||||
if(!$_SESSION['current']->canViewImage($aClean['iId']))
|
||||
util_show_error_page("Insufficient privileges.");
|
||||
util_show_error_page_and_exit("Insufficient privileges.");
|
||||
|
||||
if ($aClean['sREQUEST_METHOD']='HEAD')
|
||||
{
|
||||
/* WARNING! optimization of logic in include/screenshots.php */
|
||||
if (sscanf($aClean['iId'],"%d", &$iId) < 1)
|
||||
util_show_error_page("Bad parameter");
|
||||
util_show_error_page_and_exit("Bad parameter");
|
||||
|
||||
$hResult = query_parameters("SELECT id, url FROM appData
|
||||
WHERE id = '?'
|
||||
|
||||
Reference in New Issue
Block a user