Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()

so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
This commit is contained in:
Jonathan Ernst
2006-07-06 18:44:56 +00:00
committed by WineHQ
parent a34058b924
commit 3096e63828
41 changed files with 119 additions and 120 deletions

View File

@@ -53,7 +53,7 @@ if ($aClean['sSub'])
$oTest->update(true);
$oTest->ReQueue();
}
redirect($_SERVER['PHP_SELF']);
util_redirect_and_exit($_SERVER['PHP_SELF']);
} else
{
$aClean['sSub'] = 'view';
@@ -69,7 +69,7 @@ if ($aClean['sSub'])
$oTest->delete();
}
redirect($_SERVER['PHP_SELF']);
util_redirect_and_exit($_SERVER['PHP_SELF']);
}
// is this an old test?
@@ -81,7 +81,7 @@ if ($aClean['sSub'])
!$_SESSION['current']->hasAppVersionModifyPermission($oVersion)&&
!(($_SESSION['current']->iUserId == $oTest->iSubmitterId) && !($oTest->sQueued == 'false')))
{
util_show_error_page("Insufficient privileges.");
util_show_error_page_and_exit("Insufficient privileges.");
} else
$oVersion = new version($oTest->iVersionId);
} else
@@ -161,7 +161,7 @@ if ($aClean['sSub'])
{
// error no sub!
addmsg("Internal Routine Not Found!!", "red");
redirect($_SERVER['PHP_SELF']);
util_redirect_and_exit($_SERVER['PHP_SELF']);
}
}
else // if ($aClean['sSub']) is not defined, display the Testing results queue page