claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Properly close all of the html frames we opened with html_frame_start(). Fixes a bug where the

Browse Source 
back link appears inside of a frame and the page rendering time appears in an odd red bar at
the bottom of the page
This commit is contained in:
Chris Morgan
2007-06-16 21:16:12 +00:00
committed by WineHQ
parent 1d3050fc96
commit 41e90aec46
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
screenshots.php
View File

@@ -69,6 +69,9 @@ if($hResult && mysql_num_rows($hResult))
echo "<div align=center><table><tr>\n"; echo "<div align=center><table><tr>\n";
while($oRow = mysql_fetch_object($hResult)) while($oRow = mysql_fetch_object($hResult))
{ {
// if the current version changed then update the current version
// and close the previous html frame if this isn't the
// first frame
if(!$aClean['iVersionId'] && $oRow->versionId != $currentVersionId) if(!$aClean['iVersionId'] && $oRow->versionId != $currentVersionId)
{ {
if($currentVersionId) if($currentVersionId)
@@ -77,7 +80,7 @@ if($hResult && mysql_num_rows($hResult))
echo html_frame_end(); echo html_frame_end();
$c=1; $c=1;
} }
$currentVersionId=$oRow->versionId; $currentVersionId = $oRow->versionId;
echo html_frame_start("Version ".Version::lookup_name($currentVersionId)); echo html_frame_start("Version ".Version::lookup_name($currentVersionId));
echo "<div align=center><table><tr>\n"; echo "<div align=center><table><tr>\n";
} }
@@ -104,7 +107,8 @@ if($hResult && mysql_num_rows($hResult))
} }
echo "</tr></table></div><br />\n"; echo "</tr></table></div><br />\n";
echo html_frame_end("Click thumbnail to view image in new window."); echo html_frame_end(); // close the current version we are displaying
echo html_frame_end(); // close the "Screenshot Gallary..." html frame
} else { } else {
echo "<p align=\"center\">There are currently no screenshots for the selected version of this application."; echo "<p align=\"center\">There are currently no screenshots for the selected version of this application.";
echo "<br />Please consider submitting a screenshot for the selected version yourself.</p>"; echo "<br />Please consider submitting a screenshot for the selected version yourself.</p>";