diff --git a/account.php b/account.php index f9f25f7..bdde0d6 100644 --- a/account.php +++ b/account.php @@ -59,11 +59,9 @@ function do_account($sCmd = null) $_SESSION['current']->logout(); redirect(apidb_fullurl("index.php")); - exit; } //not valid command, display error page util_show_error_page("Internal Error","This module was called with incorrect parameters"); - exit; } /** diff --git a/addcomment.php b/addcomment.php index 4e91235..b156350 100644 --- a/addcomment.php +++ b/addcomment.php @@ -27,10 +27,7 @@ if(!$_SESSION['current']->isLoggedIn()) } if( !is_numeric($aClean['iVersionId']) ) -{ - util_show_error_page('Internal Database Access Error'); - exit; -} + util_show_error_page('Internal Database Access Error'); if(!is_numeric($aClean['iThread'])) { diff --git a/admin/addAppNote.php b/admin/addAppNote.php index 7e540ba..2acd497 100644 --- a/admin/addAppNote.php +++ b/admin/addAppNote.php @@ -27,7 +27,6 @@ if(!$_SESSION['current']->hasPriv("admin") && !$_SESSION['current']->isSuperMaintainer($aClean['iAppId'])) { util_show_error_page("Insufficient Privileges!"); - exit; } //set link for version @@ -45,7 +44,6 @@ if($aClean['sSub'] == "Submit") { $oNote->create(); redirect(apidb_fullurl("appview.php?".$sVersionLink)); - exit; } else if($aClean['sSub'] == 'Preview' OR empty($aClean['sSubmit'])) { diff --git a/admin/addCategory.php b/admin/addCategory.php index 3193c5e..a86a324 100644 --- a/admin/addCategory.php +++ b/admin/addCategory.php @@ -12,10 +12,8 @@ $aClean['iParentId'] = makeSafe($_REQUEST['iParentId']); $aClean['sSubmit'] = makeSafe($_REQUEST['sSubmit']); if(!$_SESSION['current']->hasPriv("admin")) -{ util_show_error_page(); - exit; -} + $oCat = new Category($aClean['iCatId']); if($aClean['sSubmit']) { diff --git a/admin/adminAppDataQueue.php b/admin/adminAppDataQueue.php index af187dc..e080b9e 100644 --- a/admin/adminAppDataQueue.php +++ b/admin/adminAppDataQueue.php @@ -20,10 +20,7 @@ $aClean['sReject'] = makeSafe($_REQUEST['sReject']); // deny access if not admin or at least some kind of maintainer if(!$_SESSION['current']->hasPriv("admin") && !$_SESSION['current']->isMaintainer()) -{ util_show_error_page("Insufficient privileges."); - exit; -} // shows the list of appdata in queue if (!$aClean['iId']) diff --git a/admin/adminAppQueue.php b/admin/adminAppQueue.php index 3641a0e..09ecd0f 100644 --- a/admin/adminAppQueue.php +++ b/admin/adminAppQueue.php @@ -132,10 +132,8 @@ function display_move_test_to_versions_table($aVersionsIds,$icurrentVersionId) //deny access if not logged in or not a super maintainer of any applications if(!$_SESSION['current']->hasPriv("admin") && !$_SESSION['current']->isSuperMaintainer()) -{ util_show_error_page("Insufficient privileges."); - exit; -} + $oTest = new testData($aClean['iTestingId']); if ($aClean['sSub']) @@ -144,10 +142,7 @@ if ($aClean['sSub']) { /* make sure the user is authorized to view this application request */ if(!$_SESSION['current']->hasPriv("admin")) - { util_show_error_page("Insufficient privileges."); - exit; - } $oApp = new Application($aClean['iAppId']); @@ -164,10 +159,8 @@ if ($aClean['sSub']) /* make sure the user has permission to view this version */ $oVersion = new Version($aClean['iVersionId']); if(!$_SESSION['current']->hasAppVersionModifyPermission($oVersion)) - { util_show_error_page("Insufficient privileges."); - exit; - } + } else { //error no Id! diff --git a/admin/adminBugs.php b/admin/adminBugs.php index 78855a4..69590fd 100644 --- a/admin/adminBugs.php +++ b/admin/adminBugs.php @@ -22,10 +22,7 @@ $aClean['iPage'] = makeSafe($_REQUEST['iPage']); // deny access if not logged in if(!$_SESSION['current']->hasPriv("admin")) -{ util_show_error_page("Insufficient privileges."); - exit; -} if ($aClean['sSub']) { @@ -40,7 +37,6 @@ if ($aClean['sSub']) $oBuglink->unqueue(); } redirect($_SERVER['PHP_SELF']."?iItemsPerPage=".$aClean['iItemsPerPage']."&sQueuedOnly=".$aClean['sQueuedOnly']."&ipage=".$aClean['iPage']); - exit; } { diff --git a/admin/adminMaintainerQueue.php b/admin/adminMaintainerQueue.php index ca2088c..569daf3 100644 --- a/admin/adminMaintainerQueue.php +++ b/admin/adminMaintainerQueue.php @@ -20,10 +20,8 @@ $aClean['sReject'] = makeSafe( $_REQUEST['sReject'] ); $aClean['sReplyText'] = makeSafe( $_REQUEST['sReplyText'] ); if(!$_SESSION['current']->hasPriv("admin")) -{ util_show_error_page("Insufficient privileges."); - exit; -} + if ($aClean['sSub']) { diff --git a/admin/adminMaintainers.php b/admin/adminMaintainers.php index 309946a..ff48c99 100644 --- a/admin/adminMaintainers.php +++ b/admin/adminMaintainers.php @@ -16,10 +16,7 @@ $aClean['iMaintainerId'] = makeSafe($_REQUEST['iMaintainerId']); // deny access if not logged in if(!$_SESSION['current']->hasPriv("admin")) -{ util_show_error_page("Insufficient privileges."); - exit; -} apidb_header("Admin Maintainers"); echo '