From 5913b9b43fb131dd072789a30fdbefb6c7a81da6 Mon Sep 17 00:00:00 2001 From: Chris Morgan Date: Sun, 25 Mar 2007 21:04:33 +0000 Subject: [PATCH] Implement Alexander's suggestion and use version::fullName() to reduce code duplication --- include/testData.php | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/include/testData.php b/include/testData.php index 21f4743..febfb03 100644 --- a/include/testData.php +++ b/include/testData.php @@ -244,16 +244,6 @@ class testData{ } } - function getFormattedApplicationVersionName() - { - $oVersion = new Version($this->iVersionId); - $sAppName = application::lookup_name($oVersion->iAppId); - $sVersionName = version::lookup_name($oVersion->iVersionId); - $sName = "$sAppName: $sVersionName"; - - return $sName; - } - function mailSubmitter($sAction="add") { global $aClean; @@ -263,7 +253,7 @@ class testData{ $oSubmitter = new User($this->iSubmitterId); /* Get the full app/version name to display */ - $sName = $this->getFormattedApplicationVersionName(); + $sName = version::fullName($this->iVersionId); switch($sAction) { @@ -493,7 +483,7 @@ class testData{ { HtmlAreaLoaderScript(array("Test1", "Test2", "Test3")); - $sName = $this->getFormattedApplicationVersionName(); + $sName = version::fullName($this->iVersionId); echo html_frame_start("Test Form - $sName", "90%", "", 0); echo "\n";