claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comment::grab_comments() should use $iParentId when != NULL, not just !$iParentId as this prevents the use of

Browse Source 
$iParentId in cases where the value is 0.  Fixes duplicate display of every comment for an application version reported by
Nick Law.
This commit is contained in:
Chris Morgan
2006-07-26 19:30:11 +00:00
committed by WineHQ
parent cef2aec209
commit 61d338abbd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/comment.php
View File

@@ -269,7 +269,9 @@ class Comment {
$iParentId = mysql_real_escape_string($iParentId); $iParentId = mysql_real_escape_string($iParentId);
$sExtra = ""; $sExtra = "";
if($iParentId)
/* NOTE: we must compare against NULL here because $iParentId of 0 is valid */
if($iParentId != NULL)
$sExtra = "AND parentId = '".$iParentId."' "; $sExtra = "AND parentId = '".$iParentId."' ";
$sQuery = "SELECT from_unixtime(unix_timestamp(appComments.time), \"%W %M %D %Y, %k:%i\") as time, ". $sQuery = "SELECT from_unixtime(unix_timestamp(appComments.time), \"%W %M %D %Y, %k:%i\") as time, ".