claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Application::countWithRating() and getWithRating() should avoid queued applications. Add unit test

Browse Source 
to ensure that we don't include queued applications
This commit is contained in:
EA Durbin
2006-09-30 01:31:04 +00:00
committed by WineHQ
parent 74fb6b5bd8
commit 7532d9091e
2 changed files with 48 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/application.php
View File

@@ -371,7 +371,8 @@ class Application {
{
$sQuery = "SELECT DISTINCT count(appId) as total
FROM appVersion
WHERE maintainer_rating = '?'";
WHERE maintainer_rating = '?'
AND queued='false'";
if($hResult = query_parameters($sQuery, $sRating))
{
@@ -386,6 +387,7 @@ class Application {
$sQuery = "SELECT DISTINCT appId
FROM appVersion
WHERE maintainer_rating = '?'
AND queued = 'false'
ORDER BY appId ASC LIMIT ?, ?";
if($hResult = query_parameters($sQuery, $sRating, $iOffset, $iItemsPerPage))

44
unit_test/test_application.php
View File

@@ -153,6 +153,50 @@ function test_application_getWithRating()
delete_app_and_user($oApp, $oUser);
//test to ensure getWithRating doesn't return applications that are queued
if(!$oUser = create_and_login_user()) //create user without admin priveliges
return false;
$oApp = new Application();
$oApp->sName = "Some application";
$oApp->sDescription = "some description";
$oApp->submitterId = $oUser->iUserId;
if(!$oApp->create())
{
$oUser->delete(); /* clean up the user we created prior to exiting */
echo "Failed to create application!\n";
return false;
}
$iAppId = $oApp->iAppId; /* use the iAppId of the application we just created */
$oVersion = new Version();
$oVersion->versionName = "Some Version".$iVersionIdIndex;
$oVersion->description = "Some Version description".$iVersionIdIndex;
$oVersion->iAppId = $oApp->iAppId;
$oVersion->sTestedRating = "Bronze";
$oVersion->sQueued = "True";
if(!$oVersion->create())
{
delete_app_and_user($oApp, $oUser);
echo "Failed to create version!\n";
return false;
}
$aApps=Application::getWithRating($sRating, $iOffset, $iItemsPerPage);
if ( in_array($iAppId, $aApps )) //if the appId is in our test results fail queued test
{
delete_app_and_user($oApp, $oUser);
echo "getWithRating failed to return a unique result set\n";
return false;
}
return true;
}