claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve permission checking in objects, fix some initialization bugs

Browse Source
This commit is contained in:
Chris Morgan
2005-10-26 02:09:49 +00:00
committed by WineHQ
parent 25edd18770
commit 89abe706dc
6 changed files with 383 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
include/version.php
View File

@@ -139,8 +139,10 @@ class Version {
*/
function create()
{
// Security, if we are not an administrator or an appmaintainer the version must be queued.
if(!($_SESSION['current']->hasPriv("admin") || $_SESSION['current']->isSupermaintainer($iAppId)))
if(!$_SESSION['current']->canCreateVersion())
return;
if($_SESSION['current']->versionCreatedMustBeQueued($this))
$this->sQueued = 'true';
else
$this->sQueued = 'false';
@@ -178,6 +180,9 @@ class Version {
{
$sWhatChanged = "";
if(!$_SESSION['current']->hasAppVersionModifyPermission($this))
return;
$oVersion = new Version($this->iVersionId);
if ($this->sName && ($this->sName!=$oVersion->sName))
@@ -247,12 +252,8 @@ class Version {
function delete($bSilent=false)
{
/* is the current user allowed to delete this version? */
if(!$_SESSION['current']->hasPriv("admin") &&
!$_SESSION['current']->hasAppVersionModifyPermission($this->iVersionId) &&
!(($_SESSION['current']->iUserId == $this->iSubmitterId) && ($this->sQueued == 'rejected')))
{
return;
}
if(!$_SESSION['current']->canDeleteVersion($this))
return false;
/* remove all of the items this version contains */
foreach($this->aNotesIds as $iNoteId)
@@ -275,7 +276,7 @@ class Version {
$oUrl = new Url($iUrlId);
$oUrl->delete($bSilent);
}
foreach($this->$aBuglinkIds as $iBug_id)
foreach($this->aBuglinkIds as $iBug_id)
{
$oBug = new bug($iBug_id);
$oBug->delete($bSilent);
@@ -301,6 +302,8 @@ class Version {
$this->SendNotificationMail("delete");
$this->mailSubmitter("delete");
return true;
}
@@ -309,11 +312,8 @@ class Version {
*/
function unQueue()
{
/* is the current user allowed to delete this version? */
if(!$_SESSION['current']->hasPriv("admin") && !$_SESSION['current']->hasAppVersionModifyPermission($this->iVersionId))
{
if(!$_SESSION['current']->canUnQueueVersion($this))
return;
}
// If we are not in the queue, we can't move the version out of the queue.
if(!$this->sQueued == 'true')
@@ -334,11 +334,8 @@ class Version {
function Reject($bSilent=false)
{
/* is the current user allowed to delete this version? */
if(!$_SESSION['current']->hasPriv("admin") && !$_SESSION['current']->hasAppVersionModifyPermission($this->iVersionId))
{
if(!$_SESSION['current']->canRejectVersion($this))
return;
}
// If we are not in the queue, we can't move the version out of the queue.
if(!$this->sQueued == 'true')
@@ -361,13 +358,8 @@ class Version {
function ReQueue()
{
/* is the current user allowed to delete this version? */
if(!$_SESSION['current']->hasPriv("admin") &&
!$_SESSION['current']->hasAppVersionModifyPermission($this->iVersionId) &&
!$_SESSION['current']->iUserId == $this->iSubmitterId)
{
if(!$_SESSION['current']->canRequeueVersion($this))
return;
}
$sUpdate = compile_update_string(array('queued' => "true"));
if(query_appdb("UPDATE appVersion SET ".$sUpdate." WHERE versionId = ".$this->iVersionId))