No need to create Version object, use the monitor classes iAppId and iVersionId instead
This commit is contained in:
@@ -95,16 +95,15 @@ class Monitor {
|
|||||||
{
|
{
|
||||||
/* set $aAppName appropriately */
|
/* set $aAppName appropriately */
|
||||||
if(isset($this->iVersionId))
|
if(isset($this->iVersionId))
|
||||||
$sAppName = Application::lookup_name($oVersion->iAppId)." ".Version::lookup_name($this->iVersionId);
|
$sAppName = Application::lookup_name($this->iAppId)." ".Version::lookup_name($this->iVersionId);
|
||||||
else
|
else
|
||||||
$sAppName = Application::lookup_name($oVersion->iAppId);
|
$sAppName = Application::lookup_name($this->iAppId);
|
||||||
|
|
||||||
switch($sAction)
|
switch($sAction)
|
||||||
{
|
{
|
||||||
case "add":
|
case "add":
|
||||||
if (isset($this->iVersionId))
|
if (isset($this->iVersionId))
|
||||||
{
|
{
|
||||||
$oVersion = new Version($this->iVersionId);
|
|
||||||
$sSubject = "Monitor for ".$sAppName;
|
$sSubject = "Monitor for ".$sAppName;
|
||||||
$sSubject .= " added: ".$_SESSION['current']->sRealname;
|
$sSubject .= " added: ".$_SESSION['current']->sRealname;
|
||||||
$sMsg .= APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n";
|
$sMsg .= APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n";
|
||||||
@@ -119,7 +118,6 @@ class Monitor {
|
|||||||
case "delete":
|
case "delete":
|
||||||
if (isset($this->iVersionId))
|
if (isset($this->iVersionId))
|
||||||
{
|
{
|
||||||
$oVersion = new Version($this->iVersionId);
|
|
||||||
$sSubject = "Monitor for ".$sAppName;
|
$sSubject = "Monitor for ".$sAppName;
|
||||||
$sSubject .= " removed: ".$_SESSION['current']->sRealname;
|
$sSubject .= " removed: ".$_SESSION['current']->sRealname;
|
||||||
$sMsg .= APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n";
|
$sMsg .= APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n";
|
||||||
|
|||||||
Reference in New Issue
Block a user