Don't check is_maintainer() for false if you're already are
is_supermaintainer. is_maintainer will always return true in that case. Makes the super maintainer removal button in version view correct again
This commit is contained in:
@@ -464,7 +464,7 @@ else if($appId && $versionId)
|
|||||||
{
|
{
|
||||||
/* is this user a maintainer of this version by virtue of being a super maintainer */
|
/* is this user a maintainer of this version by virtue of being a super maintainer */
|
||||||
/* of this app family? */
|
/* of this app family? */
|
||||||
if($_SESSION['current']->is_super_maintainer($appId) && !$_SESSION['current']->is_maintainer($appId, $versionId))
|
if($_SESSION['current']->is_super_maintainer($appId))
|
||||||
{
|
{
|
||||||
echo '<form method=post name=message action="maintainerdelete.php"><input type=submit value="Remove yourself as a supermaintainer" class=button>';
|
echo '<form method=post name=message action="maintainerdelete.php"><input type=submit value="Remove yourself as a supermaintainer" class=button>';
|
||||||
echo "<input type=hidden name='superMaintainer' value=1>";
|
echo "<input type=hidden name='superMaintainer' value=1>";
|
||||||
|
|||||||
Reference in New Issue
Block a user