Always read input first in downloadurl::outputEditorSingle(). Makes sure changes aren't lost

when reloading the form due to input errors
This commit is contained in:
Alexander Nicolaysen Sørnes
2007-04-24 23:38:41 +00:00
committed by WineHQ
parent 74425f0b5a
commit 982dc97756
2 changed files with 9 additions and 5 deletions

View File

@@ -224,7 +224,12 @@ class downloadurl
/* Output an editor for a single new URL */ /* Output an editor for a single new URL */
function outputEditorSingle($iVersionId = NULL, $aValues = NULL) function outputEditorSingle($iVersionId = NULL, $aValues = NULL)
{ {
if($iVersionId) if($aValues["sDownloadUrlUrl"] &&
$aValues["sDownloadUrlDescription"])
{
$sDownloadUrlUrl = $aValues["sDownloadUrlUrl"];
$sDownloadUrlDescription = $aValues["sDownloadUrlDescription"];
} else if($iVersionId)
{ {
if($hResult = appData::getData($iVersionId, "downloadurl", if($hResult = appData::getData($iVersionId, "downloadurl",
TRUE, TRUE)) TRUE, TRUE))
@@ -233,12 +238,9 @@ class downloadurl
$sDownloadUrlUrl = $oRow->url; $sDownloadUrlUrl = $oRow->url;
$sDownloadUrlDescription = $oRow->description; $sDownloadUrlDescription = $oRow->description;
} }
} else
{
$sDownloadUrlUrl = $aValues["sDownloadUrlUrl"];
$sDownloadUrlDescription = $aValues["sDownloadUrlDescription"];
} }
$sReturn .= html_frame_start("Download URL","90%"); $sReturn .= html_frame_start("Download URL","90%");
$sReturn .= html_table_begin(""); $sReturn .= html_table_begin("");

View File

@@ -71,6 +71,8 @@ class version_queue
function outputEditor() function outputEditor()
{ {
global $aClean;
/* Display duplicate list if this is a an existing version */ /* Display duplicate list if this is a an existing version */
if($this->oVersion->iVersionId) if($this->oVersion->iVersionId)
$this->displayMoveTestTable(); $this->displayMoveTestTable();