claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up return values of testData::delete(), return false upon failure.

Browse Source
This commit is contained in:
Chris Morgan
2007-07-31 03:07:39 +00:00
committed by WineHQ
parent 0e3472e1bf
commit a7d8eb7e20
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/testData.php
View File

@@ -214,8 +214,9 @@ class testData{
!$_SESSION['current']->hasAppVersionModifyPermission($oVersion) && !$_SESSION['current']->hasAppVersionModifyPermission($oVersion) &&
!(($_SESSION['current']->iUserId == $this->iSubmitterId) && !($this->sQueued == 'false'))) !(($_SESSION['current']->iUserId == $this->iSubmitterId) && !($this->sQueued == 'false')))
{ {
return; return false;
} }
// now delete the test data // now delete the test data
$sQuery = "DELETE FROM testResults $sQuery = "DELETE FROM testResults
WHERE testingId = '?' WHERE testingId = '?'
@@ -223,6 +224,7 @@ class testData{
if(!($hResult = query_parameters($sQuery, $this->iTestingId))) if(!($hResult = query_parameters($sQuery, $this->iTestingId)))
{ {
addmsg("Error removing the deleted test data!", "red"); addmsg("Error removing the deleted test data!", "red");
return false;
} }
if(!$bSilent) if(!$bSilent)
@@ -231,7 +233,7 @@ class testData{
if($this->iSubmitterId && ($this->iSubmitterId != $_SESSION['current']->iUserId)) if($this->iSubmitterId && ($this->iSubmitterId != $_SESSION['current']->iUserId))
$this->mailSubmitter("delete"); $this->mailSubmitter("delete");
return TRUE; return true;
} }