claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove TODO items that have been completed. Add php tag details to

Browse Source 
CODING_STANDARD.
This commit is contained in:
Jonathan Ernst
2004-12-11 19:40:01 +00:00
committed by WineHQ
parent 9cda0192c8
commit ad5de55100
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
CODING_STANDARD
View File

@@ -62,4 +62,11 @@ if(!isset($appId))
} }
} }
- use long php tags (<?php ?>) instead of short ones (<? ?>) as :
1) it could be removed from future versions of php
2) if conflicts with tags like <?xml version=1.0 ?> that are used in xhtml
- do not use vars that require register_globals to be on as:
1) it is off by default in php 4.1+
2) it is more secure
3) it makes it easier to understand where your vars are comming from (forms, session, etc.)

10
TODO
View File

@@ -9,11 +9,7 @@ sat for too long it would be rejected and an email would be send to the
submitter saying it timed out. If the admin/maintainer clicked on accept it submitter saying it timed out. If the admin/maintainer clicked on accept it
would go into the db like every other image. would go into the db like every other image.
# appdb engine - clean up the php backend (???) # appdb engine - clean up the php backend (see CODING_STANDARD for code style guidelines). In particular globally registered vars should be replaced by superglobals and <? ?> should be replaced by <?php ?>.
# app queue - add a form, so the admin can enter a custom response to the submitter (done)
# main App should have a random screenshot from it's versions. (patch sent to wine-patches)
# when we delete a comment there should be a box to explain why you are deleting this comment and an email should be sent to the submitter # when we delete a comment there should be a box to explain why you are deleting this comment and an email should be sent to the submitter
@@ -21,10 +17,6 @@ would go into the db like every other image.
# Add Maintainer rating system to the app verision (tony's working on it). # Add Maintainer rating system to the app verision (tony's working on it).
# stop annoymous comments (patch sent to wine-patches)
# stop annoymous applications submitions (patch sent to wine-patches)
# revamp the star rating system # revamp the star rating system
# once maintainer rating system is in place revamp the front page to use a dynamic list of maintainer rated apps. # once maintainer rating system is in place revamp the front page to use a dynamic list of maintainer rated apps.