comment: Require versionId and message body to be defined
This commit is contained in:
committed by
Chris Morgan
parent
d90ce3d8ef
commit
b48221cdd4
@@ -242,8 +242,8 @@ class Comment {
|
||||
$oM = new objectManager("comment", "Post new ocmment");
|
||||
$oM->setReturnTo($oVersion->objectMakeUrl());
|
||||
// reply post buttons
|
||||
echo " [<a href=\"".$oM->makeUrl("add")."&iAppId=$this->iAppId&iVersionId=$this->iVersionId\"><small>post new</small></a>] \n";
|
||||
echo " [<a href=\"".$oM->makeUrl("add")."&iAppId=$this->iAppId&iVersionId=$this->iVersionId&sSubject=".
|
||||
echo " [<a href=\"".$oM->makeUrl("add")."&iVersionId=$this->iVersionId\"><small>post new</small></a>] \n";
|
||||
echo " [<a href=\"".$oM->makeUrl("add")."&iVersionId=$this->iVersionId&sSubject=".
|
||||
urlencode("$sSubject")."&iThread=$this->iCommentId\"><small>reply to this</small></a>] \n";
|
||||
|
||||
echo "</td></tr>\n";
|
||||
@@ -570,13 +570,26 @@ class Comment {
|
||||
switch($sAction)
|
||||
{
|
||||
case "add":
|
||||
return array("iThread", "iAppId", "iVersionId");
|
||||
return array("iThread", "iVersionId");
|
||||
|
||||
default:
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
function checkOutputEditorInput($aClean)
|
||||
{
|
||||
$sErrors = "";
|
||||
|
||||
if(!$aClean['iVersionId'])
|
||||
$sErrors .= "<li>No version id defined; something may have gone wrong with the URL</li>\n";
|
||||
|
||||
if(!$aClean['sBody'])
|
||||
$sErrors .= "<li>You need to enter a message!</li>\n";
|
||||
|
||||
return $sErrors;
|
||||
}
|
||||
|
||||
function outputEditor($aClean)
|
||||
{
|
||||
$sMesTitle = "<b>Post New Comment</b>";
|
||||
@@ -612,7 +625,6 @@ class Comment {
|
||||
echo html_frame_end();
|
||||
|
||||
echo "<input type=\"hidden\" name=\"iThread\" value=\"".$aClean['iThread']."\" />\n";
|
||||
echo "<input type=\"hidden\" name=\"iAppId\" value=\"".$aClean['iAppId']."\" />\n";
|
||||
echo "<input type=\"hidden\" name=\"iVersionId\" value=\"".$aClean['iVersionId']."\" />\n";
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user