- access most globals by their $_XYZ['varname'] name

- fix some code errors and typos (missing $ in front of variable names
and so on)
- fixed a lot of warnings that would have been thrown when error_reporting
is set to show notices (if(isset($variable))) instead of if($variable) for
example)
This commit is contained in:
Jonathan Ernst
2004-12-10 01:07:45 +00:00
committed by WineHQ
parent 972270f27a
commit bd91db228c
24 changed files with 146 additions and 165 deletions

View File

@@ -9,12 +9,11 @@
*/
function vote_count($appId, $userId = null)
{
global $current;
if(!$userId)
{
if(loggedin())
$userId = $current->userid;
$userId = $_SESSION['current']->userid;
else
return 0;
}
@@ -27,12 +26,10 @@ function vote_count($appId, $userId = null)
*/
function vote_count_user_total($userId = null)
{
global $current;
if(!$userId)
{
if(loggedin())
$userId = $current->userid;
$userId = $_SESSION['current']->userid;
else
return 0;
}
@@ -57,13 +54,12 @@ function vote_count_app_total($appId)
*/
function vote_add($appId, $slot, $userId = null)
{
global $current;
global $MAX_VOTES;
if(!$userId)
{
if(loggedin())
$userId = $current->userid;
$userId = $_SESSION['current']->userid;
else
return;
}
@@ -80,12 +76,12 @@ function vote_add($appId, $slot, $userId = null)
*/
function vote_remove($appId, $slot, $userId = null)
{
global $current;
if(!$userId)
{
if(loggedin())
$userId = $current->userid;
$userId = $_SESSION['current']->userid;
else
return;
}
@@ -94,12 +90,12 @@ function vote_remove($appId, $slot, $userId = null)
function vote_get_user_votes($userId = null)
{
global $current;
if(!$userId)
{
if(loggedin())
$userId = $current->userid;
$userId = $_SESSION['current']->userid;
if(!$userId)
return array();
}
@@ -170,10 +166,10 @@ function dump($arr)
function vote_update($vars)
{
global $current;
//FIXME this doesn't work since msgs only work when logged in
if(!$current)
if(!$_SESSION['current'])
{
addmsg("You must be logged in to vote", "red");
return;