From c7beb30195fc99bdfa8fde2328859dbde875fe97 Mon Sep 17 00:00:00 2001
From: Tony Lambregts <tony_lambregts@telusplanet.net>
Date: Tue, 4 Jan 2005 19:37:49 +0000
Subject: [PATCH] Implement Maintainer ratings.

---
 admin/editAppVersion.php | 43 +++++++++++++++++++++++++++++++++-------
 include/util.php         | 20 ++++++++++++++++++-
 tables/appdb_tables.sql  | 20 ++++++++++---------
 3 files changed, 66 insertions(+), 17 deletions(-)

diff --git a/admin/editAppVersion.php b/admin/editAppVersion.php
index 28824fa..8a3ef98 100644
--- a/admin/editAppVersion.php
+++ b/admin/editAppVersion.php
@@ -29,10 +29,17 @@ if(isset($_REQUEST['submit1']))
         $old_keywords    = $ob->keywords;
         $old_description = $ob->description;
         $old_webPage     = $ob->webPage;
+        $old_rating      = $ob->maintainer_rating;
+        $old_release     = $ob->maintainer_release;
 
-        $versionName   = addslashes($_REQUEST['versionName']);
-        $description   = addslashes($_REQUEST['description']);
-        $webPage       = addslashes($_REQUEST['webPage']);
+        $versionName        = addslashes($_REQUEST['versionName']);
+        $keywords           = $_REQUEST['keywords'];
+        $description        = addslashes($_REQUEST['description']);
+        $webPage            = addslashes($_REQUEST['webPage']);
+        $maintainer_rating  = $_REQUEST['maintainer_rating'];
+        $maintainer_release = $_REQUEST['maintainer_release'];
+
+        
         $VersionChanged = false;
         if ($old_versionName <> $versionName)
         {
@@ -40,7 +47,7 @@ if(isset($_REQUEST['submit1']))
             $WhatChanged .= "              New Value: ".stripslashes($versionName)."\n";
             $VersionChanged = true;
         } 
-        if ($old_keywords <> $_REQUEST['keywords'])
+        if ($old_keywords <> $keywords)
         {
              $WhatChanged .= "   Key Words: Old Value: ".stripslashes($old_keywords)."\n";
              $WhatChanged .= "              New Value: ".stripslashes($keywords)."\n";
@@ -64,13 +71,29 @@ if(isset($_REQUEST['submit1']))
              $WhatChanged .= "-----------------------:\n";
              $VersionChanged = true;
         } 
+        if ($old_rating <> $maintainer_rating)
+        {
+            $WhatChanged .= "     Release: Old Value: ".stripslashes($old_rating)."\n";
+            $WhatChanged .= "              New Value: ".stripslashes($maintainer_rating)."\n";
+            $VersionChanged = true;
+        } 
+
+        if ($old_release <> $maintainer_release)
+        {
+            $WhatChanged .= "     Release: Old Value: ".stripslashes($old_release)."\n";
+            $WhatChanged .= "              New Value: ".stripslashes($maintainer_release)."\n";
+            $VersionChanged = true;
+        } 
+
         //did anything change?
         if ($VersionChanged)
         {
             $query = "UPDATE appVersion SET versionName = '".$versionName."', ".
                 "keywords = '".$_REQUEST['keywords']."', ".
                 "description = '".$description."', ".
-                "webPage = '".$webPage."'".
+                "webPage = '".$webPage."',".
+                "maintainer_rating = '".$maintainer_rating."',".
+                "maintainer_release = '".$maintainer_release."'".
                 " WHERE appId = ".$_REQUEST['appId']." and versionId = ".$_REQUEST['versionId'];
             if (mysql_query($query))
             {  
@@ -116,12 +139,12 @@ if(isset($_REQUEST['submit1']))
 } else
 {
     $query = "SELECT versionName,  keywords, ".
-        "description, webPage from appVersion WHERE ".
+        "description, webPage, maintainer_rating, maintainer_release from appVersion WHERE ".
         "appId = '".$_REQUEST['appId']."' and versionId = '".$_REQUEST['versionId']."'";
     if(debugging()) { echo "<p align=center><b>query:</b> $query </p>"; }
 
     $result = mysql_query($query);
-    list($versionName, $keywords, $description, $webPage) = mysql_fetch_row($result);
+    list($versionName, $keywords, $description, $webPage, $maintainer_rating, $maintainer_release) = mysql_fetch_row($result);
 
     apidb_header("Edit Application Version");
 
@@ -138,6 +161,12 @@ if(isset($_REQUEST['submit1']))
     echo '<tr><td class=color4>Description</td><td class=color0>', "\n";
     echo '<textarea cols=$80 rows=$30 name="description">'.stripslashes($description).'</textarea></td></tr>',"\n";
     echo '<tr><td class=color1>Web Page</td><td class=color0><input size=80% type="text" name="webPage" value="'.$webPage.'" /></td></tr>',"\n";
+    echo '<tr><td class=color4>Rating</td><td class=color0>',"\n";
+    make_maintainer_rating_list("maintainer_rating", $maintainer_rating);
+    echo '</td></tr>',"\n";
+    echo '<tr><td class=color1>Release</td><td class=color0>',"\n";
+    make_bugzilla_version_list("maintainer_release", $maintainer_release);
+    echo '</td></tr>',"\n";
 
     echo '<tr><td colspan=2 align=center class=color3><input type="submit" name=submit1 value="Update Database" /></td></tr>',"\n";
 
diff --git a/include/util.php b/include/util.php
index 883c5e6..79a4d05 100644
--- a/include/util.php
+++ b/include/util.php
@@ -220,7 +220,7 @@ function make_bugzilla_version_list($varname, $cvalue)
     echo "<option value=0>Choose ...</option>\n";
     while(list($value) = mysql_fetch_row($result))
     {
-        if($id == $cvalue)
+        if($value == $cvalue)
             echo "<option value=$value selected>$value\n";
         else
             echo "<option value=$value>$value\n";
@@ -229,6 +229,24 @@ function make_bugzilla_version_list($varname, $cvalue)
     closebugzilladb();
 }
 
+function make_maintainer_rating_list($varname, $cvalue)
+{
+    
+    echo "<select name='$varname'>\n";
+    echo "<option value=0>Choose ...</option>\n";
+    $aRating = array("Gold", "Silver", "Bronze", "Garbage");
+    $iMax = count($aRating);
+
+    for($i=0; $i < $iMax; $i++)
+    {
+        if($aRating[$i] == $cvalue)
+            echo "<option value=$aRating[$i] selected>$aRating[$i]\n";
+        else
+            echo "<option value=$aRating[$i]>$aRating[$i]\n";
+    }
+    echo "</select>\n";
+}
+
 /* get the number of applications in the appQueue table */
 function getQueuedAppCount()
 {
diff --git a/tables/appdb_tables.sql b/tables/appdb_tables.sql
index 22005f9..d06dc41 100644
--- a/tables/appdb_tables.sql
+++ b/tables/appdb_tables.sql
@@ -52,14 +52,16 @@ create table appFamily (
  * a version of an application
  */
 create table appVersion (
-       versionId	int not null auto_increment,
-       appId		int not null,
-       versionName	varchar(100) not null,
-       keywords		text,
-       description	text,
-       webPage		varchar(100),
-       rating_windows   float default 0.0,
-       rating_fake      float default 0.0,
+       versionId          int not null auto_increment,
+       appId              int not null,
+       versionName        varchar(100) not null,
+       keywords           text,
+       description        text,
+       webPage            varchar(100),
+       rating_windows     float default 0.0,
+       rating_fake        float default 0.0,
+       maintainer_rating  text,
+       maintainer_release text,
        key(versionId)
 );
 
@@ -181,7 +183,7 @@ create table appData (
 	id		int not null auto_increment,
 	appId		int not null,
 	versionId	int default 0,
-	type		enum('image', 'url'),
+	type		enum('image', 'url', 'bug'),
 	description	text,
 	url		varchar(255),
 	key(id),