claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hack a fix for "$this->iLinkId = mysql_insert_id();" not working

Browse Source 
and other cleanups.
This commit is contained in:
Tony Lambregts
2005-07-16 20:02:17 +00:00
committed by WineHQ
parent 1331d33842
commit d71c45937e
1 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
include/bugs.php
View File

@@ -87,7 +87,7 @@ class Bug {
$sQuery = "SELECT * $sQuery = "SELECT *
FROM bugs FROM bugs
WHERE bug_id = ".$iBug_id; WHERE bug_id = ".$iBug_id;
if(!($hResult = query_bugzilladb($sQuery))) if(mysql_num_rows(query_bugzilladb($sQuery, "checking bugzilla")) == 0)
{ {
addmsg("There is no bug in Bugzilla with that bug number.", "red"); addmsg("There is no bug in Bugzilla with that bug number.", "red");
return false; return false;
@@ -98,7 +98,7 @@ class Bug {
$sQuery = "SELECT * $sQuery = "SELECT *
FROM buglinks FROM buglinks
WHERE versionId = ".$iVersionId; WHERE versionId = ".$iVersionId;
if($hResult = query_appdb($sQuery)) if($hResult = query_appdb($sQuery,"looking for duplicates"))
{ {
while($oRow = mysql_fetch_object($hResult)) while($oRow = mysql_fetch_object($hResult))
{ {
@@ -108,7 +108,7 @@ class Bug {
return false; return false;
} }
} }
} }
/* passed the checks so lets insert the puppy! */ /* passed the checks so lets insert the puppy! */
@@ -120,8 +120,22 @@ class Bug {
$sValues = "({$aInsert['VALUES']})"; $sValues = "({$aInsert['VALUES']})";
if(query_appdb("INSERT INTO buglinks $sFields VALUES $sValues", "Error while creating a new Bug link.")) if(query_appdb("INSERT INTO buglinks $sFields VALUES $sValues", "Error while creating a new Bug link."))
{ {
/* The following should work but it does not! */
$this->iLinkId = mysql_insert_id(); $this->iLinkId = mysql_insert_id();
$this->bug($this->iLinkId); $this->bug($this->iLinkId);
/* Start of hack to get around the previous not working */
$sQuery = "SELECT buglinks.*, appVersion.appId AS appId
FROM buglinks, appVersion
WHERE buglinks.versionId = appVersion.versionId
AND buglinks.versionId = ".$iVersionId."
AND buglinks.bug_id = ".$iBug_id;
if($hResult = query_appdb($sQuery))
{
$oRow = mysql_fetch_object($hResult);
$this->bug($oRow->linkId);
}
/*End of Hack */
$this->mailMaintainers(); $this->mailMaintainers();
return true; return true;
}else }else
@@ -182,11 +196,11 @@ class Bug {
if(!$bRejected) if(!$bRejected)
{ {
$sSubject = "Submitted Bug Link accepted"; $sSubject = "Submitted Bug Link accepted";
$sMsg = "The Bug Link you submitted for ".lookup_app_name($this->appId)." ".lookup_version_name($this->versionId)." has been accepted."; $sMsg = "The Bug Link you submitted for ".lookup_app_name($this->iAppId)." ".lookup_version_name($this->iVersionId)." has been accepted.";
} else } else
{ {
$sSubject = "Submitted Bug Link rejected"; $sSubject = "Submitted Bug Link rejected";
$sMsg = "The Bug Link you submitted for ".lookup_app_name($this->appId)." ".lookup_version_name($this->versionId)." has been rejected."; $sMsg = "The Bug Link you submitted for ".lookup_app_name($this->iAppId)." ".lookup_version_name($this->iVersionId)." has been rejected.";
} }
$sMsg .= $_REQUEST['replyText']."\n"; $sMsg .= $_REQUEST['replyText']."\n";
$sMsg .= "We appreciate your help in making the Application Database better for all users."; $sMsg .= "We appreciate your help in making the Application Database better for all users.";
@@ -217,7 +231,7 @@ class Bug {
$sMsg = APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n"; $sMsg = APPDB_ROOT."appview.php?versionId=".$this->iVersionId."\n";
$sMsg .= "This Bug Link has been queued."; $sMsg .= "This Bug Link has been queued.";
$sMsg .= "\n"; $sMsg .= "\n";
addmsg("The Bug Link you submitted will be added to the database database after being reviewed.", "green"); addmsg("The Bug Link you submitted will be added to the database after being reviewed.", "green");
} }
} else // Bug Link deleted. } else // Bug Link deleted.
{ {
@@ -243,6 +257,7 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds)
{ {
$bCanEdit = FALSE; $bCanEdit = FALSE;
$oVersion = new Version($iVersionId); $oVersion = new Version($iVersionId);
// Security, if we are an administrator or a maintainer, we can remove or ok links. // Security, if we are an administrator or a maintainer, we can remove or ok links.
if(($_SESSION['current']->hasPriv("admin") || if(($_SESSION['current']->hasPriv("admin") ||
$_SESSION['current']->isMaintainer($oVersion->iVersionId) || $_SESSION['current']->isMaintainer($oVersion->iVersionId) ||
@@ -286,7 +301,6 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds)
echo "<td>".$oBuglink->sShort_desc."</td>\n"; echo "<td>".$oBuglink->sShort_desc."</td>\n";
echo "<td align=center>".$oBuglink->sBug_status."</td>","\n"; echo "<td align=center>".$oBuglink->sBug_status."</td>","\n";
echo "<td align=center>".$oBuglink->sResolution."</td>","\n"; echo "<td align=center>".$oBuglink->sResolution."</td>","\n";
// echo "<td align=center>".$oBuglink->sResolution."</td>","\n";
echo "<td align=center><a href='viewbugs.php?bug_id=".$oBuglink->iBug_id."'>View</a></td>\n"; echo "<td align=center><a href='viewbugs.php?bug_id=".$oBuglink->iBug_id."'>View</a></td>\n";
@@ -309,7 +323,7 @@ function view_version_bugs($iVersionId = null, $aBuglinkIds)
} }
if($_SESSION['current']->isLoggedIn()) if($_SESSION['current']->isLoggedIn())
{ {
echo '<input type="hidden" name="versionId" value="'.$oBuglink->iVersionId.'">',"\n"; echo '<input type="hidden" name="versionId" value="'.$iVersionId.'">',"\n";
echo '<tr class=color3><td align=center>',"\n"; echo '<tr class=color3><td align=center>',"\n";
echo '<input type="text" name="buglinkId" value="'.$_REQUEST['buglinkId'].'" size="8"></td>',"\n"; echo '<input type="text" name="buglinkId" value="'.$_REQUEST['buglinkId'].'" size="8"></td>',"\n";
echo '<td><input type="submit" name="sub" value="Submit a new bug link."></td>',"\n"; echo '<td><input type="submit" name="sub" value="Submit a new bug link."></td>',"\n";