diff --git a/include/application.php b/include/application.php index b259934..3292ed6 100644 --- a/include/application.php +++ b/include/application.php @@ -751,7 +751,7 @@ class Application { echo '
'; } else /* nope */ { - echo ' '; + echo ' sName).'&sReturnTo='.urlencode($this->objectMakeUrl()).'">'; } echo " iAppId."\">"; diff --git a/include/maintainer.php b/include/maintainer.php index badf981..4c63ef1 100644 --- a/include/maintainer.php +++ b/include/maintainer.php @@ -677,7 +677,7 @@ class maintainer return $oOMTableRow; } - function objectDisplayAddItemHelp() + function objectDisplayAddItemHelp($aClean) { echo "

This page is for submitting a request to become an application maintainer.\n"; echo "An application maintainer is someone who runs the application \n"; @@ -691,6 +691,14 @@ class maintainer echo "appdb admins to identify people that are best suited for the job. Your request\n"; echo "may be denied if there are already a handful of maintainers for this application or if you\n"; echo "don't have the experience with Wine that is necessary to help other users out.

\n"; + + if(!$aClean['iVersionId']) + { + echo "

Super maintainers are just like normal maintainers but they can modify EVERY version of\n"; + echo "this application (and the application itself). We don't expect you to run every version but at least to help keep\n"; + echo "the forums clean of stale and out-of-date information.

\n"; + + } } function ObjectDisplayQueueProcessingHelp() @@ -716,6 +724,9 @@ class maintainer case "add": return array("iAppId","iVersionId"); + case "addHelp": + return array("iVersionId"); + default: return null; } @@ -749,10 +760,10 @@ class maintainer $iSuperMaintainer = $aClean['iVersionId'] ? 0 : 1; echo ""; - echo ""; + echo ""; echo ""; - if($aClean['iSuperMaintainer']) + if($iSuperMaintainer) echo 'Why you want to and should
be an application super maintainer
',"\n"; else echo 'Why you want to and should
be an application maintainer
',"\n"; @@ -877,6 +888,7 @@ class maintainer $this->iVersionId = $aClean['iVersionId']; $this->sReplyText = $aClean['sReplyText']; $this->sMaintainReason = $aClean['sMaintainReason']; + $this->bSuperMaintainer = $this->iVersionId ? 0 : 1; return TRUE; } diff --git a/include/objectManager.php b/include/objectManager.php index 686e6eb..0cd500c 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -652,7 +652,14 @@ class ObjectManager /* Display help if it is exists */ if(method_exists(new $this->sClass, "objectDisplayAddItemHelp")) - $oObject->objectDisplayAddItemHelp(); + { + $aVars = $this->get_custom_vars($aClean, "addHelp"); + + if($aVars) + $oObject->objectDisplayAddItemHelp($aClean); + else + $oObject->objectDisplayAddItemHelp(); + } echo "\n"; diff --git a/maintainersubmit.php b/maintainersubmit.php deleted file mode 100644 index 559a292..0000000 --- a/maintainersubmit.php +++ /dev/null @@ -1,173 +0,0 @@ -) - */ -function checkAppMaintainerInput( $maintainReason ) -{ - $errors = ""; - - if ( empty( $maintainReason ) ) - { - $errors .= "
  • Please enter why you would like to be an application maintainer.
  • \n"; - } - - if ( empty($errors) ) - { - return ""; - } - else - { - return $errors; - } -} - - -if(!$_SESSION['current']->isLoggedIn()) - util_show_error_page_and_exit("You need to be logged in to apply to be a maintainer."); - -/* if we have a versionId to check against see if */ -/* the user is already a maintainer */ -if(!$aClean['iSuperMaintainer'] && $_SESSION['current']->isMaintainer($aClean['iVersionId'])) -{ - echo "You are already a maintainer of this app!"; - exit; -} - -/* if this user is a super maintainer they maintain all of the versionIds of this appId */ -if($_SESSION['current']->isSuperMaintainer($aClean['iAppId'])) -{ - echo "You are already a supermaintainer of the whole application family!"; - exit; -} - -if( $aClean['sMaintainReason'] ) -{ - // check the input for empty/invalid fields - $errors = checkAppMaintainerInput($aClean['sMaintainReason']); - if(!empty($errors)) - util_show_error_page_and_exit("We found the following errors:","
    Please go back and correct them."); - - // header - if($aClean['iSuperMaintainer']) - apidb_header("Submit SuperMaintainer Request"); - else - apidb_header("Submit Maintainer Request"); - - // add to queue - $oMaintainer = new Maintainer(); - $oMaintainer->iAppId = $aClean['iAppId']; - $oMaintainer->iVersionId = $aClean['iVersionId']; - $oMaintainer->iUserId = $_SESSION['current']->iUserId; - $oMaintainer->sMaintainReason = $aClean['sMaintainReason']; - $oMaintainer->bSuperMaintainer = $aClean['iSuperMaintainer']; - - $hResult = $oMaintainer->create(); - - if ($hResult) - { - echo "

    Your maintainer request has been submitted for review. You should hear back\n"; - echo "soon about the status of your submission

    \n"; - } else - { - addmsg("Error submitting maintainer request. Please contact the appdb admins at appdb@winehq.org", "red"); - } -} else -{ - // header - if($aClean['iVersionId']) - { - $oVersion = new Version($aClean['iVersionId']); - $oApp = new Application($oVersion->iAppId); - apidb_header("Request to become an application maintainer of ".$oApp->sName." ".$oVersion->sName); - } - else - { - $oApp = new Application($aClean['iAppId']); - apidb_header("Request to become an application super maintainer of ".$oApp->sName); - } - - // show add to queue form - - echo '',"\n"; - - echo "

    This page is for submitting a request to become an application maintainer.\n"; - echo "An application maintainer is someone who runs the application \n"; - echo "regularly and who is willing to be active in reporting regressions with newer \n"; - echo "versions of Wine and to help other users run this application under Wine.

    "; - echo "

    Being an application maintainer comes with new rights and new responsibilities; please be sure to read the maintainer's guidelines before to proceed.

    "; - echo "

    We ask that all maintainers explain why they want to be an application maintainer,\n"; - echo "why they think they will do a good job and a little about their experience\n"; - echo "with Wine. This is both to give you time to\n"; - echo "think about whether you really want to be an application maintainer and also for the\n"; - echo "appdb admins to identify people that are best suited for the job. Your request\n"; - echo "may be denied if there are already a handful of maintainers for this application or if you\n"; - echo "don't have the experience with Wine that is necessary to help other users out.

    \n"; - - /* Special message for super maintainer applications */ - if($aClean['iSuperMaintainer']) - { - echo "

    Super maintainers are just like normal maintainers but they can modify EVERY version of\n"; - echo "this application (and the application itself). We don't expect you to run every version but at least to help keep\n"; - echo "the forums clean of stale and out-of-date information.

    \n"; - } - echo "

    "; - - if($aClean['iSuperMaintainer']) - echo html_frame_start("New Super Maintainer Form",400,"",0); - else - echo html_frame_start("New Maintainer Form",400,"",0); - - echo "\n"; - echo "',"\n"; - if($aClean['iVersionId']) - { - echo "',"\n"; - } - echo ""; - echo ""; - echo ""; - - if($aClean['iSuperMaintainer']) - echo '',"\n"; - else - echo '',"\n"; - - echo '',"\n"; - echo '
    "; - echo 'Application'.$oApp->sName; - echo '
    "; - echo 'Version'.$oVersion->sName; - echo '
    Why you want to and should be an application super maintainer
    Why you want to and should be an application maintainer
    ',"\n"; - - echo html_frame_end(); - - echo "
    "; -} - -apidb_footer(); - -?>