Fix test result issue with incorrect name causing an error when 'Limit to 5 tests' was

selected
This commit is contained in:
Chris Morgan
2007-04-22 04:23:57 +00:00
committed by WineHQ
parent 2a7d8e8c3f
commit e83b9b2d58

View File

@@ -380,7 +380,7 @@ class testData{
$link = mysql_real_escape_string($link); $link = mysql_real_escape_string($link);
$iDisplayLimit = mysql_real_escape_string($iDisplayLimit); $iDisplayLimit = mysql_real_escape_string($iDisplayLimit);
$showAll = $aClean['showAll']; $sShowAll = $aClean['sShowAll'];
$sQuery = "SELECT * $sQuery = "SELECT *
FROM testResults FROM testResults
@@ -389,7 +389,7 @@ class testData{
queued = '?' queued = '?'
ORDER BY testedDate DESC"; ORDER BY testedDate DESC";
if(!$showAll) if(!$sShowAll)
$sQuery.=" LIMIT 0,".$iDisplayLimit; $sQuery.=" LIMIT 0,".$iDisplayLimit;
$hResult = query_parameters($sQuery, $this->iVersionId, "false"); $hResult = query_parameters($sQuery, $this->iVersionId, "false");
@@ -433,8 +433,8 @@ class testData{
html_tr_highlight_clickable($link.$oTest->iTestingId, $bgcolor, "", "color2", "underline"); html_tr_highlight_clickable($link.$oTest->iTestingId, $bgcolor, "", "color2", "underline");
echo ' <td align="center" class="color2">[<a href="'.$link.$oTest->iTestingId; echo ' <td align="center" class="color2">[<a href="'.$link.$oTest->iTestingId;
if(is_string($showAll)) if(is_string($sShowAll))
echo '&showAll='.$showAll.'">Show</a>]</td>',"\n"; echo '&sShowAll='.$sShowAll.'">Show</a>]</td>',"\n";
else else
echo '">Show</a>]</td>',"\n"; echo '">Show</a>]</td>',"\n";
} }
@@ -462,12 +462,12 @@ class testData{
echo '<form method=get action="'.$PHP_SELF.'">'; echo '<form method=get action="'.$PHP_SELF.'">';
echo '<input name="iVersionId" type=hidden value="',$this->iVersionId,'" />'; echo '<input name="iVersionId" type=hidden value="',$this->iVersionId,'" />';
if($rowsUsed >= $iDisplayLimit && !is_string($showAll)) if($rowsUsed >= $iDisplayLimit && !is_string($sShowAll))
echo '<input class="button" name="showAll" type=submit value="Show All Tests" />'; echo '<input class="button" name="sShowAll" type=submit value="Show All Tests" />';
if(is_string($showAll)) if(is_string($sShowAll))
{ {
echo '<input class="button" name="hideAll" type=submit value="Limit to '.$iDisplayLimit.' Tests" />'; echo '<input class="button" name="sHideAll" type=submit value="Limit to '.$iDisplayLimit.' Tests" />';
} }
echo '</form>'; echo '</form>';
} }