From ee70aeaaa2673bbfb9aae85cde10f53a1ca4818b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20Nicolaysen=20S=C3=B8rnes?=
 <alex@thehandofagony.com>
Date: Sat, 8 Sep 2007 01:48:53 +0000
Subject: [PATCH] make_maintainer_rating_list() should return a string
 containing the html for the list. Update users of
 make_maintainer_rating_list() to echo its return value.

---
 include/testData.php |  2 +-
 include/util.php     | 14 ++++++++------
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/include/testData.php b/include/testData.php
index f629d24..479e96b 100644
--- a/include/testData.php
+++ b/include/testData.php
@@ -677,7 +677,7 @@ class testData{
         echo '</td></tr>',"\n";
         // Rating
         echo '<tr><td class="color0"><b>Rating</b></td><td class="color0">',"\n";
-        make_maintainer_rating_list("sTestedRating", $this->sTestedRating);
+        echo make_maintainer_rating_list("sTestedRating", $this->sTestedRating);
         echo '<a href="'.BASE.'/help/?sTopic=maintainer_ratings" target="_blank">Rating definitions</a></td></tr>',"\n";
         // extra comments
         echo '<tr valign=top><td class="color1"><b>Extra comments</b></td>',"\n";
diff --git a/include/util.php b/include/util.php
index 9ac0b32..bc4603f 100644
--- a/include/util.php
+++ b/include/util.php
@@ -200,22 +200,24 @@ function make_bugzilla_version_list($sVarname, $sSelectedValue)
     return $sStr;
 }
 
+// returns a string containing the html for the maintainer rating list
 function make_maintainer_rating_list($varname, $cvalue)
 {
-    
-    echo "<select name='$varname'>\n";
-    echo "<option value=\"\">Choose ...</option>\n";
+    $sTxt =  "<select name='$varname'>\n";
+    $sTxt .= "<option value=\"\">Choose ...</option>\n";
     $aRating = array("Platinum", "Gold", "Silver", "Bronze", "Garbage");
     $iMax = count($aRating);
 
     for($i=0; $i < $iMax; $i++)
     {
         if($aRating[$i] == $cvalue)
-            echo "<option class=$aRating[$i] value=$aRating[$i] selected>$aRating[$i]\n";
+            $sTxt .= "<option class=$aRating[$i] value=$aRating[$i] selected>$aRating[$i]\n";
         else
-            echo "<option class=$aRating[$i] value=$aRating[$i]>$aRating[$i]\n";
+            $sTxt .= "<option class=$aRating[$i] value=$aRating[$i]>$aRating[$i]\n";
     }
-    echo "</select>\n";
+    $sTxt .= "</select>\n";
+
+    return $sTxt;
 }
 
 /* Get the number of users in the database */