Filter all user input to reduce the security impact of manipulated data
This commit is contained in:
@@ -11,27 +11,30 @@ require(BASE."include/incl.php");
|
||||
require(BASE."include/category.php");
|
||||
require(BASE."include/application.php");
|
||||
|
||||
$aClean = array(); //array of filtered user input
|
||||
|
||||
$aClean['appId'] = makeSafe($_POST['appId']);
|
||||
$aClean['versionId'] = makeSafe($_POST['versionId']);
|
||||
$aClean['confirmed'] = makeSafe($_POST['confirmed']);
|
||||
$aClean['superMaintainer'] = makeSafe($_POST['superMaintainer']);
|
||||
|
||||
if(!$_SESSION['current']->isLoggedIn())
|
||||
{
|
||||
errorpage("You need to be logged in to resign from being a maintainer.");
|
||||
exit;
|
||||
}
|
||||
|
||||
$appId = strip_tags($_POST['appId']);
|
||||
$versionId = strip_tags($_POST['versionId']);
|
||||
$confirmed = strip_tags($_POST['confirmed']);
|
||||
$superMaintainer = strip_tags($_POST['superMaintainer']);
|
||||
|
||||
if($confirmed)
|
||||
if($aClean['confirmed'])
|
||||
{
|
||||
$oApp = new Application($appId);
|
||||
if($superMaintainer)
|
||||
$oApp = new Application($aClean['appId']);
|
||||
if($aClean['superMaintainer'])
|
||||
{
|
||||
apidb_header("You have resigned as super maintainer of ".$oApp->sName);
|
||||
$result = $_SESSION['current']->deleteMaintainer($oApp->iAppId, null);
|
||||
} else
|
||||
{
|
||||
$oVersion = new Version($versionId);
|
||||
$oVersion = new Version($aClean['versionId']);
|
||||
apidb_header("You have resigned as maintainer of ".$oApp->sName." ".$oVersion->sName);
|
||||
$result = $_SESSION['current']->deleteMaintainer($oApp->iAppId, $oVersion->iVersionId);
|
||||
}
|
||||
@@ -39,14 +42,14 @@ if($confirmed)
|
||||
*/
|
||||
if($result)
|
||||
{
|
||||
if($superMaintainer)
|
||||
if($aClean['superMaintainer'])
|
||||
echo "You were removed as a super maintainer of ".$oApp->sName;
|
||||
else
|
||||
echo "You were removed as a maintainer of ".$oApp->sName." ".$oVersion->sName;
|
||||
}
|
||||
} else
|
||||
{
|
||||
if($superMaintainer)
|
||||
if($aClean['superMaintainer'])
|
||||
apidb_header("Confirm super maintainer resignation of ".$oApp->sName);
|
||||
else
|
||||
apidb_header("Confirm maintainer resignation of ".$oApp->sName." ".$oVersion->sName);
|
||||
@@ -56,12 +59,12 @@ if($confirmed)
|
||||
|
||||
echo html_frame_start("Confirm",400,"",0);
|
||||
echo "<table width='100%' border=0 cellpadding=2 cellspacing=0>\n";
|
||||
echo "<input type=hidden name='appId' value=$appId>";
|
||||
echo "<input type=hidden name='versionId' value=$versionId>";
|
||||
echo "<input type=hidden name='superMaintainer' value=$superMaintainer>";
|
||||
echo "<input type=hidden name='appId' value={$aClean['appId']}>";
|
||||
echo "<input type=hidden name='versionId' value={$aClean['versionId']}>";
|
||||
echo "<input type=hidden name='superMaintainer' value={$aClean['superMaintainer']}>";
|
||||
echo "<input type=hidden name='confirmed' value=1>";
|
||||
|
||||
if($superMaintainer)
|
||||
if($aClean['superMaintainer'])
|
||||
{
|
||||
echo "<tr><td>Are you sure that you want to be removed as a super maintainer of this application?</tr></td>\n";
|
||||
echo '<tr><td align=center><input type=submit value=" Confirm resignation as supermaintainer " class=button>', "\n";
|
||||
|
||||
Reference in New Issue
Block a user