claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop using compile_update_string(). compile_update_string() can be passed a value that includes a character considered

Browse Source 
special by query_parameters().  We then use the output from compile_update_string() as a part of the first
parameter to query_parameters(), the format string.  Having extra special characters causes a token mismatch
and query_parameters() will reject the queries entirely.  Remove now unused compile_update_string().
This commit is contained in:
Chris Morgan
2006-07-04 03:43:06 +00:00
committed by WineHQ
parent 611cc12aeb
commit fad9278013
5 changed files with 46 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
include/testResults.php
View File

@@ -106,19 +106,30 @@ class testData{
return;
}
$sUpdate = compile_update_string(array( 'versionId' => $this->iVersionId,
'whatWorks' => $this->sWhatWorks,
'whatDoesnt' => $this->sWhatDoesnt,
'whatNotTested' => $this->sWhatNotTested,
'testedDate' => $this->sTestedDate,
'distributionId' => $this->iDistributionId,
'testedRelease' => $this->sTestedRelease,
'installs' => $this->sInstalls,
'runs' => $this->sRuns,
'testedRating' => $this->sTestedRating,
'comments' => $this->sComments));
if(query_parameters("UPDATE testResults SET ".$sUpdate." WHERE testingId = '?'",
if(query_parameters("UPDATE testResults SET
versionId = '?',
whatWorks = '?',
whatDoesnt = '?',
whatNotTested = '?',
testedDate = '?',
distributionId = '?',
testedRelease = '?',
installs = '?',
runs = '?',
testedRating = '?',
comments = '?'
WHERE testingId = '?'",
$this->iVersionId,
$this->sWhatWorks,
$this->sWhatDoesnt,
$this->sWhatNotTested,
$this->sTestedDate,
$this->iDistributionId,
$this->sTestedRelease,
$this->sInstalls,
$this->sRuns,
$this->sTestedRating,
$this->sComments,
$this->iTestingId))
{
if(!$bSilent)