Commit Graph

985 Commits

Author SHA1 Message Date
Chris Morgan
9364f5bc5a Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
of the distribution class
2006-07-21 04:21:04 +00:00
Chris Morgan
1bdc44a003 Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
3f1bfd3685 Attempt to capture the source of erroneous input to grab_comments() using error_log::logBackTrace() 2006-07-20 03:52:02 +00:00
Chris Morgan
34594b6eb4 Add logBackTrace() call to error_log class so we can determine code flow during error logging 2006-07-20 03:50:47 +00:00
Chris Morgan
f7763bdbfa Clean up variable naming in grab_comments() , use null instead of -1 for parent ID 2006-07-20 03:19:23 +00:00
Chris Morgan
311081fda5 Handle mysql transaction deadlocks more gracefully by making multiple attempts when they occur 2006-07-19 19:20:16 +00:00
Chris Morgan
55065a254c Add mysql_errno() output to error logging 2006-07-19 17:34:59 +00:00
Chris Morgan
3697e8b9c4 Swap error logging and addmsg() calls as addmsg() performs a database transaction and will clear out any error that
we wanted to report when error logging and calling mysql_error()
2006-07-19 17:18:16 +00:00
Chris Morgan
a651a3cdf3 Modify query_error() to log errors to a database table instead of displaying them on the screen. This should
let us more easily debug difficult or intermittent issues that users may not report. Add a cron to report logged
errors to appdb admins every night.  Implement some basic unit tests for the new error logging code
2006-07-19 16:37:54 +00:00
Chris Morgan
2976ff9833 Fix centering of screenshot images on application/version pages 2006-07-19 00:54:56 +00:00
Chris Morgan
2ef31edf05 Fix voting(again) by changing all variables to use the new naming scheme 2006-07-19 00:11:40 +00:00
Chris Morgan
71f963b04c Remove some unused functions from html.php 2006-07-19 00:11:11 +00:00
Jonathan Ernst
3a61131ffd Trim 's' and 'sh' variables in filter.php so we correctly convert variable values with spaces into "" strings 2006-07-18 02:42:57 +00:00
Chris Morgan
0019810922 Rename include/db.php to include/query.php, all of the functions in db.php were named query_*(). Rename test_db.php to
test_query.php to match the rename of include/db.php.  Modify include/incl.php to include query.php instead of db.php
2006-07-17 20:56:07 +00:00
Chris Morgan
8bdf80982f Fix table name case difference 'Appversion' -> 'appVersion' that was breaking a query 2006-07-16 17:37:23 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Tony Lambregts
ed2cbe739d Stop allowing anonymous test results 2006-07-16 05:39:56 +00:00
Chris Morgan
ed0c692744 Exclude GPC values that start with 'Dialog', these are used by Xinha and we don't want to modify that code. Also exclude
PHPSESSID, this is a convenience for developers as php uses this key for its default session management and we really don't
mind if it is defined or not as we use our own session handlers
2006-07-15 05:16:37 +00:00
Tony Lambregts
e1711a2cdb Show additional comments when viewing test data in application version 2006-07-14 01:48:46 +00:00
Tony Lambregts
ccbb2a14fc Include link to app and version when displaying a list of test results 2006-07-14 01:32:04 +00:00
Jonathan Ernst
a4e384604b Fix missing reply text by renaming replyText to sReplyText 2006-07-13 18:54:10 +00:00
Chris Morgan
04e7fa9906 Rename include/testResults.php to include/testData.php to match the name of the class
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
ec77d82734 Clean up variable naming in query_parameters() 2006-07-11 19:25:16 +00:00
Chris Morgan
069a51fba8 Clean up category class. Move category related functions into the class and remove now extranious
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
457f7cc34b Move distribution related functions into distribution class and combine getNumberOfDistributions() and
getNumberOfQueuedDistributions() by passing in a $bQueued flag
2006-07-11 17:02:35 +00:00
Chris Morgan
1587e8d0b4 Remove unused lookupVendorName() 2006-07-11 03:47:00 +00:00
Chris Morgan
88dde93132 Speed up outputTopXRowAppsFromRating() by earlying out if we have enough applications to fill our required amount.
This saves a database query for each top X table.  Also rename $num_apps to $iNum_apps
2006-07-11 03:41:57 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
d831939a07 Fix case of sWebpage to let updating of application class information correctly update the applications web page. 2006-07-10 23:02:03 +00:00
Chris Morgan
0d8de67fd9 Eliminate redundant parameters from testData function 2006-07-10 15:42:00 +00:00
Chris Morgan
cd5a620d88 testData class cleanup. Move some test related functions into the class as
static functions.  Clean up some variable names.
2006-07-10 15:39:21 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Tony Lambregts
6405eeafa4 Show tested rating and use its color when displaying the list of test results 2006-07-10 03:46:48 +00:00
Tony Lambregts
43a49d462a Fix editing of a users administrative rights 2006-07-10 02:21:47 +00:00
Tony Lambregts
5b1d16da69 Require include/application.php to get the name of the application for email 2006-07-09 22:59:42 +00:00
Tony Lambregts
77170ab9dd Sort test results by rating 2006-07-09 06:08:00 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
07e2dab8f8 Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want
classes to depend on $_REQUEST if possible
2006-07-08 22:10:56 +00:00
Chris Morgan
763ad58bcf Move function in include/comment.php inside of the comment class. This lets us refer to
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
4708101f01 Add cron cleanup function to purge expired sessions from session_list table 2006-07-08 21:49:49 +00:00
Tony Lambregts
edcbd98b9e Fix backward compatibility for bug ids. bug_id from bugzilla is the bug number not the internal buglinkid 2006-07-08 19:05:28 +00:00
Chris Morgan
e9456af9d5 application::display() should use the class internal iAppId instead of any $_REQUEST data 2006-07-07 19:23:58 +00:00
Chris Morgan
0a836dd574 class version uses testResults so include it in version.php 2006-07-07 19:22:33 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
64c1681e43 Fix another missed variable, 'create' to 'sCreate' to allow new users to be created 2006-07-07 18:03:42 +00:00
Chris Morgan
b47070737c Fix page changing that uses display_page_range(). Switch 'page' to 'iPage' and rename variables in
display_page_range() to use our current naming convention
2006-07-07 17:45:22 +00:00
Chris Morgan
e56e95d63a Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function 2006-07-07 16:44:41 +00:00
Jonathan Ernst
89915be4f1 Add an option to prevent filtering of cookies in the case where multiple web apps are hosted
on the same virtualhost
2006-07-07 16:39:27 +00:00
Jonathan Ernst
aefbc1bf90 Fix showing of full size screenshots 2006-07-07 16:25:43 +00:00