claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
793 Commits 1 Branch 0 Tags
160f739da867909846ffd00b1cd31da2e6f32ccd
Commit Graph

74 Commits

Author SHA1 Message Date
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to 
get_random_screenshot_img() so the name of the function matches its purpose
 2006-07-11 03:37:07 +00:00
Chris Morgan
0d8de67fd9 Eliminate redundant parameters from testData function 2006-07-10 15:42:00 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to 
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
 2006-07-09 00:48:33 +00:00
Chris Morgan
07e2dab8f8 Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want 
classes to depend on $_REQUEST if possible
 2006-07-08 22:10:56 +00:00
Chris Morgan
763ad58bcf Move function in include/comment.php inside of the comment class. This lets us refer to 
these functions like Comment:: making it clear they are static functions of the comment class
 2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want 
classes to be hardcoded to read directly from $_REQUEST
 2006-07-08 22:06:28 +00:00
Chris Morgan
0a836dd574 class version uses testResults so include it in version.php 2006-07-07 19:22:33 +00:00
Chris Morgan
e56e95d63a Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function 2006-07-07 16:44:41 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit() 
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
 2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
91b44a3733 Cleanup note editing. Improve previewing of notes during addition and editing. Rename note related 
variables to have the proper prefix.
 2006-06-30 19:48:33 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Chris Morgan
5e1cb3f8a9 Cleanup note class, move display of notes into the class. External code creates and calls Note::show() to display the note. 2006-06-29 19:22:26 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against 
sql injection attacks
 2006-06-27 19:16:27 +00:00
Chris Morgan
ac5b4b0a95 Warn if magic quotes is enabled and explain a bit about why we require that magic quotes 
be disabled.  Also remove all of the conditional code that was working around cases where
we had magic quotes enabled.  We were only working around a small portion of cases where magic
quotes was affecting the appdb.
 2006-06-26 00:44:44 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
ce71a0d8ed Fix case of $aClean['appId']. Fixes the bug of orphaning newly submitted versions 2006-06-20 22:58:58 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
EA Durbin
62de655d75 Fix typo 2006-06-06 18:53:00 +00:00
Tony Lambregts
a0db997fdf Fix the display-approved_versions() function by switching the use of a '=' in an if() to a '==' 2006-04-26 15:11:00 +00:00
Chris Morgan
f3ddc43dd1 Print application names correctly when versions are deleted. $this->appId should have been 
$this->iAppId.
 2006-03-19 18:06:18 +00:00
Tony Lambregts
092487fe91 Cleanup email code 2006-02-22 02:20:02 +00:00
Tony Lambregts
602d15cdca Fix deletion of test results when a version is deleted 2006-02-20 02:51:19 +00:00
Chris Morgan
e309c1b44a Move html output of application and version into the application and version classes 2006-01-29 04:04:46 +00:00
Tony Lambregts
9afa15776e Version class fixes. Let update() be silent if desired, get rid of redundant message in unqueue(). 2006-01-28 23:06:07 +00:00
Tony Lambregts
33302f72ef Make back link in rejection emails point to appsubmit.php 2006-01-18 04:32:28 +00:00
Chris Morgan
369b40b046 Fix SendNotificationEmail() so it appends to the existing message in the 'edit' case instead of overwriting the message passed in 2005-12-05 04:19:14 +00:00
Tony Lambregts
8bb0882cb2 Don't display queued versions, make the function name more descriptive 2005-10-30 22:27:14 +00:00
Tony Lambregts
7bbe114e6d Add arrays for monitors, fix array for test results and use the arrays to delete monitors and bug links when a version is deleted 2005-10-29 04:41:10 +00:00
Chris Morgan
b8cfcda4b5 Remove GetDefaultVersionDescription() now that we don't include testing results in the version description anymore. Remove one final call to it that isn't really necessary 2005-10-28 00:32:20 +00:00
Tony Lambregts
8ebccb4f2a Add test results as part of submitting an application or version 2005-10-28 00:11:35 +00:00
Jonathan Ernst
009e7d9716 Fix variables that don't exist 2005-10-26 02:14:17 +00:00
Chris Morgan
89abe706dc Improve permission checking in objects, fix some initialization bugs 2005-10-26 02:09:49 +00:00
Chris Morgan
c1aa7e392e Fix update() of sTestedRelease to use the correct $this variable 2005-10-16 19:03:12 +00:00
Chris Morgan
657167e8a5 Move hidden fields used by application and version class into their OutputEditor() member functions. Fix broken old style calls to application and version update() functions that were passing parameters in. Fix broken application::CheckOutputEditorInput() 2005-10-16 04:24:37 +00:00
Chris Morgan
49300a8707 Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings. 2005-10-10 02:37:55 +00:00
Chris Morgan
77e623b59f Improve the version rejection message to be like the application rejection one 2005-10-01 00:33:01 +00:00
Tony Lambregts
2311d4d572 Add the ability for user to monitor changes to applications 2005-09-30 01:55:51 +00:00
Tony Lambregts
65c5e0e4b3 Fix bug in the rejection of versions that was only sending the maintainers the url to the requeued application if there was a rejection reason given. Add url to requeued application to rejected applications. 2005-09-21 01:26:10 +00:00
Chris Morgan
16029378eb Fix two other places where $iVersionId was used instead of $this->iVersionId, one in the reject path and another in the delete path 2005-08-21 03:50:39 +00:00
Chris Morgan
d5ba04b634 Fix access of $iVersion inside of version class that should have been $this->iVersion 2005-08-21 02:07:41 +00:00
Tony Lambregts
b7f1d55472 Allow maintainers/administrators to reject an application submission instead of just deleting it 2005-08-15 03:44:03 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Tony Lambregts
c7d6988d4f Fix backlink to application/version when sending email 2005-07-13 03:44:38 +00:00
Tony Lambregts
7f49c5055e Modify the version object to include an array of bugs and use that array when deleting a version 2005-07-13 01:14:53 +00:00
Chris Morgan
6ae3aa98fd When deleting a version or application the first thing deleted was the version 
or application. Then each of the sub-objects like comments, notes etc were
deleted. This order is bad because it makes the database inconsistent, we
never want a comment/note/etc for a version that doesn't exist. Delete the
sub objects first and then the parent object.
 2005-06-30 01:59:32 +00:00