Commit Graph

57 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
2adec2d724 Sort testData by id 2007-06-10 00:14:03 +00:00
Chris Morgan
b59a1d0b1f Add a column to the test data queue to indicate whether a test result is for a application version
that has maintainers. This lets admins defer processing test results to give appliction and version maintiners
a chance to do so.
2007-06-07 02:04:15 +00:00
Chris Morgan
8970888921 Add a comment to encourage test result submitters not to include crash data in their test
submissions.
2007-06-05 03:35:46 +00:00
Ben Hodgetts
2984070157 Add more detail to the test data submission page 2007-05-26 17:01:11 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
a7789c2a8d Fix loading of 'Runs?' value in the testData form, otherwise the value is displayed as
though no value is set
2007-04-26 00:17:42 +00:00
Alexander Nicolaysen Sørnes
42ecaf6eef Fix typo in testData::update() causing the new release info to be absent from the mail sent 2007-04-23 23:38:30 +00:00
Chris Morgan
886cdeafa3 Clean up the layout of the version and application pages and add some css classes to define
the formatting
2007-04-23 02:33:19 +00:00
Alexander Nicolaysen Sørnes
6b265f46fe State what was changed in the e-mail when testData is updated 2007-04-22 19:38:48 +00:00
Alexander Nicolaysen Sørnes
fb4db22141 Fix testData/version::mustBeQueued() 2007-04-22 16:15:12 +00:00
Chris Morgan
af465791f7 Work around bug where submitting versions resulted in testData not being properly queued 2007-04-22 05:21:12 +00:00
Chris Morgan
e83b9b2d58 Fix test result issue with incorrect name causing an error when 'Limit to 5 tests' was
selected
2007-04-22 04:23:57 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17 More fixes and uses for objectManager's version/testData queues 2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
a8a4da643b Make testData's objectGetEntries more consistent for rejected testData. Don't allow
maintainers to view rejected entries for the versions they maintain, but show them their own
rejected entries instead
2007-04-20 00:02:20 +00:00
Alexander Nicolaysen Sørnes
c43563eca6 Fix testData::create() permissions. Separate the cases where a user has edit rights from
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
fbb784c2f5 Fix mails for updated test results. Pass the correct 'edit' parameter to
sendNotificationMail() and only send mail if the test data has been changed.
2007-04-17 23:28:10 +00:00
Alexander Nicolaysen Sørnes
46df59f063 Use objectManager for new test results 2007-04-16 23:10:08 +00:00
Alexander Nicolaysen Sørnes
169d7ca493 Use objectMakeUrl()/Link() in more places 2007-04-08 23:04:31 +00:00
Chris Morgan
4402ac64b1 Rename testData::get_test_for_versionid() to testData::getNewestTestIdFromVersionId() so the
name of the method better describes the value the method is returning
2007-04-01 22:34:33 +00:00
Alexander Nicolaysen Sørnes
fa442e0c8e Fix testData::unQueue() emails by passing 'add' to ::mailSubmitter(). Previously 'unQueue'
was passed but testData::mailSubmitter() doesn't recognize this so likely the response email
had an empty subject
2007-04-01 16:49:28 +00:00
Alexander Nicolaysen Sørnes
c494af3eb5 Fix display of latest testData to exclude queued entries 2007-03-28 00:09:12 +00:00
Chris Morgan
5913b9b43f Implement Alexander's suggestion and use version::fullName() to reduce code duplication 2007-03-25 21:04:33 +00:00
Chris Morgan
08afa4283e testData should display the application name and version in outputEditor() 2007-03-25 19:58:34 +00:00
Alexander Nicolaysen Sørnes
d6e58f9676 Only show checked test results in version display 2007-03-25 18:58:13 +00:00
Alexander Nicolaysen Sørnes
f11a4cf77f Add and use testData::objectDisplayAddItemHelp() 2007-03-25 16:10:15 +00:00
Alexander Nicolaysen Sørnes
8b1271b185 testData: remove un-needed functions now that admin/adminTestResults.php has been removed 2007-03-25 03:58:25 +00:00
Alexander Nicolaysen Sørnes
6aea19138a Add more links in testData::objectOutputTableRow() 2007-03-25 03:57:10 +00:00
Alexander Nicolaysen Sørnes
37296b2242 Let objectManager handle rejected testData 2007-03-25 03:56:20 +00:00
Alexander Nicolaysen Sørnes
c545581571 objectManager, add rejection support. Add support in objectManager for handling rejected
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
18bb33902e Let objectmanager handle testData queue 2007-03-24 02:12:05 +00:00
Chris Morgan
eb98fde3c9 Fix accidental mention of $oTest that should have been $this 2007-03-24 02:10:49 +00:00
Alexander Nicolaysen Sørnes
7d6772b5b1 Test more classes with objectManager 2007-03-24 02:04:16 +00:00
Alexander Nicolaysen Sørnes
7f397c1dc4 Let objectManager show testResults queue. Maintainers now get a list of queued test results
for versions they maintain.
2007-03-18 22:15:06 +00:00
Alexander Nicolaysen Sørnes
9becc84b36 Remove references to distributionView.php and remove now unused distributionView.php 2007-03-13 21:03:08 +00:00
Alexander Nicolaysen Sørnes
917851fceb Fix naming of OutputEditor() to be outputEditor() 2007-01-17 03:18:49 +00:00
Chris Morgan
00b97955b3 Test data processing emails should contain the name of the user accepting, rejecting or deleting the entries 2007-01-10 03:44:26 +00:00
Chris Morgan
edfe83df27 Switch Xinha editor values from strings to html values so the filtering system won't strip out html tags 2007-01-09 04:42:34 +00:00
Alexander Nicolaysen Sørnes
d2b1995d2e Fix subject text of test data mails. It should simply say 'by' instead
of 'submitted by'.
2007-01-09 04:27:55 +00:00
Alexander Nicolaysen Sørnes
7cbada84c8 Add more logic checking to test results. Runs? can only be set to 'Not Installable' if the application's installer does
not work.
2007-01-07 17:41:51 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
18acb017cd Add a page showing a user's queued submissions to the AppDB. This should be
quite useful for a user, and should also reduce the number of duplicate
submissions, as many users seem to think their submissions have been lost if
they are not accepted within a few hours.
2006-12-27 03:26:16 +00:00
Alexander Nicolaysen Sørnes
eb9e649d3d If test results are deleted by the person who submitted it, don't send an
extra mail about it.
2006-12-27 03:23:52 +00:00
Alexander Nicolaysen Sørnes
4f3058e247 Fix the testData's mailSubmitter() so it actually displays the application
name.
2006-12-27 03:19:43 +00:00
Alexander Nicolaysen Sørnes
4586465b09 Add basic rating logic checking to testData::CheckOutputEditorInput() to prevent people from saying a running application is
garbage and an application that won't install is platinum.
2006-11-27 02:32:22 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
EA Durbin
d1c037e0ae Make the case of 'Version' match the case used in the constructor 2006-08-31 02:39:09 +00:00
EA Durbin
320b8c0d82 Make the case of 'Application' class match the case used to define the class. Php doesn't care but its a nice touch. 2006-08-30 22:27:07 +00:00