Commit Graph

88 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
1f081f4be1 test_om_objects: Test unQueue() 2008-01-23 10:45:39 -05:00
Alexander Nicolaysen Sørnes
dd6f0109bf Fix queue links/count for maintainers 2008-01-22 18:41:59 -05:00
Alexander Nicolaysen Sørnes
9b92c2221c Use sState for objectGetEntries[Count]() 2008-01-20 16:13:27 -05:00
Alexander Nicolaysen Sørnes
da97299eeb Use sState as parameter to objectGetItemsPerPage() 2007-12-19 21:01:18 -05:00
Alexander Nicolaysen Sørnes
8c7bd3a5e9 Add initial un-delete support 2007-12-18 20:17:06 -05:00
Alexander Nicolaysen Sørnes
e52f270498 Use objectManager to display main screenshot gallery 2007-12-02 13:53:28 -05:00
Alexander Nicolaysen Sørnes
8b52310051 screenshot: Fully initialize appData object in canEdit() 2007-10-31 18:53:59 -04:00
Alexander Nicolaysen Sørnes
58ef8e62e5 screenshot: Fix random screenshot function 2007-10-23 19:28:44 -04:00
Alexander Nicolaysen Sørnes
53a6360ec0 Allow maintainers to modify screenshot description when processing queued items 2007-09-27 09:20:03 -04:00
Chris Morgan
2827e0654e Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
faf7d9bb19 Add objectGetChildren() method to classes without child objects 2007-09-08 22:29:17 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
19f6cbc156 Unit test cleanups. Fixes tests so they don't leave left over entries in the database. Add a
check to ensure that row counts in most tables are unchanged from the start and end of the
tests. Refactor some code.
2007-07-26 03:47:34 +00:00
Edwin Smulders
023ece493b Eliminate some php notices caused by use of uninitialized variables 2007-07-24 01:45:19 +00:00
Chris Morgan
62bfb16016 Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
051a1e5d0c Cleanup objectManager tests so all objects created during the test are deleted 2007-06-19 00:26:21 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Alexander Nicolaysen Sørnes
fc6e645d1a Allow appData constructor to import appData derived objects 2007-06-10 23:07:51 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Chris Morgan
ea2de6fe3c Screenshot::delete() and Image::delete() should check if the file exists before attempting to
call unlink() on it. Fixes three php errors that occur during the unit tests.
2007-06-09 22:17:32 +00:00
Alexander Nicolaysen Sørnes
299f2b3c2a Adding missing alt attribute to screenshot overlay 2007-05-26 01:38:48 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
2af11e7333 Remove user::deleteAppData() and replace it with an appData function 2007-04-21 19:44:10 +00:00
Alexander Nicolaysen Sørnes
3ab921cf0d Add appData/screenshot::mustBeQueued() 2007-04-21 17:49:43 +00:00
Alexander Nicolaysen Sørnes
169d7ca493 Use objectMakeUrl()/Link() in more places 2007-04-08 23:04:31 +00:00
Alexander Nicolaysen Sørnes
c545581571 objectManager, add rejection support. Add support in objectManager for handling rejected
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
7d6772b5b1 Test more classes with objectManager 2007-03-24 02:04:16 +00:00
Alexander Nicolaysen Sørnes
ed7026be6e Let objectManager output table headers. A class returns an array of header cells and then
the objectManager adds an edit column if appropriate.
2007-03-17 21:04:43 +00:00
Alexander Nicolaysen Sørnes
9ef6268fa6 Let objectManager label the edit link in objectOutputTableRow() because the edit link text
depends on the queue state
2007-03-13 21:08:39 +00:00
Alexander Nicolaysen Sørnes
b628b3af0e Let objectManager handle screenshot queue processing 2007-03-13 00:26:31 +00:00
Alexander Nicolaysen Sørnes
3c3e3a7ca4 Fix screenshot counting and browsing. Make sure to specify the 'screenshot' tpe and use
appData functions for both counting and listing on the screenshots page, ensuring consistent
results.
2007-03-13 00:13:51 +00:00
Alexander Nicolaysen Sørnes
e9060a68d5 Use object manager to process screenshot queue. Temporary fix for mysql overloading by
limiting screenshot processing to submitters.
2007-03-11 03:07:43 +00:00
Alexander Nicolaysen Sørnes
5f6cc94def Rename appData type 'image' to 'screenshot' 2007-03-10 23:31:47 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
4a41fcdbea If a person deletes a screenshot he has submitted himself, don't send him an
extra email about it.
2006-12-27 03:23:01 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
EA Durbin
e303923dea Standardize all Image constructors to match the case defined in the Image class 2006-09-06 01:42:25 +00:00
Chris Morgan
1bdc44a003 Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
2976ff9833 Fix centering of screenshot images on application/version pages 2006-07-19 00:54:56 +00:00
Jonathan Ernst
a4e384604b Fix missing reply text by renaming replyText to sReplyText 2006-07-13 18:54:10 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Jonathan Ernst
aefbc1bf90 Fix showing of full size screenshots 2006-07-07 16:25:43 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Tony Lambregts
ff97ddef7d Fix screenshot display by using the image class member functions instead of class internal private variables 2006-07-04 02:11:09 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00