Commit Graph

194 Commits

Author SHA1 Message Date
Chris Morgan
ea02b57c25 Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
91b44a3733 Cleanup note editing. Improve previewing of notes during addition and editing. Rename note related
variables to have the proper prefix.
2006-06-30 19:48:33 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Jonathan Ernst
c138da9766 Html attributes and values are lowercase to be forward compatible with xhtml 2006-06-27 16:54:22 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
3a3ff401cc Fix case of 'Submit' to fix creating a new distribution 2006-06-23 05:03:03 +00:00
Chris Morgan
540a29cb5e Fix editing bundles, they've been broken since appdb was imported into cvs and we haven't noticed, ha 2006-06-23 03:42:08 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
EA Durbin
d8a459af17 Eliminate the use of the undefined testResult() class and correcting spelling of testData. 2006-06-20 23:00:01 +00:00
Tony Lambregts
ca3fca2e0a Fix up administrating app queue, add missing '[' 2006-06-18 04:22:43 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
a088778a85 Get rid of redundant include to fix adminCommentView.php 2006-06-14 14:57:23 +00:00
Tony Lambregts
42b6c87c7b Add a message to the app/version deletion email to clarify deletions due the app/version being moved 2006-04-27 01:44:57 +00:00
Tony Lambregts
647de96f9d Allow moving test results of a queued version to an approved version 2006-04-26 15:12:55 +00:00
Tony Lambregts
2b544fd6b1 Add email reply text to admin test results form. 2006-02-22 02:17:54 +00:00
Tony Lambregts
385a7c2e0d Cleanup deletion and rejection code 2006-02-20 02:53:23 +00:00
Tony Lambregts
602d15cdca Fix deletion of test results when a version is deleted 2006-02-20 02:51:19 +00:00
Tony Lambregts
0192470558 Fix spelling of 'testing' 2006-01-28 23:00:35 +00:00
Tony Lambregts
4aa90c6cf9 Allow administrators to submit app, version and testresults in one step instead of three. Fix minor vendor logic bug. 2006-01-28 22:59:51 +00:00
Tony Lambregts
7714218746 Fix Edit Application Family back link 2006-01-26 01:19:01 +00:00
Tony Lambregts
689f7fcb9d Fix maintainer queue display to correctly display the version of applications 2006-01-23 02:56:31 +00:00
Tony Lambregts
57119ed39a Fix maintainer queue showing the wrong version due to the creation of a Application object instead of a Version object. 2006-01-23 02:12:40 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
60c8b7806a Redirect admin/resubmitRejectedApps.php to appsubmit.php 2006-01-18 04:21:04 +00:00
Tony Lambregts
3efdcb188c Fix merging of versions into existing applications 2005-11-12 03:06:55 +00:00
Chris Morgan
db1f434d6f Create a version instead of an application from $ob->versionId 2005-10-31 01:29:37 +00:00
Tony Lambregts
f3e45892e7 Fix up help and allow administrators and maintainers to use adminTestResults to edit test results that are not queued 2005-10-30 22:29:14 +00:00
Tony Lambregts
8bb0882cb2 Don't display queued versions, make the function name more descriptive 2005-10-30 22:27:14 +00:00
Tony Lambregts
7bbe114e6d Add arrays for monitors, fix array for test results and use the arrays to delete monitors and bug links when a version is deleted 2005-10-29 04:41:10 +00:00
Chris Morgan
b8cfcda4b5 Remove GetDefaultVersionDescription() now that we don't include testing results in the version description anymore. Remove one final call to it that isn't really necessary 2005-10-28 00:32:20 +00:00
Tony Lambregts
8ebccb4f2a Add test results as part of submitting an application or version 2005-10-28 00:11:35 +00:00
Chris Morgan
89abe706dc Improve permission checking in objects, fix some initialization bugs 2005-10-26 02:09:49 +00:00
Tony Lambregts
40138af1a8 Let users browse vendors and remove some duplicate code 2005-10-25 00:47:32 +00:00
Tony Lambregts
14a3d83d51 Let users view distributions 2005-10-21 02:48:27 +00:00
Tony Lambregts
ba6e92d184 Lets users submit application testing results in a uniform and easy to process manner 2005-10-17 03:59:24 +00:00
Chris Morgan
657167e8a5 Move hidden fields used by application and version class into their OutputEditor() member functions. Fix broken old style calls to application and version update() functions that were passing parameters in. Fix broken application::CheckOutputEditorInput() 2005-10-16 04:24:37 +00:00
Chris Morgan
485f935660 Updates for changes to application and version classes update() functions 2005-10-11 02:16:00 +00:00
Chris Morgan
49300a8707 Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings. 2005-10-10 02:37:55 +00:00
Chris Morgan
0aa7f26249 Switch from using htmlarea to using xinha. Clean up the use of the editor plugin 2005-09-30 02:48:33 +00:00
Chris Morgan
dd24dd83d5 Handle the case where a user has an empty realname, the maintainers table looks bad with missing borders around the cell, fill in with a &nbsp in those cases 2005-08-25 03:44:15 +00:00
Chris Morgan
2b3e470adb Fix borders in adminMaintainers in cells that have no content, they need to have &nbsp in there or they are dropped and not rendered, leaving odd spaces in the table display 2005-08-25 03:35:07 +00:00
Chris Morgan
58d4e45b08 Sort maintainers in adminMaintainers.php by their name. Add header for each maintainer that has a summary of the number of applications and versions they maintain 2005-08-25 03:24:31 +00:00
Tony Lambregts
b7f1d55472 Allow maintainers/administrators to reject an application submission instead of just deleting it 2005-08-15 03:44:03 +00:00