Commit Graph

62 Commits

Author SHA1 Message Date
Chris Morgan
43a7ea8f1d Add object manager support to the bug class. Add menu entries for displaying the bug queue and
list of bugs and remove the existing link to admin/adminBugs.php. Remove now unused
admin/adminBugs.php. Remove now unused getNumberOfQueuedBugLinks() and getNumberOfBugLinks()
from util.php. Add object manager unit test support for the bug class.
2007-08-27 03:48:44 +00:00
Chris Morgan
73c3e584e3 Check for failure returned from testData::create() 2007-08-04 04:51:14 +00:00
Chris Morgan
0290064883 Check for error codes returned from application::create() and version::create() 2007-08-04 04:50:14 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
62820d242c Purge and check session message count before and after the unit tests. The unit tests generate
a lot of session messages and we don't want to leave these around after the tests.
2007-07-30 01:56:39 +00:00
Alexander Nicolaysen Sørnes
89c50400de Add objectManager support to the monitor class 2007-07-30 01:22:55 +00:00
Chris Morgan
a923d0ff2f Add objectManager support to the note class 2007-07-30 00:27:37 +00:00
Chris Morgan
a9aef35628 Call $oObject->objectGetId() to retrieve an object's id instead of directly accessing the
objects member variables
2007-07-29 16:01:26 +00:00
Chris Morgan
93dc3e0396 Add support for mysql versions >=4.0x by adding multiple hash attempts when logging in. We now
attempt sha1(), password() and if mysql >= 4.0x, old_password() hashes. Switch the default user
hash from mysql's password() function to a sha1() hash. Update user::login() to flag logins
with password() and old_password() hashes. If the flag is set we call user::update_password()
to update the users password hash to one generated from the sha1 of the users password. Add a
unit test to test logging in and upgrading from the old hashes.
2007-07-26 14:39:15 +00:00
Chris Morgan
652fd5d517 Remove explicit user::login() call from create_and_login_user() since user::create() calls
user::login() if the user creation is successful
2007-07-26 14:30:32 +00:00
Chris Morgan
19f6cbc156 Unit test cleanups. Fixes tests so they don't leave left over entries in the database. Add a
check to ensure that row counts in most tables are unchanged from the start and end of the
tests. Refactor some code.
2007-07-26 03:47:34 +00:00
Chris Morgan
33faa569eb Clean up database creation to create the mysql interface user and grant permissions. Group
database setup together so the user is prompted for only a couple of times during
initialization.
2007-07-24 21:49:23 +00:00
Chris Morgan
b5a41fba77 Add the long awaited 'maintainer notification' system. This system, running from the cron
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
88a832199d Implement browsing of newest apps in the object manager infrastructure 2007-07-16 03:04:07 +00:00
Alexander Nicolaysen Sørnes
2c32bc608b Cleanup appData test 2007-06-19 00:27:13 +00:00
Alexander Nicolaysen Sørnes
051a1e5d0c Cleanup objectManager tests so all objects created during the test are deleted 2007-06-19 00:26:21 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
cb18a07f60 downloadurl: Add more objectManager functions. Allow us to unqueue queued downloadurls that are
currently stuck in limbo.
2007-05-31 02:40:01 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
b11cce6711 Use objectManager to submit and process applications. Remove now unused appsubmit.php
admin/adminAppQueue.php
2007-04-24 23:48:14 +00:00
Alexander Nicolaysen Sørnes
8cf53f1679 Use mustBeQueued() to determine unqueueing in objectManager 2007-04-22 00:39:53 +00:00
Alexander Nicolaysen Sørnes
dad5de17b1 Test version/testData queues. Test version_queue and testData_queue with the objectManager
tests
2007-04-21 00:58:08 +00:00
Alexander Nicolaysen Sørnes
b584fe1df7 Fix maintainer listing for versions. getMaintainersForAppIdVersionId() did not check that
additional entries had a superMaintainer = 1 so a maintainer of one version would be listed
as the maintainer for all versions of the application. Correct that issue and update the
unit test.
2007-04-16 23:19:44 +00:00
Alexander Nicolaysen Sørnes
ba3f966da4 test maintainer::getMaintainersForAppIdVersionId() 2007-04-08 23:06:27 +00:00
Alexander Nicolaysen Sørnes
9de4e9b63b Test version class in objectManager tests 2007-04-08 23:01:22 +00:00
Alexander Nicolaysen Sørnes
eeaf2c3642 Add test for testData::getNewestTestIdFromVersionId() 2007-04-03 00:05:35 +00:00
Alexander Nicolaysen Sørnes
6b9abce52c Avoid overlapping maintainer entries. When a user becomes a super maintainer of an
application remove all of their maintainer entries for the application versions. Update unit
tests to test maintainter overlapping.
2007-04-01 00:08:12 +00:00
Chris Morgan
e2b15c0566 Keep track of global success or failure and print out a summary success or failure when the
tests are complete. Makes it less likely that a test failure will be missed.
2007-03-31 17:12:55 +00:00
Alexander Nicolaysen Sørnes
c545581571 objectManager, add rejection support. Add support in objectManager for handling rejected
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
7d6772b5b1 Test more classes with objectManager 2007-03-24 02:04:16 +00:00
Alexander Nicolaysen Sørnes
ed7026be6e Let objectManager output table headers. A class returns an array of header cells and then
the objectManager adds an edit column if appropriate.
2007-03-17 21:04:43 +00:00
Alexander Nicolaysen Sørnes
641e1c32f6 Test objectGetEntries() in the objectManager tests 2007-03-17 00:50:10 +00:00
Alexander Nicolaysen Sørnes
fef587a60e Fix appData::listSubmittedBy() to run faster. Add a unit test for appData::listSubmittedBy() 2007-03-15 23:43:46 +00:00
Alexander Nicolaysen Sørnes
fc47fdabcd Test more objectManager functions 2007-03-13 21:05:11 +00:00
Alexander Nicolaysen Sørnes
0ad148f69f Add and use objectManager to display and edit vendors and distributions. Based on a patch by
Chris Morgan
2007-02-03 19:03:42 +00:00
Alexander Nicolaysen Sørnes
1aef926d97 Cleanup after unit tests 2007-01-27 22:58:58 +00:00
Alexander Nicolaysen Sørnes
83164089ae Disallowid of 0 in deleteMaintainersForVersion(). Add a unit test to ensure that
deleteMaintainersForVersion() behaves properly.
2007-01-24 04:10:05 +00:00
Alexander Nicolaysen Sørnes
a81ce02877 Allow maintainer requests on version submission 2007-01-20 17:41:43 +00:00
Alexander Nicolaysen Sørnes
25fd2a1dcb Unit test for url::update() 2007-01-19 01:41:01 +00:00
Chris Morgan
3eca785210 filter_gpc() should report success or failure, a higher level function should take care of calling out to an error page.
Add a unit test for filter_gpc() and test filtering success, failure and test that the filtering of html and normal strings
properly preserves tags for html strings and strips them from normal strings
2007-01-06 06:27:50 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
8786673db6 Allow the user to tick a checkbox upon application submission, indication
whether he would like to become a super maintainer of the application.  The
request is processed along with the application. Also add a unit test that
tests maintainer requests submitted along with an application.
2006-12-09 05:07:25 +00:00
WineHQ
9643c80288 Authors: Alexander Nicolaysen Sørnes <alex@thehandofagony.com>, Chris Morgan <cmorgan@alum.wpi.edu>
Make sure that a maintainer entry is not deleted incorrectly in Maintainer::unQueue().  If
a request has already been accepted, it is not a duplicate. Add a unit test to test the behavior of Maintainer::unQueue() on
an already unqueued maintainer.
2006-12-03 16:26:38 +00:00
Chris Morgan
c19a471bd5 Unit tests should disable sending email before they execute, we don't want any accidental emails sent when developers are
running the unit tests to verify functionality. Add commented out example code that will enable developers to disable email via
a define in include/config.php
2006-12-02 19:44:31 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
EA Durbin
7532d9091e Application::countWithRating() and getWithRating() should avoid queued applications. Add unit test
to ensure that we don't include queued applications
2006-09-30 01:31:04 +00:00
Chris Morgan
74fb6b5bd8 Flush the error log before performing the error log test, otherwise pending errors can throw the tests error count off
and cause it to improperly fail
2006-09-27 02:47:52 +00:00
EA Durbin
d8fe952bb1 Add the ability to browse applications by rating and a unit test for the added Application::getWithRating() 2006-09-27 02:44:16 +00:00
WineHQ
47e7ad72af Authors: "EA Durbin" <ead1234@hotmail.com>, Chris Morgan <cmorgan@alum.wpi.edu>
Application::delete() should retrieve the applications versions immediately prior to deleting to ensure that
an application object created prior to its child versions doesn't leave orphaned versions. Add unit test for
Application::delete() to test for the offending behavior.
2006-09-26 02:05:55 +00:00