Commit Graph

47 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
4d65a32e17 Only show the 'add entry' link if the class has enabled it. The link is only useful for classes
that have no parent objects. The objectShowAddEntry() method is not required because it only
affects the user interface.
2007-09-08 22:42:34 +00:00
Alexander Nicolaysen Sørnes
5a4cbf49a3 Add and use objectGetChildren() method. Add support for initializing comment class from SQL
result.
2007-09-08 22:38:20 +00:00
Chris Morgan
82d02d655f Skip deleting a distributions test results if there are no test results for the distribution 2007-08-27 03:46:03 +00:00
Alexander Nicolaysen Sørnes
d4c7b3f9f7 Add multipage controls to lists of distributions 2007-08-25 16:01:03 +00:00
Chris Morgan
4d82c32adc Enable deletion of a distribution's test results along with the distribution, if the user has
admin privileges.
2007-08-24 03:49:33 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
8d61f9b497 distribution::delete() should return false upon failure 2007-07-31 03:31:07 +00:00
Chris Morgan
0e3472e1bf objectGetHeader() should return a TableRow instance as this is closer to what the information
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Chris Morgan
2652e68d01 Programmatic table support. Enhances several tables with highlightable and clickable rows and
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Chris Morgan
62bfb16016 Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
bdca7c3bac distribution: Fix empty submitter notification email. Pass the correct argument to
mailSubmitter()
2007-06-16 17:02:25 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
46f4f20ce6 Fix minor indenting issue 2007-06-13 03:13:06 +00:00
Chris Morgan
59ed94fc54 Add a couple of comments and braces 2007-06-11 04:06:06 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
bab429ee90 Return true when creating duplicate distributions 2007-05-26 01:37:25 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
eb49e9344d Add om method for displaying a move child objects page. A link to this page is displayed in
an entry's view page automatically if the class that entry has the required methods
objectMoveChildren and objectGetId
2007-04-27 23:43:43 +00:00
Alexander Nicolaysen Sørnes
e87db015c2 Allow maintainers to submit un-queued distributions.They are allowed to submit un-queued
testData for the versions they maintain, so without this change they submit un-queued test
results associated with a queued distribution. This doesn't make any sense since the
testData would be active but the distribution queued. It's cleaner to just let maintainers
unqueue distributions for versions they maintain.
2007-04-27 23:22:37 +00:00
Alexander Nicolaysen Sørnes
33ee8c4458 Repalce '"' with '&quot;' in the distribution form. Otherwise we end up with broken <input>
fields
2007-04-21 18:09:13 +00:00
Alexander Nicolaysen Sørnes
208033d788 Add and use distribution::mustBeQueued() 2007-04-21 17:50:44 +00:00
Alexander Nicolaysen Sørnes
e176c0a9c7 Only show un-queued distributions in the testData list 2007-04-19 23:48:23 +00:00
Alexander Nicolaysen Sørnes
efae38f6bf Use html_tr() function in distribution::outputEditor() 2007-04-17 23:19:48 +00:00
Alexander Nicolaysen Sørnes
46df59f063 Use objectManager for new test results 2007-04-16 23:10:08 +00:00
Alexander Nicolaysen Sørnes
89535dbe01 Use objectMakeLink()/Url() in more places 2007-04-03 02:08:44 +00:00
Alexander Nicolaysen Sørnes
37296b2242 Let objectManager handle rejected testData 2007-03-25 03:56:20 +00:00
Alexander Nicolaysen Sørnes
c545581571 objectManager, add rejection support. Add support in objectManager for handling rejected
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
ed7026be6e Let objectManager output table headers. A class returns an array of header cells and then
the objectManager adds an edit column if appropriate.
2007-03-17 21:04:43 +00:00
Chris Morgan
80e30b65a8 Distributions don't have descriptions, so don't try to retrieve this entry from the database
row object. Call out to objectMakeUrl() instead of using its address. Fixes two errors
exposed by the unit tests.
2007-03-17 21:00:41 +00:00
Alexander Nicolaysen Sørnes
9ef6268fa6 Let objectManager label the edit link in objectOutputTableRow() because the edit link text
depends on the queue state
2007-03-13 21:08:39 +00:00
Alexander Nicolaysen Sørnes
9becc84b36 Remove references to distributionView.php and remove now unused distributionView.php 2007-03-13 21:03:08 +00:00
Alexander Nicolaysen Sørnes
00bc2fbd27 Add comment for distribution::objectGetEntries()'s LIMIT behavior 2007-03-13 18:29:28 +00:00
Alexander Nicolaysen Sørnes
f782c10317 Add distribution queue.
Queued distributions are still treated like un-queued ones, since currently
only 8 distributions are un-queued.  'View Distributions', however, will only
show un-queued distributions.

If an admin tries to remove a distribution with associated test results, an
error is printed and no action is performed.  This could be improved in the
future by showing a 'move test data' link.
2007-03-13 16:59:35 +00:00
Alexander Nicolaysen Sørnes
0ad148f69f Add and use objectManager to display and edit vendors and distributions. Based on a patch by
Chris Morgan
2007-02-03 19:03:42 +00:00
Alexander Nicolaysen Sørnes
cbdce75b0b Allow object creation from a mysql resource, allow objectGetEntries() to limit the range of
entries requested, this will be necessary for future performance optimizations
2007-02-01 02:06:38 +00:00
Alexander Nicolaysen Sørnes
cbfc49f42f Add and use distribution::display() 2007-01-31 02:18:18 +00:00
Alexander Nicolaysen Sørnes
cc7c6e661a Fix capitalization of some methods of distribution class 2007-01-30 00:46:55 +00:00
Alexander Nicolaysen Sørnes
783215a6f1 Only display delete link for distributions without any associated test data 2007-01-30 00:46:05 +00:00
Alexander Nicolaysen Sørnes
4590b581c8 Return true on sucess in distribution::delete() 2007-01-30 00:43:33 +00:00
Alexander Nicolaysen Sørnes
5bb8448821 Add distribution functions and use them. Based on a patch by Chris Morgan 2007-01-27 00:30:00 +00:00
Alexander Nicolaysen Sørnes
917851fceb Fix naming of OutputEditor() to be outputEditor() 2007-01-17 03:18:49 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
Chris Morgan
9364f5bc5a Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
of the distribution class
2006-07-21 04:21:04 +00:00