Commit Graph

123 Commits

Author SHA1 Message Date
Chris Morgan
c726511204 Make table rows clickable using javascript. Use this functionality in the top X lists and in the test results table 2006-07-21 04:34:58 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
1587e8d0b4 Remove unused lookupVendorName() 2006-07-11 03:47:00 +00:00
Chris Morgan
88dde93132 Speed up outputTopXRowAppsFromRating() by earlying out if we have enough applications to fill our required amount.
This saves a database query for each top X table.  Also rename $num_apps to $iNum_apps
2006-07-11 03:41:57 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
b47070737c Fix page changing that uses display_page_range(). Switch 'page' to 'iPage' and rename variables in
display_page_range() to use our current naming convention
2006-07-07 17:45:22 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
1a6cde7f1e Fix the application name column in the top 'X' lists to be 150px wide so each top 'X' list
looks uniform
2006-06-23 04:11:50 +00:00
Chris Morgan
58b267506f Fix indenting and formatting 2006-06-22 22:34:56 +00:00
Chris Morgan
b55c2776a5 Compact the top 'X' lists on the main page by adding a flag to get_screenshot_img() that disables the output of
html that was putting the image inside of another table
2006-06-22 21:41:41 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
Chris Morgan
6ceb14ef92 Disable addslashes() in makeSafe() until more finely grained filtering can be implemented 2006-06-19 15:40:53 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
d1ee3e66b0 Add Platinum to ratings 2006-02-08 03:19:40 +00:00
Tony Lambregts
da2c7c6bb6 Prevent the choice of unspecified Wine versions 2006-01-28 23:06:53 +00:00
Tony Lambregts
8bb0882cb2 Don't display queued versions, make the function name more descriptive 2005-10-30 22:27:14 +00:00
Tony Lambregts
ba6e92d184 Lets users submit application testing results in a uniform and easy to process manner 2005-10-17 03:59:24 +00:00
Chris Morgan
90e471c83e Improve HtmlAreaLoaderScript() to work properly when called more than twice on a page 2005-10-11 01:06:54 +00:00
Chris Morgan
49300a8707 Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings. 2005-10-10 02:37:55 +00:00
Chris Morgan
0aa7f26249 Switch from using htmlarea to using xinha. Clean up the use of the editor plugin 2005-09-30 02:48:33 +00:00
Chris Morgan
5b846f81ac Fix screenshots for the top-X lists. We were passing a versionId as the first parameter of a function that expected an appId as the first parameter 2005-09-26 01:37:12 +00:00
Chris Morgan
2edc247c00 Make top-X lists version specific because only versions have ratings 2005-09-26 00:56:36 +00:00
Lukas Middendorf
691a199bd1 Search results were listing a number of versions that was counting versions that were still in the queue to be processed by appdb admins. Exclude queued versions from the count. 2005-08-14 17:27:08 +00:00
Chris Morgan
0665823494 Remove words less than 4 letters from the normal searching path to reduce spurious matches 2005-08-06 03:53:08 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Chris Morgan
f6fe0a0cab If buglinks queries fail don't try to mysql_fetch_object() on the result 2005-08-01 03:57:32 +00:00
Chris Morgan
cd6f9e8302 Remove 'game' from our search terms because many application descriptions use the word and searching for it returns erroneous results 2005-07-28 00:22:43 +00:00
Tony Lambregts
01040ae536 Add some functions that will be used to maintain buglinks 2005-07-20 02:27:43 +00:00
Jonathan Ernst
e645810d69 Fix missing application name when updating links 2005-07-05 04:00:39 +00:00
Chris Morgan
3342c55772 Keep track of the appIds we've already output to the top X list. If we need
to fill the list in with applications that haven't received any votes make
sure we exclude the applications we've already output.
2005-06-25 03:44:39 +00:00
Chris Morgan
0f13fb4a38 Filter searches inside of searchForApplication() and
searchForApplicationFuzzy() so filtering occurs at the lowest possible level.
This fixes a bug where a list of duplicates an admin sees has the results
from an unfiltered search and may contain hundreds of extra applications.
2005-06-24 01:30:55 +00:00
Chris Morgan
e49a0cb2ae Ignore any search word that is in a list of common words. Also ignore any
single letters.
2005-06-17 02:16:49 +00:00
Chris Morgan
a413175e40 Improve search results by seeing if any of the search words match a vendor
name or a vendor url. If so we should return all of the vendors applications
in our search results.
2005-06-14 19:38:36 +00:00
Chris Morgan
bce26361f3 Trim spaces from the begining and end of the search string so we don't miss
some 'like' matches.
2005-06-14 16:25:20 +00:00
Chris Morgan
97513244c4 Admin app queue page was only displaying like matches for a submitted app.
Factor like and fuzzy searches out in to a function and call that function
from normal search and from the app queue page so admins see fuzzy matches
for submitted apps.
2005-06-08 00:35:30 +00:00
Chris Morgan
55971e8f8b Factor ~80 lines of code that were present in both editAppFamily.php and
editAppVersion.php into a new function in util.php.
2005-06-05 18:41:47 +00:00
Chris Morgan
1022d47451 Make fuzzy matches use case insensitive strings to improve match accuracy. 2005-06-03 23:41:16 +00:00
Chris Morgan
5c1f7f7948 Fix urls in version and application search result display functions so the
urls work from any directory, not just the appdb root directory.
2005-06-03 23:36:27 +00:00
Chris Morgan
717ebf0f5e Add fuzzy matching using php's similar_text. Default to using 60% minimum
match. Show fuzzy matches below the 'like matches' table so users can tell
the results apart. Exclude like matches from fuzzy match results to avoid
duplicate results.
2005-06-03 04:37:40 +00:00
Chris Morgan
1bde8ef22a When processing a new version, display a list of the applications existing
versions so its easy to determine if the version submission is a duplicate or
is covered by a group entry such as '1.X'.
2005-05-20 02:45:55 +00:00
Chris Morgan
5f6053ab41 When processing an application automatically perform a search of the
database for the application name and display a table at the top of the
page. This makes it easier to determine if the submission is a duplicate.  Remove
obsolete comments for admins.  Add a 'back' link to the top of the page
to make it easier to go back without scrolling to the bottom of the page.
2005-05-14 00:42:25 +00:00
Chris Morgan
012fbdf264 Build top-X lists from a function call that will use the highest
voted apps for the list and fill the rest of the list in with applications
that have screenshots.  Don't mention a blank top application if there are no
votes recorded and no top application.CVS:
----------------------------------------------------------------------
2005-05-12 23:49:30 +00:00