Commit Graph

48 Commits

Author SHA1 Message Date
Chris Morgan
f9e712382d Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Adapt the missing screenshots mail in the cron screenshots cleanup code to specify more clearly what action was taken.
2007-09-14 23:48:05 -04:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b5a41fba77 Add the long awaited 'maintainer notification' system. This system, running from the cron
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
1d3050fc96 Fix cron maintenance email subject for database error log emails. Forgot to flag $sEmailSubject
as global
2007-06-16 17:04:56 +00:00
Chris Morgan
00ccd7b18b Fix subject of database error log email sent during cron maintenance 2007-06-16 03:35:05 +00:00
Chris Morgan
9d35df1b54 Assign the admin user to $SESSION['current'] 2007-06-15 04:54:57 +00:00
Chris Morgan
9135f3ee99 Fix typo 2007-06-15 04:35:22 +00:00
Chris Morgan
1ae5758ffc Login as an admin user during cron maintenance so we can delete screenshots 2007-06-15 04:28:00 +00:00
Chris Morgan
6f1ac4d074 Re-enable screenshot purging to see how it works now that we've got the reported list 2007-06-15 04:10:00 +00:00
Chris Morgan
8d1b120378 Add missing 'global $sEmailSubject;' declaration to functions using the global $sEmailSubject
value.
2007-06-14 01:17:07 +00:00
Chris Morgan
2c4929e7e1 Standardize the subject of the cron cleanup emails 2007-06-12 01:05:32 +00:00
Chris Morgan
d0022decd4 Disable screenshot deletion and add screenshot ids to the cleanup email so we can verify that
the cleanup script is removing the correct screenshots.
2007-06-10 17:13:49 +00:00
Chris Morgan
be5361f751 Activte the deletion portion of the 'screenshots with missing files' cleanup 2007-06-08 00:42:06 +00:00
Chris Morgan
4b61351551 Refactor some code into a function to clean up the cleanup script 2007-05-26 04:02:24 +00:00
Chris Morgan
aefbc6de57 Add removeScreenshotsWithMissingFiles() to the nightly cron script. This will close a hole where
we could potentially have screenshots in the database that don't have thumbnails or images.
2007-05-24 02:29:44 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Chris Morgan
cef2aec209 Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
a651a3cdf3 Modify query_error() to log errors to a database table instead of displaying them on the screen. This should
let us more easily debug difficult or intermittent issues that users may not report. Add a cron to report logged
errors to appdb admins every night.  Implement some basic unit tests for the new error logging code
2006-07-19 16:37:54 +00:00
Chris Morgan
4708101f01 Add cron cleanup function to purge expired sessions from session_list table 2006-07-08 21:49:49 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
bd19dc7a0b Make sure the .htaccess file in cron/ disables magic quotes like the one in the lowest level appdb directory 2006-07-06 15:54:58 +00:00
Chris Morgan
6aca4e34f9 Purge orphaned messages from sessionMessages that are older than 1 day after notifying admins
of the number of orphaned messages. We currently have
over 150k messages stuck in this table with the earliest dating back to 2004.
We need to ensure that this doesn't occur again and that we can detect leaked
messages as these represent bugs in the appdb code.
2006-07-06 04:39:02 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Tony Lambregts
d38adfedac Fix up inactivity warnings and include login link on inactivity email 2006-03-24 03:20:34 +00:00
Chris Morgan
382d08032c Improve format of orphaned application to include the query and to format the output better 2005-10-21 02:18:10 +00:00
Chris Morgan
93ab2587ef Add stats field for users who have been flagged as inactive and are pending deletion 2005-10-15 16:05:03 +00:00
Chris Morgan
fde3ca0eaa Cleanup summary should tell us how many users overall have been warned and are pending deletion after their 1 month warning period elapses 2005-10-15 15:28:01 +00:00
Chris Morgan
cc9caadb13 The cleanup script should rport orphaned versions in the database, if any exist 2005-10-15 15:11:23 +00:00
Chris Morgan
4e90e6f03c Formatting fixes to cleanup summary emails 2005-10-11 00:17:31 +00:00
Chris Morgan
4469e01e5b Be more specific with users we warned and ones that we wanted to warn but didn't because they have data associated with their account 2005-10-09 18:32:44 +00:00
Chris Morgan
eada9b9658 Remove debug printing from cleanup script now that the bug in user.php has been fixed 2005-10-09 18:17:43 +00:00
Chris Morgan
1de5d7923f Make sure $hUsersToWarn and $hUsersToDelete are valid before calling mysql_fetch_object() on them 2005-10-09 17:32:59 +00:00
Chris Morgan
d4740cf030 Add another line of debug output to the cleanup script to see how many rows we retrieved 2005-10-09 15:44:09 +00:00
Tony Lambregts
2a9c77c0b2 Fix bugs in cleanup script that were preventing debug emails from being sent. Add more debug emails 2005-10-08 22:42:51 +00:00
Chris Morgan
5522e80a9e Add more progress emails to the cleanup script, these are sent directly to me to avoid spamming people during debug 2005-10-05 00:42:35 +00:00
Chris Morgan
a66ae25f38 Move deletion of maintainer logic into the user class. If the cleanup script wants to delete a user and can't, if they are a maintainer we should remove their maintainer status even if we don't delete their account. Send email at the start of the cleanup script to aid in debug 2005-09-30 01:37:57 +00:00
Chris Morgan
b067e62789 Simplify the cleanup script a little bit. Report a summary of what the cleanup script did in the email that the script sends to the appdb admins 2005-09-29 01:45:39 +00:00
Chris Morgan
1a58863f78 Improve cleanup script to give users 1 month after warning before removing their account. Move user related logic into the user class. Add columns to the user_list table to track whether the user was warned about inactivity and the datetime of the warning. 2005-09-28 00:32:48 +00:00
Chris Morgan
374c6f550b Disable the cleanup script until the patch to fix it is reviewed carefully, otherwise we may email a bunch of people again 2005-09-23 02:52:19 +00:00
Chris Morgan
c44f818218 Send notification emails to admins when the cleanup cron job executes so there is some visibility into the maintenance tasks running on the appdb. Fix a minor bug in the user class where passing in (null,null) for iVendorId and iAppId results in a null query string being sent to mysql and triggering an error 2005-09-15 00:22:22 +00:00
Chris Morgan
342bd66485 Delete a users comments when the user is deleted. Return the correct
value in cron/cleanup.php when looking for user associated data.
2005-05-13 00:28:28 +00:00
Chris Morgan
c6d02eab88 Improve efficiency of hasDataAssociated() by counting rows of a single column
instead of selecting *
2005-02-15 19:19:36 +00:00
Jonathan Ernst
0f0737f047 - doesn't send e-mail from the cleanup script until we have less bad email users.
- use the user class to cleanly delete user
2005-02-14 18:21:27 +00:00
Jonathan Ernst
7b12f89abf - improve application and related classes
- use application/version/vendor class in scripts
- don't use a full table for queued appication but only one field in the application and version tables
- simplify the code in many places
2005-02-07 23:21:33 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
0a839e359a - use mail_appdb() instead of mail() for better error handling and to avoid code duplication
- use \r\n as line separator in mail (RFC compliant)
2005-01-30 00:57:34 +00:00
Jonathan Ernst
e8ec89374b Remove unused tables 2005-01-29 17:19:19 +00:00
Jonathan Ernst
b3eee9c65f - cron job to delete inactive users
- improved statistics
2005-01-19 05:03:07 +00:00