Commit Graph

32 Commits

Author SHA1 Message Date
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Edwin Smulders
023ece493b Eliminate some php notices caused by use of uninitialized variables 2007-07-24 01:45:19 +00:00
Alexander Nicolaysen Sørnes
89535dbe01 Use objectMakeLink()/Url() in more places 2007-04-03 02:08:44 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Chris Morgan
cef2aec209 Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Chris Morgan
89abe706dc Improve permission checking in objects, fix some initialization bugs 2005-10-26 02:09:49 +00:00
Chris Morgan
dd24dd83d5 Handle the case where a user has an empty realname, the maintainers table looks bad with missing borders around the cell, fill in with a &nbsp in those cases 2005-08-25 03:44:15 +00:00
Chris Morgan
2b3e470adb Fix borders in adminMaintainers in cells that have no content, they need to have &nbsp in there or they are dropped and not rendered, leaving odd spaces in the table display 2005-08-25 03:35:07 +00:00
Chris Morgan
58d4e45b08 Sort maintainers in adminMaintainers.php by their name. Add header for each maintainer that has a summary of the number of applications and versions they maintain 2005-08-25 03:24:31 +00:00
Jonathan Ernst
25f3f01412 - display the submit time correctly in admin panels
- display the submitter correctly in admin panels
2005-02-20 01:55:53 +00:00
Jonathan Ernst
73c7044a10 Make admin panels look consistant (same column name and order, editing
links in the last column, etc.)
2005-02-09 02:22:20 +00:00
Jonathan Ernst
cfd1d1ac09 - renamed lookupVersionName and lookupAppName into lookup_version_name and lookup_app_name in respect to CODING_STANDARD
- removed appIdToName($appId) and versionIdToName($appId) from category.php
- replaced every occurence of appIdToName and versionIdToName with lookup_app_name and lookup_version_name
2005-02-04 02:59:05 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
d9826427da This patch make email address the user's username as requested in the TODO.
query_users.php is modified even if we will drop it in the future to be sure it works everywhere.
2005-01-10 22:54:04 +00:00
Eric Blade
ffeeaef807 Clean up HTML and PHP, remove extranious checks for loggedin() 2004-12-29 20:21:31 +00:00
Jonathan Ernst
d451aeb595 - use superglobals in adminMaintainers.php
- replace mysql_query with query_appdb in adminMaintainers.php
2004-12-29 03:46:19 +00:00
Jonathan Ernst
ca749d32d9 make use of the new constants of the config file for db connection and base path 2004-12-23 01:12:03 +00:00
Jonathan Ernst
d3d9e853d9 - replaced tons of tabs with spaces
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
Chris Morgan
234298e884 Incorrectly looking up the current users super maintainer status for each
maintainer entry where we should be using the supermaintainer status returned from
the sql query.
2004-12-11 21:23:56 +00:00
Chris Morgan
1911e5f9fd Fix adminMaintainers.php, reported by Tony. 2004-12-11 19:35:02 +00:00
Chris Morgan
3fa8a3bd7a Add support for application wide maintainers, super maintainers, that are
maintainers for all versions of a particular application.
2004-12-10 00:18:01 +00:00
Chris Morgan
c81eebd949 add support for application maintainers 2004-11-09 22:41:18 +00:00