Commit Graph

1271 Commits

Author SHA1 Message Date
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
03dca3cabd Remove single quotes by removing the contractions that necessitated them 2007-08-01 03:29:12 +00:00
WineHQ
3d1d86cdd8 Authors: Alexander Nicolaysen Sørnes <alex@thehandofagony.com>, Chris Morgan <cmorgan@alum.wpi.edu>
Clean up some html in maintainer notification emails, add information about who the email is
addressed to so there is some way to see who the notification system is notifying.
2007-08-01 02:19:33 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
8b7fdf606c No need to have 'View' in front of each of our links, it should be pretty obvious to admins
that clicking on the link will let them interact with the particular queue/list.
2007-07-31 03:46:16 +00:00
Chris Morgan
8d61f9b497 distribution::delete() should return false upon failure 2007-07-31 03:31:07 +00:00
Chris Morgan
bc49543356 vendor::delete() should always return a value, in this case if we fall through we've failed 2007-07-31 03:09:42 +00:00
Chris Morgan
a7d8eb7e20 Clean up return values of testData::delete(), return false upon failure. 2007-07-31 03:07:39 +00:00
Chris Morgan
0e3472e1bf objectGetHeader() should return a TableRow instance as this is closer to what the information
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Alexander Nicolaysen Sørnes
9231bac634 Preserve subject when replying to contact form mails 2007-07-30 23:17:16 +00:00
Alexander Nicolaysen Sørnes
bdbb708fcf Display login url in contact form when not logged in 2007-07-30 23:16:10 +00:00
Chris Morgan
59923d626d Default user needs permissions to access the bugs database, add a grant line to the bugzilla
database and table creation
2007-07-30 23:13:14 +00:00
Chris Morgan
62820d242c Purge and check session message count before and after the unit tests. The unit tests generate
a lot of session messages and we don't want to leave these around after the tests.
2007-07-30 01:56:39 +00:00
Alexander Nicolaysen Sørnes
89c50400de Add objectManager support to the monitor class 2007-07-30 01:22:55 +00:00
Chris Morgan
a923d0ff2f Add objectManager support to the note class 2007-07-30 00:27:37 +00:00
Chris Morgan
3c66a95f3f Add a note so users don't think that the user creation failure isn't necessarily a bad thing 2007-07-29 23:01:33 +00:00
Chris Morgan
a9aef35628 Call $oObject->objectGetId() to retrieve an object's id instead of directly accessing the
objects member variables
2007-07-29 16:01:26 +00:00
Alexander Nicolaysen Sørnes
cd0542a893 Avoid stating 0 as the total page count 2007-07-29 03:51:15 +00:00
Alexander Nicolaysen Sørnes
1567fa2a32 Use multipage controls for version lists 2007-07-28 20:10:54 +00:00
Alexander Nicolaysen Sørnes
09107d7142 Use multipage controls for application lists 2007-07-28 20:08:50 +00:00
Alexander Nicolaysen Sørnes
f37fa6e42f Speedup maintainer::objectGetEntries and maintainer::objectGetEntriesCount. Use UNION for sql
statements and multipage controls
2007-07-26 14:42:21 +00:00
Chris Morgan
93dc3e0396 Add support for mysql versions >=4.0x by adding multiple hash attempts when logging in. We now
attempt sha1(), password() and if mysql >= 4.0x, old_password() hashes. Switch the default user
hash from mysql's password() function to a sha1() hash. Update user::login() to flag logins
with password() and old_password() hashes. If the flag is set we call user::update_password()
to update the users password hash to one generated from the sha1 of the users password. Add a
unit test to test logging in and upgrading from the old hashes.
2007-07-26 14:39:15 +00:00
Chris Morgan
652fd5d517 Remove explicit user::login() call from create_and_login_user() since user::create() calls
user::login() if the user creation is successful
2007-07-26 14:30:32 +00:00
Chris Morgan
19f6cbc156 Unit test cleanups. Fixes tests so they don't leave left over entries in the database. Add a
check to ensure that row counts in most tables are unchanged from the start and end of the
tests. Refactor some code.
2007-07-26 03:47:34 +00:00
Alexander Nicolaysen Sørnes
0b979fee68 Add return value to maintainer::delete() 2007-07-24 21:52:55 +00:00
Chris Morgan
33faa569eb Clean up database creation to create the mysql interface user and grant permissions. Group
database setup together so the user is prompted for only a couple of times during
initialization.
2007-07-24 21:49:23 +00:00
Alexander Nicolaysen Sørnes
b127c30f1c Fix rating colors in testData table, set the class, not the style. 2007-07-24 14:45:23 +00:00
Alexander Nicolaysen Sørnes
0e7e7a0f2b Fix version list to display missing tested release field 2007-07-24 01:50:19 +00:00
Alexander Nicolaysen Sørnes
c9d7873b29 Return users to the submit page after logging in. 2007-07-24 01:49:40 +00:00
Edwin Smulders
023ece493b Eliminate some php notices caused by use of uninitialized variables 2007-07-24 01:45:19 +00:00
Chris Morgan
f961187287 Switching from timestamp to datetime means we have to specify the time we want stored in the
field. In any case we want to be explicit so specify 'NOW()' for the timestamp/datetime field.
2007-07-24 01:35:30 +00:00
Edwin Smulders
d0a45fe550 Switch to using $_SERVER variables from what appears to be deprecated super globals 2007-07-24 00:30:04 +00:00
Chris Morgan
54ebcc2af8 Create a new TableRow() so we aren't adding entries to a previously used TableRow 2007-07-23 22:03:02 +00:00
Chris Morgan
b62db6340b Add TableRow::SetValign() and add its output to TableRow::GetString() 2007-07-23 22:01:34 +00:00
Edwin Smulders
1199fd1dd5 Make searches use words as keywords 2007-07-23 21:00:37 +00:00
Chris Morgan
087697376f Fix testData submission where the tested version is missing due to switching from a function
that previously echoed data out to one that returns the string for the caller to optionally
echo. The lack of echoing meant the version list html wasn't being output.
2007-07-23 20:45:22 +00:00
Chris Morgan
5c42860972 Add check for empty tested ratings to the conditions upon which we will skip trying to color
using the tested rating. Remove two unused variables.
2007-07-23 20:39:49 +00:00
Chris Morgan
fd448b96d7 Fix appData objectGetTableRow() to work with the new table classes 2007-07-23 20:30:57 +00:00
Edwin Smulders
477c5efb72 Fix a &nbsp; that had a missing ; in the page selector code 2007-07-23 20:15:21 +00:00
Alexander Nicolaysen Sørnes
1678c38c25 Fix testData::objectGetEntriesCount() for queued maintainers. Same fix was applied to
testData::objectGetEntries()
2007-07-23 20:02:24 +00:00
Chris Morgan
2652e68d01 Programmatic table support. Enhances several tables with highlightable and clickable rows and
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Edwin Smulders
8c2959494d Hide RESOLVED and CLOSED bugs unless we are displaying all bugs. 2007-07-22 00:49:15 +00:00
Edwin Smulders
1fe90a6ed5 Queued test results shouldn't be visible to maintainers of an application family or version
that are themselves still queued. Add where condition that 'appMaintainers.queued = 'false''.
2007-07-21 23:58:06 +00:00
Chris Morgan
f08ae29f58 Split maintainer::notifyMaintainerOfQueuedData() into two parts.
maintainer::fetchNotificationUpdate() that retrieves much of the email to the maintainer and
the target notification level, and maintainer::processNotificationUpdate() that acts on the
target notification level and completes and optionally sends the email to the maintainer. Add
admin/maintainerNotification.php to aid in debugging the notification system.
2007-07-21 23:49:36 +00:00
Edwin Smulders
5a5383515c Hide resolved bugs by default, add link to toggle between hiding resolved bugs and showing all
bugs.
2007-07-21 23:32:10 +00:00
Chris Morgan
b5a41fba77 Add the long awaited 'maintainer notification' system. This system, running from the cron
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
1f7298eb24 Screenshots were incorrectly displaying 'Delete Image' links when the user had no permission to
do so. Bug was that the version id used for User::isMaintainer() was 0, which caused
Maintainer::isUserMaintainer() to return true if the user was a maintainer of any application.
Switch to using the version id of the screenshot image being displayed and cache the value to
reduce database queries. Also switch to using prefixed naming for a variable that wasn't.
2007-07-17 04:44:17 +00:00
Chris Morgan
b0cecaf9d5 objectManager::display_table() should exit out only if the user isn't logged in AND the table
is a queue
2007-07-16 03:04:54 +00:00
Chris Morgan
88a832199d Implement browsing of newest apps in the object manager infrastructure 2007-07-16 03:04:07 +00:00
Chris Morgan
7c76ba42eb Color versions when displaying the version table on the application page. Add dynamic
highlighting and the ability to click on the row in the version table.
2007-07-12 23:58:00 +00:00