Commit Graph

263 Commits

Author SHA1 Message Date
EA Durbin
d1c037e0ae Make the case of 'Version' match the case used in the constructor 2006-08-31 02:39:09 +00:00
EA Durbin
320b8c0d82 Make the case of 'Application' class match the case used to define the class. Php doesn't care but its a nice touch. 2006-08-30 22:27:07 +00:00
Chris Morgan
cef2aec209 Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
240a241a54 Use require() instead of include() because we can't operate properly if we can't find all listed include files 2006-07-21 04:24:59 +00:00
Chris Morgan
9364f5bc5a Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
of the distribution class
2006-07-21 04:21:04 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
04e7fa9906 Rename include/testResults.php to include/testData.php to match the name of the class
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
4db25a90ad Add a 'back' link at the top of the page. Switch to using html_back_link() to keep the displayed text
uniform, we were missing the '<<' before 'Back'
2006-07-11 03:39:18 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Tony Lambregts
dab95ccdb1 Fix spelling of iPage in redirect 2006-07-09 22:57:44 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Tony Lambregts
0cf64d78e0 Fix moving version to existing application, variable wasn't prefixed correctly 2006-07-08 22:45:40 +00:00
Chris Morgan
95cb27dc69 Fix variable naming in adminMaintainerQueue.php to match the current naming convention 2006-07-08 22:12:08 +00:00
Chris Morgan
763ad58bcf Move function in include/comment.php inside of the comment class. This lets us refer to
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
2092d65827 Fix incorrect include, should be 'bugs.php' not 'bug.php' 2006-07-08 19:03:38 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
e56e95d63a Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function 2006-07-07 16:44:41 +00:00
Chris Morgan
ea02b57c25 Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
91b44a3733 Cleanup note editing. Improve previewing of notes during addition and editing. Rename note related
variables to have the proper prefix.
2006-06-30 19:48:33 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Jonathan Ernst
c138da9766 Html attributes and values are lowercase to be forward compatible with xhtml 2006-06-27 16:54:22 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
3a3ff401cc Fix case of 'Submit' to fix creating a new distribution 2006-06-23 05:03:03 +00:00
Chris Morgan
540a29cb5e Fix editing bundles, they've been broken since appdb was imported into cvs and we haven't noticed, ha 2006-06-23 03:42:08 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
EA Durbin
d8a459af17 Eliminate the use of the undefined testResult() class and correcting spelling of testData. 2006-06-20 23:00:01 +00:00
Tony Lambregts
ca3fca2e0a Fix up administrating app queue, add missing '[' 2006-06-18 04:22:43 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
a088778a85 Get rid of redundant include to fix adminCommentView.php 2006-06-14 14:57:23 +00:00
Tony Lambregts
42b6c87c7b Add a message to the app/version deletion email to clarify deletions due the app/version being moved 2006-04-27 01:44:57 +00:00
Tony Lambregts
647de96f9d Allow moving test results of a queued version to an approved version 2006-04-26 15:12:55 +00:00
Tony Lambregts
2b544fd6b1 Add email reply text to admin test results form. 2006-02-22 02:17:54 +00:00
Tony Lambregts
385a7c2e0d Cleanup deletion and rejection code 2006-02-20 02:53:23 +00:00
Tony Lambregts
602d15cdca Fix deletion of test results when a version is deleted 2006-02-20 02:51:19 +00:00
Tony Lambregts
0192470558 Fix spelling of 'testing' 2006-01-28 23:00:35 +00:00
Tony Lambregts
4aa90c6cf9 Allow administrators to submit app, version and testresults in one step instead of three. Fix minor vendor logic bug. 2006-01-28 22:59:51 +00:00
Tony Lambregts
7714218746 Fix Edit Application Family back link 2006-01-26 01:19:01 +00:00
Tony Lambregts
689f7fcb9d Fix maintainer queue display to correctly display the version of applications 2006-01-23 02:56:31 +00:00
Tony Lambregts
57119ed39a Fix maintainer queue showing the wrong version due to the creation of a Application object instead of a Version object. 2006-01-23 02:12:40 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
60c8b7806a Redirect admin/resubmitRejectedApps.php to appsubmit.php 2006-01-18 04:21:04 +00:00