Alexander Nicolaysen Sørnes
93d71f630a
Prepare for viewing versions using objectManager
2007-09-18 20:38:28 -04:00
Alexander Nicolaysen Sørnes
43e3e6bebc
bug: Let objectManager unqueue bug links
2007-09-17 21:28:03 -04:00
Alexander Nicolaysen Sørnes
74cf6afeb2
bug: Let objectManager delete bug links
2007-09-17 21:27:10 -04:00
Chris Morgan
6671c7c38e
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Let objectManager add bug links.
2007-09-14 23:37:10 -04:00
Chris Morgan
d5cf2375dd
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Use objectManager to delete monitors.
2007-09-14 23:27:36 -04:00
Chris Morgan
82cd3b245b
Create a version instance from $aClean['iVersionId'], if $aClean['iVersionId'] is set. We use
...
this version instance in several sets of logic. Fixes bug 9275.
2007-08-24 03:17:25 +00:00
Chris Morgan
6119246b51
Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
...
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Edwin Smulders
023ece493b
Eliminate some php notices caused by use of uninitialized variables
2007-07-24 01:45:19 +00:00
Alexander Nicolaysen Sørnes
b18a91cca7
Fix typo in monitor creation preventing the userid value from being saved
2007-04-23 23:33:47 +00:00
Chris Morgan
cf9cba4093
Objects should set class variables and call create() instead of passing the parameters into the
...
create() function.
2007-04-21 02:30:22 +00:00
Alexander Nicolaysen Sørnes
89535dbe01
Use objectMakeLink()/Url() in more places
2007-04-03 02:08:44 +00:00
Chris Morgan
b9c59f6361
Remove unused $iAppId parameter from monitor::find()
2007-01-10 01:25:18 +00:00
Chris Morgan
a1a41d6b87
Fix and enable input filtering through include/filter.php
2007-01-04 02:35:01 +00:00
EA Durbin
d526a2a504
Standardize the case of Bug class constructors
2006-09-06 01:43:30 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
07e2dab8f8
Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want
...
classes to depend on $_REQUEST if possible
2006-07-08 22:10:56 +00:00
Chris Morgan
84d3f076f7
Variable is $iAppId, not $appId
2006-07-07 19:24:33 +00:00
Chris Morgan
8303433f3b
Revert filtering changes in appview.php as they impact all of the classes downstream that haven't been updated
2006-07-07 18:50:45 +00:00
Chris Morgan
854df987c6
Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
...
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
0d1a716c11
Enable filtering in appview.php
2006-07-07 04:51:41 +00:00
Jonathan Ernst
3096e63828
Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
...
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
a34058b924
Update the comments in some files
2006-07-06 18:37:34 +00:00
Jonathan Ernst
54c484de8c
Remove unnecessary exit calls after redirect() and util_show_error_page() calls
2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Chris Morgan
5e1cb3f8a9
Cleanup note class, move display of notes into the class. External code creates and calls Note::show() to display the note.
2006-06-29 19:22:26 +00:00
Jonathan Ernst
6d019b918a
Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php
2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc
Clean up application and version classes. Move class related functions into the class as static member functions
2006-06-29 16:07:19 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
67550405c3
Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting.
2006-06-21 01:04:12 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
Chris Morgan
e309c1b44a
Move html output of application and version into the application and version classes
2006-01-29 04:04:46 +00:00
Jason Weisberger
b5d70fc27a
Allow the user to limit or show all of the testing results for a particular version
2006-01-28 22:53:28 +00:00
Chris Morgan
2be058a66d
Check that users can view applications and versions before displaying them. Present an error message if they lack permission. Fixes a bug where we were allowing users to view applications and versions that were rejected.
2006-01-13 03:05:06 +00:00
Tony Lambregts
8bb0882cb2
Don't display queued versions, make the function name more descriptive
2005-10-30 22:27:14 +00:00
Tony Lambregts
8ebccb4f2a
Add test results as part of submitting an application or version
2005-10-28 00:11:35 +00:00
Tony Lambregts
ba6e92d184
Lets users submit application testing results in a uniform and easy to process manner
2005-10-17 03:59:24 +00:00
Tony Lambregts
2311d4d572
Add the ability for user to monitor changes to applications
2005-09-30 01:55:51 +00:00
Tony Lambregts
f5fb26a265
Remove the old bugs.php page, we have a new bug system
2005-09-29 00:20:03 +00:00
Tony Lambregts
dab40bc0e8
Show the application name in the header when viewing versions
2005-07-29 02:02:41 +00:00
Tony Lambregts
0f4d2f07ba
Modify appview so users can view and attach a bug to a version
2005-07-13 01:16:37 +00:00
Chris Morgan
1bde8ef22a
When processing a new version, display a list of the applications existing
...
versions so its easy to determine if the version submission is a duplicate or
is covered by a group entry such as '1.X'.
2005-05-20 02:45:55 +00:00
Chris Morgan
89112c175f
Add a list of things a user should do prior to submitting an
...
application. The hope is to reduce the number of duplicate, incorrect and incomplete
submissions that just end up rejected. Change 'Add Version' to 'Submit new
version' to match the 'Submit application' link in the menu panel.
2005-05-14 00:43:33 +00:00
Jonathan Ernst
52cb9f9344
Fix application web page link in appview.php
2005-02-21 01:41:02 +00:00
Jonathan Ernst
7dcde75116
Show latest tested wine release in appview
2005-02-21 01:35:53 +00:00
Jonathan Ernst
b103c6651d
Allow supermaintainers to edit notes
2005-02-19 01:23:02 +00:00
Jonathan Ernst
42f0ceca42
Don't show queued apps and versions
2005-02-19 01:21:14 +00:00
Jonathan Ernst
73ad961a85
Fix version deletion
2005-02-19 01:19:07 +00:00
Jonathan Ernst
7d2505777f
Show supermaintainers names in version's page
2005-02-17 01:01:01 +00:00
Jonathan Ernst
045679d5bb
Re-allow supermaintainers to edit versions
2005-02-17 00:59:31 +00:00
Jonathan Ernst
f5e76d5d48
- fix 1 error reported by the w3c html validator in appview.php?appid=whatever when there are notes
...
- fix 1 error reported by the w3c html validator in appdbStats.php
2005-02-14 18:22:04 +00:00