Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Chris Morgan
fad9278013
Stop using compile_update_string(). compile_update_string() can be passed a value that includes a character considered
...
special by query_parameters(). We then use the output from compile_update_string() as a part of the first
parameter to query_parameters(), the format string. Having extra special characters causes a token mismatch
and query_parameters() will reject the queries entirely. Remove now unused compile_update_string().
2006-07-04 03:43:06 +00:00
Chris Morgan
a044596c31
Add in missing & between url parameters
2006-07-04 02:24:56 +00:00
Chris Morgan
a72f31e11a
Rename some variables to match our current naming scheme
2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a
Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php
2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc
Clean up application and version classes. Move class related functions into the class as static member functions
2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e
Cleanup User class. Move user related functions into class as static member functions
2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
ac5b4b0a95
Warn if magic quotes is enabled and explain a bit about why we require that magic quotes
...
be disabled. Also remove all of the conditional code that was working around cases where
we had magic quotes enabled. We were only working around a small portion of cases where magic
quotes was affecting the appdb.
2006-06-26 00:44:44 +00:00
Chris Morgan
fb0f3b5dd3
Protect against sql injection attacks in sql INSERT statements
2006-06-24 04:20:32 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
Alexander Nicolaysen Sørnes
270ea39bc9
Make the use of capitalization in the Application Form more consistent
2006-05-04 00:23:39 +00:00
Alexander Nicolaysen Sørnes
300ad22e4b
When vendor changes display before and after vendors instead of displaying the before vendor
...
twice.
2006-04-16 16:33:41 +00:00
Tony Lambregts
092487fe91
Cleanup email code
2006-02-22 02:20:02 +00:00
Chris Morgan
e309c1b44a
Move html output of application and version into the application and version classes
2006-01-29 04:04:46 +00:00
Tony Lambregts
767faeac75
Application class fixes. Let update be silent when we want it to be. Get rid of redundant message in unqueue(). Fix logic in SendNotificationMail().
2006-01-28 23:04:21 +00:00
Tony Lambregts
33302f72ef
Make back link in rejection emails point to appsubmit.php
2006-01-18 04:32:28 +00:00
Chris Morgan
369b40b046
Fix SendNotificationEmail() so it appends to the existing message in the 'edit' case instead of overwriting the message passed in
2005-12-05 04:19:14 +00:00
Tony Lambregts
8ebccb4f2a
Add test results as part of submitting an application or version
2005-10-28 00:11:35 +00:00
Chris Morgan
696aab7ad8
Retrieve versions for an application based on the users permissions
2005-10-26 23:54:43 +00:00
Chris Morgan
89abe706dc
Improve permission checking in objects, fix some initialization bugs
2005-10-26 02:09:49 +00:00
Chris Morgan
657167e8a5
Move hidden fields used by application and version class into their OutputEditor() member functions. Fix broken old style calls to application and version update() functions that were passing parameters in. Fix broken application::CheckOutputEditorInput()
2005-10-16 04:24:37 +00:00
Chris Morgan
49300a8707
Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings.
2005-10-10 02:37:55 +00:00
Chris Morgan
a5fbfe5830
Improve application rejection email so the user knows that they can modify and resubmit the application
2005-10-01 00:31:47 +00:00
Tony Lambregts
2311d4d572
Add the ability for user to monitor changes to applications
2005-09-30 01:55:51 +00:00
Tony Lambregts
65c5e0e4b3
Fix bug in the rejection of versions that was only sending the maintainers the url to the requeued application if there was a rejection reason given. Add url to requeued application to rejected applications.
2005-09-21 01:26:10 +00:00
Tony Lambregts
b7f1d55472
Allow maintainers/administrators to reject an application submission instead of just deleting it
2005-08-15 03:44:03 +00:00
Chris Morgan
639dd77d15
Let maintainers and super maintainers process the application versions and images submitted for applications they maintain
2005-08-05 22:07:41 +00:00
Tony Lambregts
c7d6988d4f
Fix backlink to application/version when sending email
2005-07-13 03:44:38 +00:00
Chris Morgan
6ae3aa98fd
When deleting a version or application the first thing deleted was the version
...
or application. Then each of the sub-objects like comments, notes etc were
deleted. This order is bad because it makes the database inconsistent, we
never want a comment/note/etc for a version that doesn't exist. Delete the
sub objects first and then the parent object.
2005-06-30 01:59:32 +00:00
Chris Morgan
718772d5b3
Close comment correctly.
2005-05-09 22:34:47 +00:00
Chris Morgan
a827db238f
If 'replyText' is set when deleting an application we should include this reply
...
text when emailing the maintainers with the deletion message.
2005-05-09 22:12:19 +00:00
Chris Morgan
44356371ab
Delete maintainers when deleting applications and versions so maintainers aren't
...
orphaned.
2005-05-07 18:45:33 +00:00
Jonathan Ernst
06ea1b6d3d
Security fixes. Ensure that numeric values are actually numeric using is_numeric
...
so users can't login as admin by passing in non-numeric values.
2005-03-23 23:56:38 +00:00
Jonathan Ernst
57223914a0
Fix email sending logic when adding/rejecting applications
2005-02-27 16:45:49 +00:00
Jonathan Ernst
9523066655
Generate a true boolean and not a string so that tests against bqueued don't
...
return true if bqueued="false" instead of false.
2005-02-24 04:49:27 +00:00
Jonathan Ernst
c8a1a0b0df
versions, applications, and screenshots have to be marked queued="false" instead of
...
queued="" when added without being unqueued
2005-02-21 01:37:06 +00:00
Jonathan Ernst
1d8d755ec1
Fix typo that was making it impossible to change an application's name
2005-02-20 01:56:53 +00:00
Jonathan Ernst
25f3f01412
- display the submit time correctly in admin panels
...
- display the submitter correctly in admin panels
2005-02-20 01:55:53 +00:00
Jonathan Ernst
42f0ceca42
Don't show queued apps and versions
2005-02-19 01:21:14 +00:00
Jonathan Ernst
5c5148534d
Record submitter id when queueing apps
2005-02-17 01:18:13 +00:00
Jonathan Ernst
30f8514840
Fix mail were sent without the name of application or version when a new application or version was added
2005-02-11 01:36:24 +00:00
Jonathan Ernst
d9bf5bc528
Improved version and applicaton class, deletes all linked elements
2005-02-11 01:34:16 +00:00
Jonathan Ernst
b516f4a78f
- initialize arrays to avoid error messages when arrays are empty
...
- use correct $this->array and not $array in application class
2005-02-09 23:53:25 +00:00
Jonathan Ernst
df02378f26
- informs interested people about application modification.
...
- tell what changed in the email
- get rid of addslashes and use compile_update_string
2005-02-09 23:49:56 +00:00
Jonathan Ernst
7b12f89abf
- improve application and related classes
...
- use application/version/vendor class in scripts
- don't use a full table for queued appication but only one field in the application and version tables
- simplify the code in many places
2005-02-07 23:21:33 +00:00
Jonathan Ernst
792151c574
- add version and vendor classes
...
- much improved application class (same model as the other new classes I made)
- modified category class
- modified some files to use the new classes and methods
- deletes linked elements on cascade
2005-02-06 17:49:48 +00:00
Jonathan Ernst
cfd1d1ac09
- renamed lookupVersionName and lookupAppName into lookup_version_name and lookup_app_name in respect to CODING_STANDARD
...
- removed appIdToName($appId) and versionIdToName($appId) from category.php
- replaced every occurence of appIdToName and versionIdToName with lookup_app_name and lookup_version_name
2005-02-04 02:59:05 +00:00
Jonathan Ernst
863467667d
Don't use appId in for objects related to appVersion, appVersion implies an
...
appId
2005-02-02 02:39:40 +00:00
Jonathan Ernst
f2258e7ee5
- use htmlarea for editing app description and notes
...
- special stylesheet for application description and notes
- function to display summary of description with html stripping
2005-02-02 02:38:20 +00:00