Commit Graph

26 Commits

Author SHA1 Message Date
Chris Morgan
2827e0654e Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
faf7d9bb19 Add objectGetChildren() method to classes without child objects 2007-09-08 22:29:17 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
19f6cbc156 Unit test cleanups. Fixes tests so they don't leave left over entries in the database. Add a
check to ensure that row counts in most tables are unchanged from the start and end of the
tests. Refactor some code.
2007-07-26 03:47:34 +00:00
Edwin Smulders
023ece493b Eliminate some php notices caused by use of uninitialized variables 2007-07-24 01:45:19 +00:00
Alexander Nicolaysen Sørnes
051a1e5d0c Cleanup objectManager tests so all objects created during the test are deleted 2007-06-19 00:26:21 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
095d228296 Fix app/version rejection. Version queue requeue wasn't requeueing its downloadurl, downloadurl
class was missing objectManager functionality. Rejected appData wasn't being accounted for.
2007-06-09 15:44:46 +00:00
Alexander Nicolaysen Sørnes
cb18a07f60 downloadurl: Add more objectManager functions. Allow us to unqueue queued downloadurls that are
currently stuck in limbo.
2007-05-31 02:40:01 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
982dc97756 Always read input first in downloadurl::outputEditorSingle(). Makes sure changes aren't lost
when reloading the form due to input errors
2007-04-24 23:38:41 +00:00
Alexander Nicolaysen Sørnes
995076af3b Fix warnings in downloadurl::processForm(). Calling this method with inappropriate $aClean[]
data is perfectly valid but in tht case the function should return silently
2007-04-21 19:46:17 +00:00
Chris Morgan
434de30b9c Correct a few undefined variable errors brought out by the unit tests 2007-04-21 01:17:38 +00:00
Alexander Nicolaysen Sørnes
89535dbe01 Use objectMakeLink()/Url() in more places 2007-04-03 02:08:44 +00:00
Chris Morgan
465f5aa58a Code changes to fix issues that appear to affect php4 but not php5 2007-01-18 03:21:27 +00:00
Alexander Nicolaysen Sørnes
8afd6878d8 Allow download urls on version submission 2007-01-18 02:34:19 +00:00
Alexander Nicolaysen Sørnes
917851fceb Fix naming of OutputEditor() to be outputEditor() 2007-01-17 03:18:49 +00:00
Alexander Nicolaysen Sørnes
6bf83a0a3b Add more downloadurl functions and use them in processForm() 2007-01-17 03:16:22 +00:00
Alexander Nicolaysen Sørnes
c71697dc5b Rename downloadurl::editor to OutputEditor for better conformance with other classes 2007-01-16 04:25:56 +00:00
Alexander Nicolaysen Sørnes
ced09a3c9c Fix editing of download URLs caused by a typo in a variable name. 2007-01-07 22:59:31 +00:00
Alexander Nicolaysen Sørnes
558d2e95db Fixes for download URL mails 2007-01-07 20:50:12 +00:00
Alexander Nicolaysen Sørnes
1c0549c7bc Fix removal of download URLs. When checked, bRemove should have a value of "true". 2007-01-07 20:48:45 +00:00
Alexander Nicolaysen Sørnes
af877bfc70 processForm needs to be passed the $aClean array 2007-01-06 01:08:35 +00:00
Alexander Nicolaysen Sørnes
52a155588c Add the ability to add download URLs to application versions. They are
displayed in the version view marked as 'free downloads'.  The links will
later be used to allow browsing of downloadable applications.
2007-01-05 05:20:05 +00:00