Commit Graph

58 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
64f3219c94 Let application::getVersions() optionally return only accepted versions 2008-07-18 11:18:28 -04:00
Alexander Nicolaysen Sørnes
36de1a0d78 screenshots: Add some space between title bars 2008-07-07 22:16:11 -04:00
Jeff Zaroyko
e18e751706 make the screenshot submission rules more noticeable 2008-05-05 23:08:45 -04:00
Jeff Zaroyko
16949bb71c tidy appdb html to make it validate - try 4 2008-02-25 19:27:36 -05:00
Alexander Nicolaysen Sørnes
6df84f1170 Tell the user not to submit screenshots of installers, error messages etc. 2007-10-21 13:06:49 -04:00
Alexander Nicolaysen Sørnes
3e2029a354 screenshot: Use accessor instead of modifying OM property directly 2007-09-30 10:17:31 -04:00
Alexander Nicolaysen Sørnes
2823334eed Use objectManager to delete screenshots 2007-09-27 09:21:21 -04:00
Alexander Nicolaysen Sørnes
715f3af1b3 Fix screenshot submission when an app but no version is selected 2007-09-27 09:20:41 -04:00
Chris Morgan
7a0a47bd1e Remove logic that was preventing the opening of the version frame. The code to open the version
frame also determins if the user maintains the version or not, which decides whether we include
the "Delete Image" link. Change fixes missing "Delete Image" link for maintainers.
2007-08-23 02:33:57 +00:00
Chris Morgan
26fce69f0f Require that users be logged in to submit screenshots. Display a login link on the screenshots
page for users that aren't logged in so they know that if they login they'll be able to submit
screenshots.
2007-08-23 01:48:45 +00:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
1f7298eb24 Screenshots were incorrectly displaying 'Delete Image' links when the user had no permission to
do so. Bug was that the version id used for User::isMaintainer() was 0, which caused
Maintainer::isUserMaintainer() to return true if the user was a maintainer of any application.
Switch to using the version id of the screenshot image being displayed and cache the value to
reduce database queries. Also switch to using prefixed naming for a variable that wasn't.
2007-07-17 04:44:17 +00:00
Chris Morgan
41e90aec46 Properly close all of the html frames we opened with html_frame_start(). Fixes a bug where the
back link appears inside of a frame and the page rendering time appears in an odd red bar at
the bottom of the page
2007-06-16 21:16:12 +00:00
Ben Hodgetts
e666a5c52e Add cropping notice to the screenshot submission page to encourage users to submit screenshots
focused on the application running under wine and not their entire desktop
2007-05-26 17:55:09 +00:00
Alexander Nicolaysen Sørnes
f27a2d8f7d Fix screenshot description for new screenshots. The creation code was using a non-existant
object member variable.
2007-05-26 01:41:44 +00:00
Alexander Nicolaysen Sørnes
3ab921cf0d Add appData/screenshot::mustBeQueued() 2007-04-21 17:49:43 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Chris Morgan
1bdc44a003 Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
005ef5af93 Enable filtering in screenshots.php 2006-07-07 17:06:26 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
a34058b924 Update the comments in some files 2006-07-06 18:37:34 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
6c2ae4a6fe Fix missed lookup_version_name() -> Version::lookup_name() in version cleanup patch 2006-06-29 19:00:41 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
EA Durbin
7d5fe3986d Fix grammatical error 2006-06-06 18:55:04 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Tony Lambregts
a45a1fa869 Refactor screenshots.php to use get_thumbnail() 2005-07-26 03:54:57 +00:00
Jonathan Ernst
1331d33842 Give a useful message to the user when the screenshot size is too big to be accepted 2005-07-14 01:32:26 +00:00
Mitchell Mebane
616b957a61 Make screenshots openable in a new tab 2005-06-28 02:07:06 +00:00
Jonathan Ernst
7b12f89abf - improve application and related classes
- use application/version/vendor class in scripts
- don't use a full table for queued appication but only one field in the application and version tables
- simplify the code in many places
2005-02-07 23:21:33 +00:00
Jonathan Ernst
3ebdbc9af5 - no more appId in appData as appVersion implies an appId*
- screenshot class has been reworked to remove need of appId
- screenshot class has been improved to send e-mails so that email handling can be removed from other scripts
2005-02-04 02:55:50 +00:00
Jonathan Ernst
863467667d Don't use appId in for objects related to appVersion, appVersion implies an
appId
2005-02-02 02:39:40 +00:00
Jonathan Ernst
7ce5895681 - fix notifications
- improves notifications
2005-02-02 00:14:01 +00:00
Jonathan Ernst
c88c28d5d3 limit description of screenshot to 20 chars as we don't display more 2005-01-31 01:42:08 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Paul van Schayck
ec3f0bfe54 Move description below screenshot instead of header 2005-01-30 22:38:44 +00:00
Jonathan Ernst
0a839e359a - use mail_appdb() instead of mail() for better error handling and to avoid code duplication
- use \r\n as line separator in mail (RFC compliant)
2005-01-30 00:57:34 +00:00
Jonathan Ernst
d5a50ecec4 * new screenshot and image classes 2005-01-27 15:42:53 +00:00
Jonathan Ernst
caf91fded2 remove all mysql_error() instances as errors are handled by query_appdb() 2005-01-14 05:34:25 +00:00
Jonathan Ernst
d3ad0dba41 - replaced mysql_query() with query_appdb()
- removed opendb()
- removed query_userdb()
- removed error handling from the code as it is done with query_appdb()
2005-01-12 16:22:55 +00:00
Jonathan Ernst
d9826427da This patch make email address the user's username as requested in the TODO.
query_users.php is modified even if we will drop it in the future to be sure it works everywhere.
2005-01-10 22:54:04 +00:00
Jonathan Ernst
dfec5cb9b0 Replaced mysql_query() with query_appdb() 2005-01-10 22:24:15 +00:00
Francois Gouget
8fab7880b4 Assorted spelling fixes.
Small wording tweaks.
Capitalize Wine when referring to the project.
2005-01-10 22:15:44 +00:00
Eric Blade
ffeeaef807 Clean up HTML and PHP, remove extranious checks for loggedin() 2004-12-29 20:21:31 +00:00
Jonathan Ernst
099a172b00 Fix header patch typo 2004-12-27 23:54:55 +00:00
Jonathan Ernst
f5741ea108 Uniform headers 2004-12-25 20:08:00 +00:00
Jonathan Ernst
52437f5f30 - use queued screenshot directory instead of mysql to store queued data
- use the config file to determine thumbnail size
2004-12-23 01:13:26 +00:00
Chris Morgan
77a038d4f9 Remove isMaintainer() and isSuperMaintainer and instead use the user
classes is_maintainer() and is_super_maintainer.
2004-12-19 19:30:27 +00:00