Commit Graph

70 Commits

Author SHA1 Message Date
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Alexander Nicolaysen Sørnes
582ee561fc If the admin tries to view an application that does not exist, print an error
and exit instead of fetching useless data as though there actually was an
application.
2007-01-04 00:43:58 +00:00
Chris Morgan
04e7fa9906 Rename include/testResults.php to include/testData.php to match the name of the class
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Tony Lambregts
0cf64d78e0 Fix moving version to existing application, variable wasn't prefixed correctly 2006-07-08 22:45:40 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
EA Durbin
d8a459af17 Eliminate the use of the undefined testResult() class and correcting spelling of testData. 2006-06-20 23:00:01 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
42b6c87c7b Add a message to the app/version deletion email to clarify deletions due the app/version being moved 2006-04-27 01:44:57 +00:00
Tony Lambregts
647de96f9d Allow moving test results of a queued version to an approved version 2006-04-26 15:12:55 +00:00
Tony Lambregts
385a7c2e0d Cleanup deletion and rejection code 2006-02-20 02:53:23 +00:00
Tony Lambregts
4aa90c6cf9 Allow administrators to submit app, version and testresults in one step instead of three. Fix minor vendor logic bug. 2006-01-28 22:59:51 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
3efdcb188c Fix merging of versions into existing applications 2005-11-12 03:06:55 +00:00
Tony Lambregts
8bb0882cb2 Don't display queued versions, make the function name more descriptive 2005-10-30 22:27:14 +00:00
Tony Lambregts
8ebccb4f2a Add test results as part of submitting an application or version 2005-10-28 00:11:35 +00:00
Chris Morgan
657167e8a5 Move hidden fields used by application and version class into their OutputEditor() member functions. Fix broken old style calls to application and version update() functions that were passing parameters in. Fix broken application::CheckOutputEditorInput() 2005-10-16 04:24:37 +00:00
Chris Morgan
485f935660 Updates for changes to application and version classes update() functions 2005-10-11 02:16:00 +00:00
Chris Morgan
49300a8707 Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings. 2005-10-10 02:37:55 +00:00
Chris Morgan
0aa7f26249 Switch from using htmlarea to using xinha. Clean up the use of the editor plugin 2005-09-30 02:48:33 +00:00
Tony Lambregts
b7f1d55472 Allow maintainers/administrators to reject an application submission instead of just deleting it 2005-08-15 03:44:03 +00:00
Tony Lambregts
fa79ae006e Stop displaying winzip when a new vendor is submitted 2005-08-14 15:34:58 +00:00
Tony Lambregts
92d613a5a8 Use the correct spelling/capitalization for sKeywords 2005-08-14 15:21:28 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Chris Morgan
41c55dbfa2 Delete version before application, otherwise the version has no parent
application.
2005-06-30 22:51:28 +00:00
Chris Morgan
bcfd89e6f6 Fix htmlarea windows on the adminAppQueue page 2005-06-23 00:10:03 +00:00
Chris Morgan
9bc38cb89f Use distinct names for the textarea fields. 2005-06-21 00:45:28 +00:00
Chris Morgan
4d38ddc8a2 When processing an application we should display the version information as
well as the application information. Often the application is accepted only
to discover that the version description contains no testing information. If
this was known earlier both the application and version could have been
rejected. Add support for duplicate merging by clicking on one of the
applications the submitted app name matched with. Versions are also
displayed so the admin can decide if the version is also a duplicate. This
merge makes the submitted version point at the selected app as its parent and
removes the application submission. This lets admins accept new versions
even if the application submission is a duplicate
2005-06-12 18:48:53 +00:00
Chris Morgan
97513244c4 Admin app queue page was only displaying like matches for a submitted app.
Factor like and fuzzy searches out in to a function and call that function
from normal search and from the app queue page so admins see fuzzy matches
for submitted apps.
2005-06-08 00:35:30 +00:00
Chris Morgan
5682efdf2b Use the version submission time for versions and not the application the version was submitted for. 2005-06-04 00:04:36 +00:00
Chris Morgan
0b62de90f0 We correctly check for a non-null email address but then use a completely
different object that doesn't exist when displaying the email address, looks
like a copy/paste typo.
2005-05-21 03:08:21 +00:00
Chris Morgan
1bde8ef22a When processing a new version, display a list of the applications existing
versions so its easy to determine if the version submission is a duplicate or
is covered by a group entry such as '1.X'.
2005-05-20 02:45:55 +00:00
Chris Morgan
5f6053ab41 When processing an application automatically perform a search of the
database for the application name and display a table at the top of the
page. This makes it easier to determine if the submission is a duplicate.  Remove
obsolete comments for admins.  Add a 'back' link to the top of the page
to make it easier to go back without scrolling to the bottom of the page.
2005-05-14 00:42:25 +00:00
Chris Morgan
694fc5d561 Delete the matching version submission when deleting an application submission.
Otherwise we will orphan the version submission and it will remain queued but won't
be visible because there is no application to link it to anymore.
2005-05-07 04:14:19 +00:00
Jonathan Ernst
57223914a0 Fix email sending logic when adding/rejecting applications 2005-02-27 16:45:49 +00:00
Jonathan Ernst
3cf9a144ee Description and webpage were not saved in admin app queue 2005-02-20 01:57:27 +00:00
Jonathan Ernst
25f3f01412 - display the submit time correctly in admin panels
- display the submitter correctly in admin panels
2005-02-20 01:55:53 +00:00
Jonathan Ernst
1ef6eeae88 Select the right application family in adminappqueue 2005-02-19 01:19:43 +00:00
Jonathan Ernst
73c7044a10 Make admin panels look consistant (same column name and order, editing
links in the last column, etc.)
2005-02-09 02:22:20 +00:00
Jonathan Ernst
e7db4f1cac Fix unqueueing new versions 2005-02-09 02:17:31 +00:00
Jonathan Ernst
7b12f89abf - improve application and related classes
- use application/version/vendor class in scripts
- don't use a full table for queued appication but only one field in the application and version tables
- simplify the code in many places
2005-02-07 23:21:33 +00:00
Jonathan Ernst
cfd1d1ac09 - renamed lookupVersionName and lookupAppName into lookup_version_name and lookup_app_name in respect to CODING_STANDARD
- removed appIdToName($appId) and versionIdToName($appId) from category.php
- replaced every occurence of appIdToName and versionIdToName with lookup_app_name and lookup_version_name
2005-02-04 02:59:05 +00:00