Chris Morgan
a1a41d6b87
Fix and enable input filtering through include/filter.php
2007-01-04 02:35:01 +00:00
Alexander Nicolaysen Sørnes
b6c06391c3
If the admin has not modified the field for a personalized response to a
...
maintainer application, do not include it in the e-mail sent to the user.
2006-12-30 06:15:33 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
0b9a5b4e94
Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
...
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
95cb27dc69
Fix variable naming in adminMaintainerQueue.php to match the current naming convention
2006-07-08 22:12:08 +00:00
Chris Morgan
854df987c6
Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
...
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
e56e95d63a
Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function
2006-07-07 16:44:41 +00:00
Chris Morgan
ea02b57c25
Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
...
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828
Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
...
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c
Remove unnecessary exit calls after redirect() and util_show_error_page() calls
2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Jonathan Ernst
6d019b918a
Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php
2006-06-29 16:13:35 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
67550405c3
Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting.
2006-06-21 01:04:12 +00:00
Tony Lambregts
ca3fca2e0a
Fix up administrating app queue, add missing '['
2006-06-18 04:22:43 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
Tony Lambregts
689f7fcb9d
Fix maintainer queue display to correctly display the version of applications
2006-01-23 02:56:31 +00:00
Tony Lambregts
57119ed39a
Fix maintainer queue showing the wrong version due to the creation of a Application object instead of a Version object.
2006-01-23 02:12:40 +00:00
Chris Morgan
db1f434d6f
Create a version instead of an application from $ob->versionId
2005-10-31 01:29:37 +00:00
Chris Morgan
978014cf88
Fix maintainer name display when processing maintainer queue. Code
...
was assuming the returned values were arrays when they were in fact
just a single value, copy paste bug from another set of code.
2005-08-01 00:39:07 +00:00
Chris Morgan
cc912964d6
Move some maintainer code into user class, don't let a user maintain
...
the same app more than once
2005-07-31 17:53:11 +00:00
Jonathan Ernst
25f3f01412
- display the submit time correctly in admin panels
...
- display the submitter correctly in admin panels
2005-02-20 01:55:53 +00:00
Jonathan Ernst
99ec3e804d
Improve existing vendor admin
2005-02-07 23:55:03 +00:00
Jonathan Ernst
fa98124783
Fix "be a (super)maintainer" which was leading to a fatal error
2005-02-07 04:31:26 +00:00
Jonathan Ernst
cfd1d1ac09
- renamed lookupVersionName and lookupAppName into lookup_version_name and lookup_app_name in respect to CODING_STANDARD
...
- removed appIdToName($appId) and versionIdToName($appId) from category.php
- replaced every occurence of appIdToName and versionIdToName with lookup_app_name and lookup_version_name
2005-02-04 02:59:05 +00:00
Jonathan Ernst
2083bf521b
- OO version of user class
...
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
0a839e359a
- use mail_appdb() instead of mail() for better error handling and to avoid code duplication
...
- use \r\n as line separator in mail (RFC compliant)
2005-01-30 00:57:34 +00:00
Jonathan Ernst
d3ad0dba41
- replaced mysql_query() with query_appdb()
...
- removed opendb()
- removed query_userdb()
- removed error handling from the code as it is done with query_appdb()
2005-01-12 16:22:55 +00:00
Jonathan Ernst
d9826427da
This patch make email address the user's username as requested in the TODO.
...
query_users.php is modified even if we will drop it in the future to be sure it works everywhere.
2005-01-10 22:54:04 +00:00
Eric Blade
ffeeaef807
Clean up HTML and PHP, remove extranious checks for loggedin()
2004-12-29 20:21:31 +00:00
Tony Lambregts
66fd2105c0
Make the queue list show, after entering a maintainer. Also change the
...
message to "The maintainer was successfully added into the database".
2004-12-16 02:46:36 +00:00
Jonathan Ernst
dd61058e60
- replaced global vars with superglobals equivalent
2004-12-14 02:35:16 +00:00
Jonathan Ernst
d3d9e853d9
- replaced tons of tabs with spaces
...
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
Chris Morgan
3fa8a3bd7a
Add support for application wide maintainers, super maintainers, that are
...
maintainers for all versions of a particular application.
2004-12-10 00:18:01 +00:00
Chris Morgan
fad6d49ae1
Send maintainer response emails like we should
2004-11-17 23:03:32 +00:00
Chris Morgan
c81eebd949
add support for application maintainers
2004-11-09 22:41:18 +00:00