Commit Graph

58 Commits

Author SHA1 Message Date
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Chris Morgan
04e7fa9906 Rename include/testResults.php to include/testData.php to match the name of the class
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
8b579bc715 Use Version::showList() instead of ShowVersionList() 2006-07-07 17:27:23 +00:00
Chris Morgan
85b4981a30 Revert filtering in appsubmit, this requires a TON of other changes and we'll want to wait until
every other change goes in before appling this change
2006-07-07 17:24:57 +00:00
Jonathan Ernst
3c4191314a Enable filtering in appsubmit.php 2006-07-07 17:19:53 +00:00
Jonathan Ernst
b76c6d3522 Add documentation to appsubmit.hp 2006-07-07 16:07:29 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Jonathan Ernst
e41dd3b733 Fix typo in appsubmit 2006-06-29 16:39:14 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
c31173ef9e Disable hackish looking "we've got errors message" since we'll display human readable errors later on. 2006-06-24 04:07:42 +00:00
EA Durbin
4b0f0473f7 class testResult() doesn't exist, include/testResults.php is the name but the class is testData. Correct spelling of
testData().
2006-06-20 04:05:55 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Alexander Nicolaysen Sørnes
f7671e9d2a Language improvements. Also make the use of language more consistent. 2006-05-04 00:22:32 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
7fb18a00fb Fix appsubmit to display versions for resubmission by calling the correct function 2006-01-18 04:18:56 +00:00
Tony Lambregts
b587dbfd17 Only create new distributions if the user didn't pick one from the dropdown menu. Previous behavior would create a new distribution if any text was present in the 'distribution' textbox, even if a distribution is picked from the dropdown menu. 2006-01-17 02:33:14 +00:00
Chris Morgan
91fe4dd26c Fix two bugs found after upgrading to php5 2005-11-12 04:37:48 +00:00
Tony Lambregts
8ebccb4f2a Add test results as part of submitting an application or version 2005-10-28 00:11:35 +00:00
Chris Morgan
657167e8a5 Move hidden fields used by application and version class into their OutputEditor() member functions. Fix broken old style calls to application and version update() functions that were passing parameters in. Fix broken application::CheckOutputEditorInput() 2005-10-16 04:24:37 +00:00
Chris Morgan
eb732e31f2 Don't let the user change the parent application when a new version is being submitted, they got to the submit version screen through an application parent, we should stick with that 2005-10-14 00:31:42 +00:00
Chris Morgan
49300a8707 Factor application/version editing code out of files and move it into the application and version classes. Add support to HtmlAreaLoaderScript() to be called multiple times on a single page without generating javascript that overwrites the previous html area settings. 2005-10-10 02:37:55 +00:00
Chris Morgan
c680ea8b4f Fix Xinha control on submit new version page. We should only create a 'editor2' control for a new version as only the 'editor2' textarea is created for new versions. 2005-10-03 23:16:41 +00:00
Chris Morgan
0aa7f26249 Switch from using htmlarea to using xinha. Clean up the use of the editor plugin 2005-09-30 02:48:33 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Tony Lambregts
32786350ad Redisplay the input form and display the errors there instead of an error page so the user doesn't lose any of the data they've already input. 2005-06-29 03:01:08 +00:00
Chris Morgan
89112c175f Add a list of things a user should do prior to submitting an
application.  The hope is to reduce the number of duplicate, incorrect and incomplete
submissions that just end up rejected.  Change 'Add Version' to 'Submit new
version' to match the 'Submit application' link in the menu panel.
2005-05-14 00:43:33 +00:00
Jonathan Ernst
d4bde62c23 Use htmlarea when submitting a new version 2005-03-16 03:39:34 +00:00
Jonathan Ernst
3b4eb09e1f Use only one htmlarea as using two cause one of them to be sometimes readonly
under Gecko for unknown reasons.
2005-02-24 04:48:04 +00:00
Jonathan Ernst
aed4745aef Fix html issues 2005-02-23 00:15:30 +00:00
Jonathan Ernst
5e7cceeb4a - makes it possible to submit new versions again
- show the add version button when logged in
2005-02-09 02:19:24 +00:00
Jonathan Ernst
7b12f89abf - improve application and related classes
- use application/version/vendor class in scripts
- don't use a full table for queued appication but only one field in the application and version tables
- simplify the code in many places
2005-02-07 23:21:33 +00:00
Jonathan Ernst
ac0994cc53 - use htmlarea when submitting a new version or application
- use htmlarea when reviewing a new version or application
- don't let admin try to add keywords or webpage to an application version
- improved templates and stylesheet to don't break appdb layout
2005-02-02 04:11:41 +00:00
Jonathan Ernst
e18c28db71 Retrieve email from current user object 2005-02-02 00:18:59 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
29f5bddee3 use APPDB_OWNER_EMAIL instead of appdb@winehq.org 2005-01-30 03:12:57 +00:00
Francois Gouget
8fab7880b4 Assorted spelling fixes.
Small wording tweaks.
Capitalize Wine when referring to the project.
2005-01-10 22:15:44 +00:00
Tony Lambregts
9ee1cb968a Fix up vendor when submitting app. 2005-01-10 22:09:28 +00:00
Paul van Schayck
05ea902ad5 Use include/db.php. Variable naming. isset() 2004-12-30 16:29:27 +00:00
Eric Blade
ffeeaef807 Clean up HTML and PHP, remove extranious checks for loggedin() 2004-12-29 20:21:31 +00:00
Paul van Schayck
4e2c7b2106 Make version submit from appview parent filling work again. Remove other non used value fillers. 2004-12-28 00:03:27 +00:00
Paul van Schayck
5a27f7ba35 Array keys should be quoted 2004-12-18 01:51:56 +00:00
Jonathan Ernst
d3d9e853d9 - replaced tons of tabs with spaces
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
WineHQ
ac0fc5bd6d Authors: Jonathan Ernst <Jonathan@ernstfamily.ch>, Chris Morgan <cmorgan@alum.wpi.edu>
- stop annoymous applications submitions
- code cleanup (more php style than c style  + correct indentation + comments + replaced globally registered vars)
2004-12-11 03:59:45 +00:00