Commit Graph

54 Commits

Author SHA1 Message Date
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
4a41fcdbea If a person deletes a screenshot he has submitted himself, don't send him an
extra email about it.
2006-12-27 03:23:01 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
EA Durbin
e303923dea Standardize all Image constructors to match the case defined in the Image class 2006-09-06 01:42:25 +00:00
Chris Morgan
1bdc44a003 Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
2976ff9833 Fix centering of screenshot images on application/version pages 2006-07-19 00:54:56 +00:00
Jonathan Ernst
a4e384604b Fix missing reply text by renaming replyText to sReplyText 2006-07-13 18:54:10 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Jonathan Ernst
aefbc1bf90 Fix showing of full size screenshots 2006-07-07 16:25:43 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Tony Lambregts
ff97ddef7d Fix screenshot display by using the image class member functions instead of class internal private variables 2006-07-04 02:11:09 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
b55c2776a5 Compact the top 'X' lists on the main page by adding a flag to get_screenshot_img() that disables the output of
html that was putting the image inside of another table
2006-06-22 21:41:41 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
EA Durbin
3fba57d0ff Correct the spelling of oThumbnail variable in get_thumbnail() 2006-05-04 00:03:47 +00:00
Tony Lambregts
df12143558 Fix display of no_screenshot.png image when there is no screenshot 2005-08-07 02:32:43 +00:00
Chris Morgan
3a5b5f38da Use the correct object variables when printing acceptance/rejection emails so the application and version are actually displayed 2005-08-06 02:42:09 +00:00
Chris Morgan
639dd77d15 Let maintainers and super maintainers process the application versions and images submitted for applications they maintain 2005-08-05 22:07:41 +00:00
Chris Morgan
f14d6a20ab Use the full path when calling move_uploaded_file() 2005-07-30 16:04:57 +00:00
Tony Lambregts
324ed66eae Fix situation where AppDB is not at DocumentRoot 2005-07-27 02:10:56 +00:00
Tony Lambregts
f8c64330a5 Add a generic function to make a clickable image 2005-07-26 03:53:16 +00:00
Chris Morgan
4ab923935a Remove <br/> tags in screenshot anchor tags, there is an odd space between the screenshot and the text below it that appeared when the image was centered with <center> 2005-06-23 03:00:10 +00:00
Chris Morgan
b601cfef5c Center the screenshot image so it is centered with respect to the text that may appear below it. 2005-06-23 02:28:07 +00:00
Chris Morgan
ebade0ce2d Fix screenshot link text, it wasn't fixed correctly with the last change 2005-06-23 00:30:20 +00:00
Chris Morgan
73736380f7 Only display 'Submit screenshot' text if we are displaying screenshots for a version 2005-06-21 01:27:38 +00:00
Chris Morgan
98732fd75c Make it clear that clicking on the image in the appversion display window is how you submit new screenshots. 2005-06-21 00:57:00 +00:00
Jonathan Ernst
06ea1b6d3d Security fixes. Ensure that numeric values are actually numeric using is_numeric
so users can't login as admin by passing in non-numeric values.
2005-03-23 23:56:38 +00:00
Jonathan Ernst
db7ed9bc5a When sending screenshots in an unknown format (txt, gif, etc.) the user is warned
and the screenshot is not added
2005-02-24 04:48:42 +00:00
Jonathan Ernst
c8a1a0b0df versions, applications, and screenshots have to be marked queued="false" instead of
queued="" when added without being unqueued
2005-02-21 01:37:06 +00:00
Jonathan Ernst
08141e875f Every screenshot of an app were shown when asking for a version-specific screenshot 2005-02-20 01:58:28 +00:00
Jonathan Ernst
412d4756fe - allow supermaintainers to send screenshot without being queued.
- don't let queued have an empty value
2005-02-19 01:22:32 +00:00
Jonathan Ernst
9ff4bc7771 Don't show queued screenshots in appview 2005-02-17 01:16:51 +00:00
Jonathan Ernst
5796ce8f78 Send correct email when the screenshot is unqueued 2005-02-15 18:58:06 +00:00
Jonathan Ernst
124868c0a0 - fix the 25 errors reported by the w3c html validator (http://validator.w3.org) in appview.php?appid=whatever
- fix the 46 errors reported by the w3c html validator in appview.php?versionid=whatever
- fix the 97 errors reported by the w3c html validator in index.php
2005-02-11 23:42:50 +00:00
Jonathan Ernst
e1c1489279 - improve appData and related classes
- don't use a full table for queued appdata but only one field in theapplication and version tables
- simplify the code in many places
- fixes some bugs with screenshots
2005-02-07 23:49:06 +00:00
Jonathan Ernst
fa98124783 Fix "be a (super)maintainer" which was leading to a fatal error 2005-02-07 04:31:26 +00:00
Jonathan Ernst
fa43f93810 Fix screenshots where broken 2005-02-06 22:36:46 +00:00
Jonathan Ernst
b171c02c94 Minor improvements to the screenshot class 2005-02-06 17:47:10 +00:00
Jonathan Ernst
1f6ba40638 - the user was told his screenshot was accepted when it was rejected altough the message title was correct
- the name of original submitter was not quoted in the mail after a screenshot has been unqueued because of a wrong table field selection
2005-02-05 21:49:39 +00:00
Jonathan Ernst
3ebdbc9af5 - no more appId in appData as appVersion implies an appId*
- screenshot class has been reworked to remove need of appId
- screenshot class has been improved to send e-mails so that email handling can be removed from other scripts
2005-02-04 02:55:50 +00:00
Jonathan Ernst
cb710aa5b9 * use move_uploaded_file() instead of rename() 2005-01-27 17:40:09 +00:00
Jonathan Ernst
cf870b4499 * better error message when rename() fails 2005-01-27 17:30:24 +00:00
Jonathan Ernst
d35d02a8a8 * fix a problem with the thumbnail when viewing an app
* optimize watermarking
2005-01-27 17:16:25 +00:00
Jonathan Ernst
6fa71d05a5 * fix the problem with old images that don't have a numeric name 2005-01-27 16:42:41 +00:00