Commit Graph

100 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
176377f025 application: Rename 'queued' to 'state' 2007-12-15 12:24:33 -05:00
Alexander Nicolaysen Sørnes
aee69c1735 version: Rename 'queued' to 'state' 2007-12-15 12:23:16 -05:00
Alexander Nicolaysen Sørnes
6ebd4cfa34 Fix category administration 2007-11-23 23:37:45 -05:00
Alexander Nicolaysen Sørnes
0c47bd87a3 Allow users to view apps with no id 2007-10-23 19:28:23 -04:00
Chris Morgan
6119246b51 Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
93dc3e0396 Add support for mysql versions >=4.0x by adding multiple hash attempts when logging in. We now
attempt sha1(), password() and if mysql >= 4.0x, old_password() hashes. Switch the default user
hash from mysql's password() function to a sha1() hash. Update user::login() to flag logins
with password() and old_password() hashes. If the flag is set we call user::update_password()
to update the users password hash to one generated from the sha1 of the users password. Add a
unit test to test logging in and upgrading from the old hashes.
2007-07-26 14:39:15 +00:00
Alexander Nicolaysen Sørnes
ff46a4485d user: don't make links when userId is not set 2007-05-31 14:55:36 +00:00
Alexander Nicolaysen Sørnes
3dc453112a Use objectManager to list a user's rejected apps 2007-04-22 00:02:30 +00:00
Alexander Nicolaysen Sørnes
b292a84bcf Use version::mustBeQueued() instead of user function 2007-04-21 19:50:52 +00:00
Alexander Nicolaysen Sørnes
2af11e7333 Remove user::deleteAppData() and replace it with an appData function 2007-04-21 19:44:10 +00:00
Alexander Nicolaysen Sørnes
1107fb938b Add and use application::mustBeQueued() 2007-04-21 17:51:42 +00:00
Alexander Nicolaysen Sørnes
a6127c1b07 Rename user::count() to objectGetEntriesCount() for consistency with the other generic
object methods
2007-04-21 17:06:50 +00:00
Alexander Nicolaysen Sørnes
27e0589a77 Remove unused appData functions from the user class 2007-04-21 17:05:54 +00:00
Alexander Nicolaysen Sørnes
ff476b1b13 Use objectmanager to list queued/rejected versions 2007-04-07 20:42:08 +00:00
Alexander Nicolaysen Sørnes
970cbca7f3 Add and use version::objectGetEntriesCount(). Only display the user menu's 'view rejected
apps' link for non-admins
2007-04-04 00:30:42 +00:00
Alexander Nicolaysen Sørnes
fa3872b256 Add user::objectMakeLink(), used by appData and testData objectOutputTableRow() 2007-03-25 16:03:35 +00:00
Alexander Nicolaysen Sørnes
ebb47fedc7 Add and use appData::objectGetEntriesCount() 2007-03-10 21:21:10 +00:00
Alexander Nicolaysen Sørnes
89fa871033 Don't try to email admins multiple times 2007-03-10 03:37:15 +00:00
Alexander Nicolaysen Sørnes
3172aec739 Show oldest queued applications and versions first 2007-01-23 03:21:29 +00:00
WineHQ
b858e2ba53 Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors. 2006-11-25 17:24:44 +00:00
Chris Morgan
cef2aec209 Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
8bdf80982f Fix table name case difference 'Appversion' -> 'appVersion' that was breaking a query 2006-07-16 17:37:23 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Jonathan Ernst
a4e384604b Fix missing reply text by renaming replyText to sReplyText 2006-07-13 18:54:10 +00:00
Chris Morgan
ea02b57c25 Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
81057d13ab Use $GLOBALS['session']->destroy() instead of setting $_SESSION['current'] = "". Using "" means that $_SESSION['current']
could be set but be a string. Don't call addmsg() after logging out otherwise the session message will be lost and can
show up for other users or be stuck in the database
2006-07-06 04:21:04 +00:00
Chris Morgan
2b0d5716bb Move $_SESSION['current'] manipulation into user class. Add user::logout() to keep user::login() and logout() symmetrical 2006-07-06 03:37:49 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
98ba61db03 Clean up user class. Implement start of unit testing framework for appdb.
Implement start of user class unit test.
2006-06-27 03:59:16 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
d38adfedac Fix up inactivity warnings and include login link on inactivity email 2006-03-24 03:20:34 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
488c74dbf0 Users don't have permission to modify application versions if they aren't logged in. 2006-01-19 05:25:52 +00:00
Chris Morgan
8b0a52f782 Add comment to clarify a permissions check 2005-10-30 02:10:36 +00:00
Chris Morgan
2ff66ab389 Simplify and fix User::hasAppVersionModifyPermission() 2005-10-30 02:07:54 +00:00
Tony Lambregts
8ebccb4f2a Add test results as part of submitting an application or version 2005-10-28 00:11:35 +00:00
Chris Morgan
47336e4f8d Fix unknown function isLoggedIn() to be $this->isLoggedIn() 2005-10-26 22:54:30 +00:00
Chris Morgan
89abe706dc Improve permission checking in objects, fix some initialization bugs 2005-10-26 02:09:49 +00:00
Chris Morgan
93ab2587ef Add stats field for users who have been flagged as inactive and are pending deletion 2005-10-15 16:05:03 +00:00
Chris Morgan
f6f935a36e Return true or false from warnForInactivity() depending on whether we warned the user or not, this way we can provide more accurate numbers in the cleanup script summary 2005-10-09 18:33:52 +00:00
Chris Morgan
fa638bd7af hasDataAssociated() is a user internal call, call like $this->hasDataAssociated() instead of hasDataAssociated() 2005-10-09 18:09:35 +00:00
Tony Lambregts
2311d4d572 Add the ability for user to monitor changes to applications 2005-09-30 01:55:51 +00:00
Chris Morgan
a66ae25f38 Move deletion of maintainer logic into the user class. If the cleanup script wants to delete a user and can't, if they are a maintainer we should remove their maintainer status even if we don't delete their account. Send email at the start of the cleanup script to aid in debug 2005-09-30 01:37:57 +00:00
Chris Morgan
1a58863f78 Improve cleanup script to give users 1 month after warning before removing their account. Move user related logic into the user class. Add columns to the user_list table to track whether the user was warned about inactivity and the datetime of the warning. 2005-09-28 00:32:48 +00:00
Chris Morgan
c44f818218 Send notification emails to admins when the cleanup cron job executes so there is some visibility into the maintenance tasks running on the appdb. Fix a minor bug in the user class where passing in (null,null) for iVendorId and iAppId results in a null query string being sent to mysql and triggering an error 2005-09-15 00:22:22 +00:00