Alexander Nicolaysen Sørnes
72a250b2b0
Use objectManager to add and edit notes
2007-09-19 20:38:17 -04:00
Alexander Nicolaysen Sørnes
a6a62a2299
Use objectManager to display versions
2007-09-19 20:37:21 -04:00
Chris Morgan
e82dc74162
Fixes for permission errors introduced by the table permission changes.
2007-09-18 22:09:57 -04:00
Chris Morgan
5c91961d12
Php5 improvements to table code. Add some accessor methods to classes so we can make class variables private.
2007-09-18 21:22:43 -04:00
Alexander Nicolaysen Sørnes
93d71f630a
Prepare for viewing versions using objectManager
2007-09-18 20:38:28 -04:00
Chris Morgan
b2cc871f09
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Use objectManager to create monitors.
2007-09-14 23:31:20 -04:00
Chris Morgan
2827e0654e
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
4d65a32e17
Only show the 'add entry' link if the class has enabled it. The link is only useful for classes
...
that have no parent objects. The objectShowAddEntry() method is not required because it only
affects the user interface.
2007-09-08 22:42:34 +00:00
Alexander Nicolaysen Sørnes
db00c49d73
Add missing div close tag to multipage control
2007-08-25 16:01:58 +00:00
Chris Morgan
6b5305d1bf
Add page selection control at the bottom of pages, without the items per-page selector. Fix
...
objectMananger::handleMultiPageControls() to not display the items per-page selector if
the $bItemsPerPageSelector input parameter is false.
2007-08-24 02:10:23 +00:00
Chris Morgan
13c67aa5e9
Add a 'move children' link to the object editing pages, if we have permission to move the
...
entries
2007-08-22 02:52:08 +00:00
Chris Morgan
242849cc04
Clean up error handling in processForm() to only check for errors when submitting an entry.
...
This enables the deletion or rejection of entries that produce errors. While we can't always
know why errors in objects make it this far we don't want to make it impossible to delete or
reject malformed entries.
2007-08-05 20:14:07 +00:00
Chris Morgan
25c0346ce3
Switch from spaces to to prevent the entries in the processing column from wrapping
2007-08-05 19:26:02 +00:00
Chris Morgan
af3c857f72
Limit the current page to the available pages
2007-08-05 19:02:59 +00:00
Chris Morgan
f9d617dac6
Fix case of object::objectGetId()
2007-08-04 04:52:59 +00:00
Chris Morgan
6119246b51
Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
...
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
0e3472e1bf
objectGetHeader() should return a TableRow instance as this is closer to what the information
...
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Alexander Nicolaysen Sørnes
cd0542a893
Avoid stating 0 as the total page count
2007-07-29 03:51:15 +00:00
Alexander Nicolaysen Sørnes
c9d7873b29
Return users to the submit page after logging in.
2007-07-24 01:49:40 +00:00
Edwin Smulders
023ece493b
Eliminate some php notices caused by use of uninitialized variables
2007-07-24 01:45:19 +00:00
Chris Morgan
fd448b96d7
Fix appData objectGetTableRow() to work with the new table classes
2007-07-23 20:30:57 +00:00
Chris Morgan
2652e68d01
Programmatic table support. Enhances several tables with highlightable and clickable rows and
...
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Chris Morgan
b0cecaf9d5
objectManager::display_table() should exit out only if the user isn't logged in AND the table
...
is a queue
2007-07-16 03:04:54 +00:00
Alexander Nicolaysen Sørnes
403e052a8c
Display login link when processing queues. Display a login link when processing queues and the
...
user isn't logged in, rather than saying that there are no entries.
2007-07-02 01:07:09 +00:00
Alexander Nicolaysen Sørnes
e93f09b0ad
Check for valid result resource before number of rows. objectGetEntries() may return FALSE if
...
the user does not have permission to view a queue, for instance.
2007-07-02 00:50:32 +00:00
Chris Morgan
62bfb16016
Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
...
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
52c0e75af9
Don't display editor for non-existent entries
2007-06-19 00:29:37 +00:00
Alexander Nicolaysen Sørnes
b9588ab76e
Store iPage in handleMultiPageControls(). Fixes the case where an iPage would not be set for
...
page 1, causing iItemsPerPage value to be ignored when returning from data processing
2007-06-16 17:00:57 +00:00
Chris Morgan
80ca144225
Fix a typo in the common response text.
2007-06-16 16:58:54 +00:00
Alexander Nicolaysen Sørnes
5e7a75584a
Remember multipage values when processing entries
2007-06-15 04:10:42 +00:00
Chris Morgan
4078ad879f
Add some common responses to the entry processing page, selectable via radio buttons. This
...
should make admin responses more consistent and make it quicker and easier to process
submissions.
2007-06-14 01:27:59 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7
Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
...
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
945df6a78c
Fix incorrect member variable, its $bIsQueue, not $bIsQueued. Fixes the number of items on a
...
multi-page queue
2007-06-12 01:28:59 +00:00
Chris Morgan
f6a4905d77
Pass a valid $iPageRange into display_page_range(), otherwise display_page_range() behaves
...
improperly
2007-06-12 00:36:29 +00:00
Alexander Nicolaysen Sørnes
ffd812b8a6
Add multi-page control to list of un-queued testData
2007-06-12 00:02:41 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a
Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
...
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
95fc2d366b
Add multi-page support to objectManager, use it for the vendor class
2007-06-09 17:07:02 +00:00
Chris Morgan
25edd78c73
Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
...
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b
Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
...
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
eb49e9344d
Add om method for displaying a move child objects page. A link to this page is displayed in
...
an entry's view page automatically if the class that entry has the required methods
objectMoveChildren and objectGetId
2007-04-27 23:43:43 +00:00
Alexander Nicolaysen Sørnes
ec8312233c
Display add item help text after fetching input values. This allows the help text functions
...
to output help depending on the state of the edited object
2007-04-24 23:40:12 +00:00
Alexander Nicolaysen Sørnes
f688be7c4d
Support silent input checking. checkOutputEditorInput() can now return TRUE instead of a
...
list of errors
2007-04-24 00:35:51 +00:00
Alexander Nicolaysen Sørnes
cf81d542ee
Add a moveChildren method to the objectManager and implement objectMoveChildren for version
...
and version_queue. Use this to move versions.
2007-04-23 23:31:24 +00:00
Chris Morgan
00aacdeadd
Fix some inconsistent braces and add a comment to the objectManager code
2007-04-22 15:52:06 +00:00
Alexander Nicolaysen Sørnes
8cf53f1679
Use mustBeQueued() to determine unqueueing in objectManager
2007-04-22 00:39:53 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17
More fixes and uses for objectManager's version/testData queues
2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
c43563eca6
Fix testData::create() permissions. Separate the cases where a user has edit rights from
...
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
9a953f7ce8
Add return value to objectManager::displayErrors(). Return true if errors were found
2007-04-04 00:32:43 +00:00
Alexander Nicolaysen Sørnes
ac978bfad7
objectManager: check editor values
2007-03-25 18:52:19 +00:00
Alexander Nicolaysen Sørnes
37296b2242
Let objectManager handle rejected testData
2007-03-25 03:56:20 +00:00