ac6d8edca7
2009/10/10 23:51:46 +0100 sbrady: s/Wine/QEMU/, s/AppDB/OS DB/, s/Application/OS/ in text
2014-09-04 05:36:09 +01:00
Alexander Nicolaysen Sørnes
295ff345ba
Misc. capitalization changes
2009-07-29 21:25:38 +02:00
Alexander Nicolaysen Sørnes
e641db3d6c
comment: Prevent accessing some undefined variables
2009-07-24 17:05:28 +02:00
Alexander Nicolaysen Sørnes
e9c4d2ef16
Implement version::objectMoveChildren() on top of version::objectGetChildren()
2009-07-23 02:13:23 +02:00
Alexander Nicolaysen Sørnes
3d75b29129
comment: When deleting a comment, also delete child comments
2009-04-05 14:29:39 +02:00
Alexander Nicolaysen Sørnes
fcfba5a714
Show app names on 'Admin comments' page
2009-04-05 14:29:34 +02:00
Adam Lewis
be6a19f95e
Support for showing a threaded comment reply inline using ajax. Falls back to default if javascript is disabled.
2008-05-31 20:44:39 -04:00
Alexander Nicolaysen Sørnes
f7a1e181cd
Fix typo on comment posting page
2008-03-28 23:56:53 -04:00
Jeff Zaroyko
16949bb71c
tidy appdb html to make it validate - try 4
2008-02-25 19:27:36 -05:00
Alexander Nicolaysen Sørnes
9b92c2221c
Use sState for objectGetEntries[Count]()
2008-01-20 16:13:27 -05:00
Alexander Nicolaysen Sørnes
4297db9786
comment: Add <a name> tag in threaded mode
2008-01-20 16:09:58 -05:00
Alexander Nicolaysen Sørnes
8c7bd3a5e9
Add initial un-delete support
2007-12-18 20:17:06 -05:00
Alexander Nicolaysen Sørnes
eb75246a9e
Fix comments display
2007-11-11 20:50:29 -05:00
Alexander Nicolaysen Sørnes
3aef9df655
comment: Show newest threads first
2007-11-11 15:16:15 -05:00
Alexander Nicolaysen Sørnes
d05ee436f5
comment: Fix possible undefined var in constructor
2007-11-07 00:17:06 -05:00
Alexander Nicolaysen Sørnes
16d212c552
Prevent ids getting lost during editing
2007-10-23 19:30:23 -04:00
Alexander Nicolaysen Sørnes
3a25c64333
comment: Don't allow anonymous submissions
2007-10-23 19:30:00 -04:00
Alexander Nicolaysen Sørnes
d5b029fc61
comment: Set default subject when replying
2007-10-23 19:27:45 -04:00
Alexander Nicolaysen Sørnes
b48221cdd4
comment: Require versionId and message body to be defined
2007-10-22 19:25:36 -04:00
Alexander Nicolaysen Sørnes
9acdadfc34
Use objectManager to add comments
2007-10-21 13:10:35 -04:00
Alexander Nicolaysen Srnes
09d96b79bd
comment: Fix delete permissions
2007-09-17 21:25:57 -04:00
Chris Morgan
2827e0654e
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
5a4cbf49a3
Add and use objectGetChildren() method. Add support for initializing comment class from SQL
...
result.
2007-09-08 22:38:20 +00:00
Alexander Nicolaysen Sørnes
faf7d9bb19
Add objectGetChildren() method to classes without child objects
2007-09-08 22:29:17 +00:00
Chris Morgan
9e05efb1b6
Fix comment::delete() to take $bSilent as an input parameter and use
...
comment::SendNotificationEmail(). Update version::delete() to pass false into comment::delete()
so we don't send an email for each comment we are deleting for a given version. Fixes bug 8473.
2007-08-24 02:52:34 +00:00
Chris Morgan
6119246b51
Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
...
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Edwin Smulders
023ece493b
Eliminate some php notices caused by use of uninitialized variables
2007-07-24 01:45:19 +00:00
Alexander Nicolaysen Sørnes
be52279bfa
Fix comment creation. addcomment.php was passing a filled-in object to comment::create()
...
which still expected values as parameters. Load data from the object instead
2007-04-21 18:05:32 +00:00
Chris Morgan
cf9cba4093
Objects should set class variables and call create() instead of passing the parameters into the
...
create() function.
2007-04-21 02:30:22 +00:00
Alexander Nicolaysen Sørnes
89535dbe01
Use objectMakeLink()/Url() in more places
2007-04-03 02:08:44 +00:00
Alexander Nicolaysen Sørnes
8e6db0334b
Link usernames in comments to the contact form instead of exposing email addresses
2007-03-24 18:36:43 +00:00
Chris Morgan
a1a41d6b87
Fix and enable input filtering through include/filter.php
2007-01-04 02:35:01 +00:00
EA Durbin
683a064cee
Add user.php to includes as comment.php creates a new user.
2006-09-01 02:27:31 +00:00
Chris Morgan
61d338abbd
Comment::grab_comments() should use $iParentId when != NULL, not just !$iParentId as this prevents the use of
...
$iParentId in cases where the value is 0. Fixes duplicate display of every comment for an application version reported by
Nick Law.
2006-07-26 19:30:11 +00:00
Chris Morgan
3f1bfd3685
Attempt to capture the source of erroneous input to grab_comments() using error_log::logBackTrace()
2006-07-20 03:52:02 +00:00
Chris Morgan
f7763bdbfa
Clean up variable naming in grab_comments() , use null instead of -1 for parent ID
2006-07-20 03:19:23 +00:00
Chris Morgan
0a9f8cc155
Performance improvements to version and application classes. Reduce the amount of queries to
...
what is necessary during object creation. The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
763ad58bcf
Move function in include/comment.php inside of the comment class. This lets us refer to
...
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
445fbdfdd3
Switch a few more variables over to the new naming scheme, fix deleting comments and replying to comments
2006-07-06 23:49:51 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Tony Lambregts
55e06eee0c
Remove now unnecessary stripslashes()
2006-07-04 02:12:43 +00:00
Chris Morgan
034ea689bc
Clean up application and version classes. Move class related functions into the class as static member functions
2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e
Cleanup User class. Move user related functions into class as static member functions
2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
fb0f3b5dd3
Protect against sql injection attacks in sql INSERT statements
2006-06-24 04:20:32 +00:00
Chris Morgan
67550405c3
Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting.
2006-06-21 01:04:12 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
Tony Lambregts
7fec72b632
Don't expose users email addresses to robots
2006-06-16 03:18:45 +00:00
Tony Lambregts
fe004f36fa
Add note to use the AppDB to reply to email instead of replying to the email
2006-04-28 00:53:01 +00:00
Tony Lambregts
f6beae01cf
Add tag to comment id and link it to the notification email
2006-03-24 05:01:48 +00:00