Alexander Nicolaysen Sørnes
917851fceb
Fix naming of OutputEditor() to be outputEditor()
2007-01-17 03:18:49 +00:00
Alexander Nicolaysen Sørnes
3883e13c4e
Fix labelling of category in app change mails by changing 'vendor' to 'category'
2007-01-06 18:14:36 +00:00
Chris Morgan
a1a41d6b87
Fix and enable input filtering through include/filter.php
2007-01-04 02:35:01 +00:00
Michael [Plouj] Ploujnikov
5fb6243102
Fix spelling of the email response in include/application.php
2007-01-04 00:36:44 +00:00
Francois Gouget
41fce37200
Assorted spelling fixes
2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
18acb017cd
Add a page showing a user's queued submissions to the AppDB. This should be
...
quite useful for a user, and should also reduce the number of duplicate
submissions, as many users seem to think their submissions have been lost if
they are not accepted within a few hours.
2006-12-27 03:26:16 +00:00
Alexander Nicolaysen Sørnes
8786673db6
Allow the user to tick a checkbox upon application submission, indication
...
whether he would like to become a super maintainer of the application. The
request is processed along with the application. Also add a unit test that
tests maintainer requests submitted along with an application.
2006-12-09 05:07:25 +00:00
Alexander Nicolaysen Sørnes
bdbc9ebec3
The function refers to its own class, so use $this instead of $oApp. Also
...
prevent the application name from being printed twice.
2006-12-09 04:29:20 +00:00
Alexander Nicolaysen Sørnes
f0d89f4ee5
Use $this instead of $oApp since this method is referring to its class
2006-12-08 03:38:27 +00:00
WineHQ
b858e2ba53
Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors.
2006-11-25 17:24:44 +00:00
WineHQ
e1333dd7fc
Include the real name of the user deleting, rejecting and accepting applications and versions
2006-11-22 01:41:36 +00:00
EA Durbin
7532d9091e
Application::countWithRating() and getWithRating() should avoid queued applications. Add unit test
...
to ensure that we don't include queued applications
2006-09-30 01:31:04 +00:00
EA Durbin
d8fe952bb1
Add the ability to browse applications by rating and a unit test for the added Application::getWithRating()
2006-09-27 02:44:16 +00:00
WineHQ
47e7ad72af
Authors: "EA Durbin" <ead1234@hotmail.com>, Chris Morgan <cmorgan@alum.wpi.edu>
...
Application::delete() should retrieve the applications versions immediately prior to deleting to ensure that
an application object created prior to its child versions doesn't leave orphaned versions. Add unit test for
Application::delete() to test for the offending behavior.
2006-09-26 02:05:55 +00:00
EA Durbin
f338b98845
Add missing include of category.php into application.php
2006-08-30 22:24:05 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
1bdc44a003
Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
...
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Jonathan Ernst
a4e384604b
Fix missing reply text by renaming replyText to sReplyText
2006-07-13 18:54:10 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
160f739da8
Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
...
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
d831939a07
Fix case of sWebpage to let updating of application class information correctly update the applications web page.
2006-07-10 23:02:03 +00:00
Chris Morgan
0a9f8cc155
Performance improvements to version and application classes. Reduce the amount of queries to
...
what is necessary during object creation. The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
f05c05864e
Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
...
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
e9456af9d5
application::display() should use the class internal iAppId instead of any $_REQUEST data
2006-07-07 19:23:58 +00:00
Chris Morgan
854df987c6
Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
...
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
3d6da668a1
Remove require_once("mail.php") that was causing mail.php to be duplicately included. A cleaner fix is necessary
2006-07-06 22:35:01 +00:00
Chris Morgan
ea02b57c25
Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
...
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828
Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
...
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c
Remove unnecessary exit calls after redirect() and util_show_error_page() calls
2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Chris Morgan
fad9278013
Stop using compile_update_string(). compile_update_string() can be passed a value that includes a character considered
...
special by query_parameters(). We then use the output from compile_update_string() as a part of the first
parameter to query_parameters(), the format string. Having extra special characters causes a token mismatch
and query_parameters() will reject the queries entirely. Remove now unused compile_update_string().
2006-07-04 03:43:06 +00:00
Chris Morgan
a044596c31
Add in missing & between url parameters
2006-07-04 02:24:56 +00:00
Chris Morgan
a72f31e11a
Rename some variables to match our current naming scheme
2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a
Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php
2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc
Clean up application and version classes. Move class related functions into the class as static member functions
2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e
Cleanup User class. Move user related functions into class as static member functions
2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
ac5b4b0a95
Warn if magic quotes is enabled and explain a bit about why we require that magic quotes
...
be disabled. Also remove all of the conditional code that was working around cases where
we had magic quotes enabled. We were only working around a small portion of cases where magic
quotes was affecting the appdb.
2006-06-26 00:44:44 +00:00
Chris Morgan
fb0f3b5dd3
Protect against sql injection attacks in sql INSERT statements
2006-06-24 04:20:32 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
Alexander Nicolaysen Sørnes
270ea39bc9
Make the use of capitalization in the Application Form more consistent
2006-05-04 00:23:39 +00:00
Alexander Nicolaysen Sørnes
300ad22e4b
When vendor changes display before and after vendors instead of displaying the before vendor
...
twice.
2006-04-16 16:33:41 +00:00
Tony Lambregts
092487fe91
Cleanup email code
2006-02-22 02:20:02 +00:00
Chris Morgan
e309c1b44a
Move html output of application and version into the application and version classes
2006-01-29 04:04:46 +00:00
Tony Lambregts
767faeac75
Application class fixes. Let update be silent when we want it to be. Get rid of redundant message in unqueue(). Fix logic in SendNotificationMail().
2006-01-28 23:04:21 +00:00
Tony Lambregts
33302f72ef
Make back link in rejection emails point to appsubmit.php
2006-01-18 04:32:28 +00:00
Chris Morgan
369b40b046
Fix SendNotificationEmail() so it appends to the existing message in the 'edit' case instead of overwriting the message passed in
2005-12-05 04:19:14 +00:00
Tony Lambregts
8ebccb4f2a
Add test results as part of submitting an application or version
2005-10-28 00:11:35 +00:00
Chris Morgan
696aab7ad8
Retrieve versions for an application based on the users permissions
2005-10-26 23:54:43 +00:00
Chris Morgan
89abe706dc
Improve permission checking in objects, fix some initialization bugs
2005-10-26 02:09:49 +00:00