Commit Graph

800 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
cc57367fe3 Order versions by id 2007-06-10 00:28:52 +00:00
Alexander Nicolaysen Sørnes
b71bf8bd01 Sort applications by id 2007-06-10 00:27:54 +00:00
Alexander Nicolaysen Sørnes
2adec2d724 Sort testData by id 2007-06-10 00:14:03 +00:00
Chris Morgan
ea2de6fe3c Screenshot::delete() and Image::delete() should check if the file exists before attempting to
call unlink() on it. Fixes three php errors that occur during the unit tests.
2007-06-09 22:17:32 +00:00
Alexander Nicolaysen Sørnes
95fc2d366b Add multi-page support to objectManager, use it for the vendor class 2007-06-09 17:07:02 +00:00
Alexander Nicolaysen Sørnes
095d228296 Fix app/version rejection. Version queue requeue wasn't requeueing its downloadurl, downloadurl
class was missing objectManager functionality. Rejected appData wasn't being accounted for.
2007-06-09 15:44:46 +00:00
Chris Morgan
0cd6de7970 Programmatically fix up the bugzilla versions list. Sort the versions with the newest version first, limit the
total number of versions to 6 by truncating the array and manually add the 'CVS' entry since we trim this entry
off. This should make it easier for users to figure out which version to pick.
2007-06-07 02:43:57 +00:00
Chris Morgan
e6b869da5d Add cellpadding to make the duplicates table look nicer 2007-06-07 02:40:51 +00:00
Chris Morgan
b59a1d0b1f Add a column to the test data queue to indicate whether a test result is for a application version
that has maintainers. This lets admins defer processing test results to give appliction and version maintiners
a chance to do so.
2007-06-07 02:04:15 +00:00
Chris Morgan
8970888921 Add a comment to encourage test result submitters not to include crash data in their test
submissions.
2007-06-05 03:35:46 +00:00
Chris Morgan
2d4b27530d Upgrade to Xinha 0.931. Xinha has been optimized for size and dozens of issues have been closed
out since the last upgrade . Add Firefox and Xinha buttons to main page to show our support.
2007-05-31 22:43:05 +00:00
Alexander Nicolaysen Sørnes
ff46a4485d user: don't make links when userId is not set 2007-05-31 14:55:36 +00:00
Alexander Nicolaysen Sørnes
a2f25be661 Avoid some warnings in the appData class 2007-05-31 02:44:51 +00:00
Alexander Nicolaysen Sørnes
cb18a07f60 downloadurl: Add more objectManager functions. Allow us to unqueue queued downloadurls that are
currently stuck in limbo.
2007-05-31 02:40:01 +00:00
Alexander Nicolaysen Sørnes
b2b950cb10 Fix un-queueing of download urls 2007-05-31 02:33:36 +00:00
Alexander Nicolaysen Sørnes
9f788ada66 Fix display of download url in app queue 2007-05-31 02:31:14 +00:00
Alexander Nicolaysen Sørnes
5d030f8b2d Speedup appData::objectGetEntries() 2007-05-28 21:44:14 +00:00
Alexander Nicolaysen Sørnes
9ad365e1bd Speedup appData::objectGetEntriesCount() when selecting un-queued entries or we are an admin. 2007-05-28 20:10:49 +00:00
Ben Hodgetts
2984070157 Add more detail to the test data submission page 2007-05-26 17:01:11 +00:00
Chris Morgan
b2ed10c433 Clarify README to specify that you must update APPDB_ROOT to point to your own address. Update
the config.php.sample to not refer to the actuall appdb site. Users may forget to update this
field and end up on the live site without realizing it and do some unintended damage.
2007-05-26 16:32:45 +00:00
Chris Morgan
c39dbe83a9 Add page generation times to the bottom of each page. This should help us figure out which pages
take the longest time to generate
2007-05-26 04:05:20 +00:00
Alexander Nicolaysen Sørnes
d209c56979 Include bug id in more buglink mails 2007-05-26 01:39:46 +00:00
Alexander Nicolaysen Sørnes
299f2b3c2a Adding missing alt attribute to screenshot overlay 2007-05-26 01:38:48 +00:00
Alexander Nicolaysen Sørnes
bab429ee90 Return true when creating duplicate distributions 2007-05-26 01:37:25 +00:00
Alexander Nicolaysen Sørnes
f4b7f2bd04 Don't display supermaintainers twice on maintainer processing screen. When printing the list of
non-super maintainers, only print the entry if the user is not a super maintainer
2007-05-13 16:54:33 +00:00
Alexander Nicolaysen Sørnes
b32249dec6 Don't create duplicate vendors. If there is a vendor with the same name as the one being
created retrieve the duplicate vendors information for the current object and return TRUE,
even though we didn't really create new vendor we can handle this error situation more
gracefully than returning false.
2007-05-12 16:54:58 +00:00
Alexander Nicolaysen Sørnes
f7ae814cbb Implement vendor::objectMoveChildren() 2007-05-12 16:34:28 +00:00
Alexander Nicolaysen Sørnes
6b7b9add74 Use separate setting for the email sender address. This allows the appdb emails to be sent
from a different address than the default one. Use the sender address to point email
responses to the new noreply address.
2007-05-12 16:30:32 +00:00
Chris Morgan
25edd78c73 Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
d09f78ca00 Get rid of the distribution queue. If a testData entry is deleted and its associated
distribution has not been approved and has no other testData assigned to it the distribution
is now deleted. This change makes the distribution queue unnecessary as distributions are
accepted along the testData
2007-04-27 23:45:19 +00:00
Alexander Nicolaysen Sørnes
eb49e9344d Add om method for displaying a move child objects page. A link to this page is displayed in
an entry's view page automatically if the class that entry has the required methods
objectMoveChildren and objectGetId
2007-04-27 23:43:43 +00:00
Alexander Nicolaysen Sørnes
2f3587f15d Fix note update mails to include changes again. Append the version url to the message text
instead of overwriting it
2007-04-27 23:33:34 +00:00
Alexander Nicolaysen Sørnes
e87db015c2 Allow maintainers to submit un-queued distributions.They are allowed to submit un-queued
testData for the versions they maintain, so without this change they submit un-queued test
results associated with a queued distribution. This doesn't make any sense since the
testData would be active but the distribution queued. It's cleaner to just let maintainers
unqueue distributions for versions they maintain.
2007-04-27 23:22:37 +00:00
Alexander Nicolaysen Sørnes
6f302bdc98 application_queue, only delete version if it exists. application_queue::delete() should
check that the version object exists because when moving a duplicate application is deleted
before the application
2007-04-27 00:13:28 +00:00
Alexander Nicolaysen Sørnes
518def1855 Return from version::delete() if there isn't a valid version id 2007-04-27 00:06:07 +00:00
Alexander Nicolaysen Sørnes
a7789c2a8d Fix loading of 'Runs?' value in the testData form, otherwise the value is displayed as
though no value is set
2007-04-26 00:17:42 +00:00
Alexander Nicolaysen Sørnes
b11cce6711 Use objectManager to submit and process applications. Remove now unused appsubmit.php
admin/adminAppQueue.php
2007-04-24 23:48:14 +00:00
Alexander Nicolaysen Sørnes
3a3aa89f4e Fix empty mail upon version acceptance. version::unQueue() was passing the wrong argument to
mailSubmitter()
2007-04-24 23:41:22 +00:00
Alexander Nicolaysen Sørnes
ec8312233c Display add item help text after fetching input values. This allows the help text functions
to output help depending on the state of the edited object
2007-04-24 23:40:12 +00:00
Alexander Nicolaysen Sørnes
982dc97756 Always read input first in downloadurl::outputEditorSingle(). Makes sure changes aren't lost
when reloading the form due to input errors
2007-04-24 23:38:41 +00:00
Alexander Nicolaysen Sørnes
74425f0b5a Fix TableVE::make_option_list's where handling to prevent sql injection 2007-04-24 23:36:10 +00:00
Alexander Nicolaysen Sørnes
f688be7c4d Support silent input checking. checkOutputEditorInput() can now return TRUE instead of a
list of errors
2007-04-24 00:35:51 +00:00
Alexander Nicolaysen Sørnes
d03359ed2e Warn user when pressing the vote button without selecting a slot 2007-04-24 00:22:36 +00:00
Alexander Nicolaysen Sørnes
43fa6617d4 Prevent display of \n in version view that was caused by a typo 2007-04-23 23:40:41 +00:00
Alexander Nicolaysen Sørnes
6bf507d6aa Fix a case where the admins would see the wrong help text when submitting new testData. Add
borders around the distribution form to match the rest of the editor
2007-04-23 23:39:44 +00:00
Alexander Nicolaysen Sørnes
42ecaf6eef Fix typo in testData::update() causing the new release info to be absent from the mail sent 2007-04-23 23:38:30 +00:00
Alexander Nicolaysen Sørnes
9b4bb81aec Fix bug link creation email. We only need to fetch the link id so remove the other code that
was resulting in missing values.
2007-04-23 23:37:30 +00:00
Alexander Nicolaysen Sørnes
fa050164f7 Add debug option to output e-mail on screen. Useful for testing that mails look correct. 2007-04-23 23:36:32 +00:00
Alexander Nicolaysen Sørnes
a5492e199a Add vendor->sQueued class variable. Not currently used but adding it keeps the vendor class
consistent with other classes.
2007-04-23 23:32:30 +00:00