Commit Graph

32 Commits

Author SHA1 Message Date
Chris Morgan
cd5a620d88 testData class cleanup. Move some test related functions into the class as
static functions.  Clean up some variable names.
2006-07-10 15:39:21 +00:00
Tony Lambregts
6405eeafa4 Show tested rating and use its color when displaying the list of test results 2006-07-10 03:46:48 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
fad9278013 Stop using compile_update_string(). compile_update_string() can be passed a value that includes a character considered
special by query_parameters().  We then use the output from compile_update_string() as a part of the first
parameter to query_parameters(), the format string.  Having extra special characters causes a token mismatch
and query_parameters() will reject the queries entirely.  Remove now unused compile_update_string().
2006-07-04 03:43:06 +00:00
Tony Lambregts
611cc12aeb Pass a version object to hasAppVersionModifyPermission(), not a version id integer 2006-07-04 02:52:39 +00:00
Tony Lambregts
1fd44ae416 Make the back link in the test results email useful to everyone, not just appdb admins and app maintainers 2006-06-30 16:38:05 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Tony Lambregts
1932248293 Don't allow empty "what works", "what was tested" and "what was not" fields 2006-06-27 05:44:24 +00:00
Chris Morgan
ac5b4b0a95 Warn if magic quotes is enabled and explain a bit about why we require that magic quotes
be disabled.  Also remove all of the conditional code that was working around cases where
we had magic quotes enabled.  We were only working around a small portion of cases where magic
quotes was affecting the appdb.
2006-06-26 00:44:44 +00:00
Chris Morgan
63d90984a1 Fix a warning due to missing first parameter when testData::OutputEditor() is called from adminTestResults.php.
At this point we never expect to have a $sDistribution so we can just default the parameter to a null string
2006-06-24 05:02:56 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
3537fcbd88 Fix entering a new distribution when submitting a new application or version 2006-06-24 02:38:44 +00:00
Tony Lambregts
fdc0760ce6 Open ratings definitions page in a new window so we don't erase any data a user has entered into input boxes 2006-06-17 06:12:28 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Alexander Nicolaysen Sørnes
24d1d1b598 Add link to rating definitions next to 'raiting' field on the test submission form 2006-06-03 22:17:00 +00:00
Alexander Nicolaysen Sørnes
b8318e22ca Improve language consistency in testResults.php 2006-05-04 00:24:18 +00:00
Chris Morgan
0d9766059c Remove extra 'slash' in url that was causing all kinds of issues like users going to odd websites
after clicking on some links on the site
2006-04-06 02:02:52 +00:00
Tony Lambregts
4bd603af4f Give maintainers/administrators an easy way to edit test results 2006-04-03 03:51:26 +00:00
Tony Lambregts
092487fe91 Cleanup email code 2006-02-22 02:20:02 +00:00
Tony Lambregts
facd6bdb17 Modify 'installs' and 'runs' fields 2006-02-08 01:44:11 +00:00
Jason Weisberger
b5d70fc27a Allow the user to limit or show all of the testing results for a particular version 2006-01-28 22:53:28 +00:00
Chris Morgan
e7935b1f4f Pass a version object into user::hasAppVersionModifyPermission() instead of
the integer that is the index of the version in the database.
2006-01-23 02:10:31 +00:00
Tony Lambregts
9a72e97f53 Test result count should not include queued tests. Don't display queued test results in test results table. 2006-01-17 02:34:58 +00:00
Chris Morgan
91fe4dd26c Fix two bugs found after upgrading to php5 2005-11-12 04:37:48 +00:00
Tony Lambregts
8c6c609089 Change mysqltimestamp_to_unixtimestamp() to mysqldatetime_to_unixtimestamp() because we are operating on a datetime 2005-10-28 00:21:37 +00:00
Jonathan Ernst
fdf642ce89 Show the test date instead of the submission date. Sort the test results by test date instead of by a string sort on release name 2005-10-28 00:14:46 +00:00
Chris Morgan
61f29dc94d Remove debugging comment line 2005-10-26 13:44:17 +00:00
Tony Lambregts
b0d2969e0b Clean up view distributions, add back link to the application version, use the correct time function 2005-10-18 02:04:16 +00:00
Tony Lambregts
ba6e92d184 Lets users submit application testing results in a uniform and easy to process manner 2005-10-17 03:59:24 +00:00