Commit Graph

34 Commits

Author SHA1 Message Date
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Jonathan Ernst
2a2c423d9c Enable filtering in account.php 2006-07-07 16:18:07 +00:00
Jonathan Ernst
f357d8dc07 Add documentation to account.php 2006-07-07 15:50:41 +00:00
Chris Morgan
427262a5c2 Fix account creation. Change cmd to sCmd like the account.php code expects 2006-07-07 15:45:48 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
a34058b924 Update the comments in some files 2006-07-06 18:37:34 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
4706e36595 Fix variable naming of preferences/account related form variables to match our coding standards 2006-07-06 04:46:13 +00:00
Chris Morgan
81057d13ab Use $GLOBALS['session']->destroy() instead of setting $_SESSION['current'] = "". Using "" means that $_SESSION['current']
could be set but be a string. Don't call addmsg() after logging out otherwise the session message will be lost and can
show up for other users or be stuck in the database
2006-07-06 04:21:04 +00:00
Chris Morgan
82b95b8f6d Cleanup variable naming in account.php 2006-07-06 03:45:17 +00:00
Chris Morgan
2b0d5716bb Move $_SESSION['current'] manipulation into user class. Add user::logout() to keep user::login() and logout() symmetrical 2006-07-06 03:37:49 +00:00
Chris Morgan
75d1722236 Fix requesting a new password. Missed a user::update() -> user::update_password() call. Add a more explicit
message in the case where the user doesn't enter any email address.
2006-06-29 16:34:18 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
98ba61db03 Clean up user class. Implement start of unit testing framework for appdb.
Implement start of user class unit test.
2006-06-27 03:59:16 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
1069478c8a Prevent users from creating accounts with a blank username 2006-06-16 02:04:33 +00:00
Tony Lambregts
7250f751e5 Fix session current cookie being corrupted when creating a user and the user exists. 2006-06-16 02:03:12 +00:00
Chris Morgan
72080953ef Don't urlencode the users email address when displaying it back to the user, otherwise
we'll see stuff like blah%40yourdomain.com
2006-02-05 20:46:10 +00:00
Rafal Maj
05cacbfe22 Clarify that appdb and bugzilla have separate accounts when a user is requesting
their password from the appdb.
2006-02-05 20:44:32 +00:00
Chris Morgan
369d5f4df0 Log new users in automatically if the user was successfully created 2005-08-14 18:56:35 +00:00
Jonathan Ernst
ddfb83e988 Fix send lost password feature 2005-02-06 22:34:43 +00:00
Jonathan Ernst
2083bf521b - OO version of user class
- no more duplicated functions
- improved performances (much less duplicated mysql queries)
- less code and better error handling
2005-01-30 23:12:48 +00:00
Jonathan Ernst
0a839e359a - use mail_appdb() instead of mail() for better error handling and to avoid code duplication
- use \r\n as line separator in mail (RFC compliant)
2005-01-30 00:57:34 +00:00
Jonathan Ernst
d9826427da This patch make email address the user's username as requested in the TODO.
query_users.php is modified even if we will drop it in the future to be sure it works everywhere.
2005-01-10 22:54:04 +00:00
Tony Lambregts
ff64795163 Fix to allow creating of new accounts 2005-01-05 19:08:06 +00:00
Marcus Meissner
ddbd9ed0cc Fix 2 cross site scripting problems. 2004-12-19 17:54:09 +00:00
Jeremy Newman
5642e73425 updated to a slightly more improved version of the session management code
should solve bugs with logging in on register_globals = off;
2004-12-13 03:50:02 +00:00
Jonathan Ernst
d3d9e853d9 - replaced tons of tabs with spaces
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
Jonathan Ernst
bd91db228c - access most globals by their $_XYZ['varname'] name
- fix some code errors and typos (missing $ in front of variable names
and so on)
- fixed a lot of warnings that would have been thrown when error_reporting
is set to show notices (if(isset($variable))) instead of if($variable) for
example)
2004-12-10 01:07:45 +00:00
Chris Morgan
3b09de0902 Fix some indenting in account.php. 2004-12-01 22:26:04 +00:00
Chris Morgan
c2a45094e2 Add a dropdown list of vendors to the app submit page. Automatch the dropdown
vendor selection on the admin side of there is an exact or partial name match.
Clear out the vendor field if a match is found.
Display username when logging in to the db.
2004-04-06 21:26:10 +00:00
Jeremy Newman
8f28ae10c4 Initial revision 2004-03-15 16:22:00 +00:00