Chris Morgan
00aacdeadd
Fix some inconsistent braces and add a comment to the objectManager code
2007-04-22 15:52:06 +00:00
Chris Morgan
af465791f7
Work around bug where submitting versions resulted in testData not being properly queued
2007-04-22 05:21:12 +00:00
Chris Morgan
e83b9b2d58
Fix test result issue with incorrect name causing an error when 'Limit to 5 tests' was
...
selected
2007-04-22 04:23:57 +00:00
Alexander Nicolaysen Sørnes
2a7d8e8c3f
Support vendor queuing
2007-04-22 00:57:41 +00:00
Alexander Nicolaysen Sørnes
8cf53f1679
Use mustBeQueued() to determine unqueueing in objectManager
2007-04-22 00:39:53 +00:00
Alexander Nicolaysen Sørnes
3dc453112a
Use objectManager to list a user's rejected apps
2007-04-22 00:02:30 +00:00
Alexander Nicolaysen Sørnes
b292a84bcf
Use version::mustBeQueued() instead of user function
2007-04-21 19:50:52 +00:00
Alexander Nicolaysen Sørnes
995076af3b
Fix warnings in downloadurl::processForm(). Calling this method with inappropriate $aClean[]
...
data is perfectly valid but in tht case the function should return silently
2007-04-21 19:46:17 +00:00
Alexander Nicolaysen Sørnes
8093a81da2
Display user manager link in the contact form
2007-04-21 19:45:12 +00:00
Alexander Nicolaysen Sørnes
2af11e7333
Remove user::deleteAppData() and replace it with an appData function
2007-04-21 19:44:10 +00:00
Alexander Nicolaysen Sørnes
59d97b676d
Display user name in the maintainer approval form
2007-04-21 18:23:11 +00:00
Alexander Nicolaysen Sørnes
19d1393fe5
Fix testData_queue's distribution handling. Only update the distribution if the name is set
...
and avoid a misguiding message by not doing unQueue() on already unqueued distributions.
2007-04-21 18:22:14 +00:00
Alexander Nicolaysen Sørnes
33ee8c4458
Repalce '"' with '"' in the distribution form. Otherwise we end up with broken <input>
...
fields
2007-04-21 18:09:13 +00:00
Alexander Nicolaysen Sørnes
be52279bfa
Fix comment creation. addcomment.php was passing a filled-in object to comment::create()
...
which still expected values as parameters. Load data from the object instead
2007-04-21 18:05:32 +00:00
Alexander Nicolaysen Sørnes
bea4e89c56
Only display move test table for existing versions, not queued ones
2007-04-21 18:03:25 +00:00
Alexander Nicolaysen Sørnes
8358a09a13
Use objectManager to display a user's rejected versions
2007-04-21 18:00:46 +00:00
Alexander Nicolaysen Sørnes
2e0831cd22
Redirect to version-queue after moving tests. admin/adminAppQueue.php should redirect to
...
'version_queue' instead of 'version'
2007-04-21 17:55:33 +00:00
Alexander Nicolaysen Sørnes
1107fb938b
Add and use application::mustBeQueued()
2007-04-21 17:51:42 +00:00
Alexander Nicolaysen Sørnes
208033d788
Add and use distribution::mustBeQueued()
2007-04-21 17:50:44 +00:00
Alexander Nicolaysen Sørnes
3ab921cf0d
Add appData/screenshot::mustBeQueued()
2007-04-21 17:49:43 +00:00
Alexander Nicolaysen Sørnes
a6127c1b07
Rename user::count() to objectGetEntriesCount() for consistency with the other generic
...
object methods
2007-04-21 17:06:50 +00:00
Alexander Nicolaysen Sørnes
27e0589a77
Remove unused appData functions from the user class
2007-04-21 17:05:54 +00:00
Alexander Nicolaysen Sørnes
171a8c01c4
Include <a> links for menu items. This is necessary for browsers without JavaScript and it
...
makes it possible to see the url the link is pointing to
2007-04-21 16:54:17 +00:00
Chris Morgan
cf9cba4093
Objects should set class variables and call create() instead of passing the parameters into the
...
create() function.
2007-04-21 02:30:22 +00:00
Alexander Nicolaysen Sørnes
96bfe05734
Display move test results table when processing a version
2007-04-21 01:20:43 +00:00
Chris Morgan
434de30b9c
Correct a few undefined variable errors brought out by the unit tests
2007-04-21 01:17:38 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17
More fixes and uses for objectManager's version/testData queues
2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
dad5de17b1
Test version/testData queues. Test version_queue and testData_queue with the objectManager
...
tests
2007-04-21 00:58:08 +00:00
Alexander Nicolaysen Sørnes
a8a4da643b
Make testData's objectGetEntries more consistent for rejected testData. Don't allow
...
maintainers to view rejected entries for the versions they maintain, but show them their own
rejected entries instead
2007-04-20 00:02:20 +00:00
Alexander Nicolaysen Sørnes
67f61bbda5
Delete admin/resubmitRejectedApps.php, this file is no longer used
2007-04-19 23:53:28 +00:00
Alexander Nicolaysen Sørnes
4adcb4ad85
Highlight maintained apps/versions in the menu
2007-04-19 23:51:23 +00:00
Alexander Nicolaysen Sørnes
e176c0a9c7
Only show un-queued distributions in the testData list
2007-04-19 23:48:23 +00:00
Alexander Nicolaysen Sørnes
c43563eca6
Fix testData::create() permissions. Separate the cases where a user has edit rights from
...
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
2a58cf59af
Conform testData_queue to OM standards
2007-04-19 23:19:24 +00:00
Chris Morgan
b534f6d898
Use html_tr_hightlight_clickable() in menu.php add() to make linkable rows of menus
...
clickable. Provides visual feedback of which entry is active and enables users to click
anywhere in the menu row, not just on the url.
2007-04-19 01:20:55 +00:00
Alexander Nicolaysen Sørnes
cab71714cc
Include testData_queue.php in objectManager. Document usage at the top of objectManager.php.
...
----------------------------------------------------------------------
2007-04-18 23:18:45 +00:00
Alexander Nicolaysen Sørnes
74c8fe502f
Show more register links. Make registration easier by showing a register link together with
...
the log in link on the front page and on the user menu.
2007-04-17 23:30:51 +00:00
Alexander Nicolaysen Sørnes
fbb784c2f5
Fix mails for updated test results. Pass the correct 'edit' parameter to
...
sendNotificationMail() and only send mail if the test data has been changed.
2007-04-17 23:28:10 +00:00
Alexander Nicolaysen Sørnes
82ab0c467f
Allow setting admin privileges in the user mananger
2007-04-17 23:21:34 +00:00
Alexander Nicolaysen Sørnes
efae38f6bf
Use html_tr() function in distribution::outputEditor()
2007-04-17 23:19:48 +00:00
Alexander Nicolaysen Sørnes
b584fe1df7
Fix maintainer listing for versions. getMaintainersForAppIdVersionId() did not check that
...
additional entries had a superMaintainer = 1 so a maintainer of one version would be listed
as the maintainer for all versions of the application. Correct that issue and update the
unit test.
2007-04-16 23:19:44 +00:00
Alexander Nicolaysen Sørnes
46df59f063
Use objectManager for new test results
2007-04-16 23:10:08 +00:00
Alexander Nicolaysen Sørnes
a309317347
Fix url::canEdit() to not call undefined functions
2007-04-16 22:59:48 +00:00
Alexander Nicolaysen Sørnes
20ebe74913
Use absolute path in application::objectMakeUrl(), otherwise mail links won't work
2007-04-09 01:24:34 +00:00
Alexander Nicolaysen Sørnes
7825da1dc5
addcomment.php, use version::objectMakeUrl()
2007-04-09 01:23:11 +00:00
Alexander Nicolaysen Sørnes
ba3f966da4
test maintainer::getMaintainersForAppIdVersionId()
2007-04-08 23:06:27 +00:00
Alexander Nicolaysen Sørnes
169d7ca493
Use objectMakeUrl()/Link() in more places
2007-04-08 23:04:31 +00:00
Alexander Nicolaysen Sørnes
9de4e9b63b
Test version class in objectManager tests
2007-04-08 23:01:22 +00:00
Alexander Nicolaysen Sørnes
ff476b1b13
Use objectmanager to list queued/rejected versions
2007-04-07 20:42:08 +00:00
Alexander Nicolaysen Sørnes
ec0cb3dbbb
make version::objectGetEntriesCount() more consistent for rejected versions by not allowing
...
maintainers to see rejected versions for applications they maintain
2007-04-05 02:29:22 +00:00
